CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 00:50:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Convert fields to ES6 classes (#5943)

Browse Source 
* refactor: Initial test at refactoring fields to ES6

* refact: reorganize text input and descendants to call super first

* refact: run conversion script on text input field and subclasses

* clean: cleanup fields post-conversion script

* refact: reorganize dropdown and variable fields to call super first

* refact: run class conversion script on dropdown and variable

* clean: clean fields post conversion script

* refact: reorganize misc fields to call super first

* refact: run conversion script on misc fields

* clean: cleanup misc fields after conversion

* fix: add setting the value and whatnot back to the base field. Pass sentinel conistently

* format

* refact: work on making debug compiler happy

* clean: finish making debug build happy

* fix: work on making tests happy

* fix: finish making tests happy

* Fix: fixup angle and multiline fields

* clean: format

* fix: move default value back to DEFAULT_VALUE

* fix: change SENTINEL to SKIP_SETUP

* fix: inline docs

* fix: some misc PR comments

* fix: format

* fix: make compiler hapy with new.target

* fix: types in FieldDropdown

* fix: add @final annotations to Field

* feat: move Sentinel to a utils file

* fix: remove ImageProperties from external API

* clean: cleanup chunks and deps
This commit is contained in:
Beka Westberg
2022-02-28 08:59:33 -08:00
committed by GitHub
parent 4201d43d55
commit cb4521b645
18 changed files with 4765 additions and 4496 deletions
Download Patch File Download Diff File Expand all files Collapse all files

93
scripts/gulpfiles/chunks.json
View File

@@ -1,6 +1,6 @@
{
"chunk": [
"blockly:259",
"blockly:260",
"blocks:10:blockly",
"all:11:blockly",
"all1:11:blockly",
@@ -21,7 +21,6 @@
"./core/field_number.js",
"./core/field_multilineinput.js",
"./core/field_label_serializable.js",
"./core/field_dropdown.js",
"./core/field_colour.js",
"./core/field_checkbox.js",
"./core/field_angle.js",
@@ -57,8 +56,6 @@
"./core/contextmenu_items.js",
"./core/widgetdiv.js",
"./core/clipboard.js",
"./core/menuitem.js",
"./core/menu.js",
"./core/contextmenu.js",
"./core/utils/global.js",
"./core/utils/useragent.js",
@@ -80,16 +77,23 @@
"./core/utils/math.js",
"./core/utils/array.js",
"./core/workspace.js",
"./core/keyboard_nav/basic_cursor.js",
"./core/keyboard_nav/tab_navigate_cursor.js",
"./core/warning.js",
"./core/comment.js",
"./core/menu.js",
"./core/menuitem.js",
"./core/interfaces/i_registrable_field.js",
"./core/shortcut_registry.js",
"./core/interfaces/i_keyboard_accessible.js",
"./core/events/events_block_drag.js",
"./core/events/events_block_move.js",
"./core/bump_objects.js",
"./core/block_dragger.js",
"./core/workspace_dragger.js",
"./core/interfaces/i_block_dragger.js",
"./core/bubble_dragger.js",
"./core/keyboard_nav/basic_cursor.js",
"./core/keyboard_nav/tab_navigate_cursor.js",
"./core/mutator.js",
"./core/warning.js",
"./core/comment.js",
"./core/events/events_block_move.js",
"./core/events/events_viewport.js",
"./core/events/events_theme_change.js",
"./core/events/events_block_create.js",
@@ -119,10 +123,12 @@
"./core/theme_manager.js",
"./core/scrollbar_pair.js",
"./core/options.js",
"./core/marker_manager.js",
"./core/interfaces/i_bounded_element.js",
"./core/grid.js",
"./core/css.js",
"./core/flyout_button.js",
"./core/keyboard_nav/cursor.js",
"./core/contextmenu_registry.js",
"./core/theme/classic.js",
"./core/blockly_options.js",
@@ -134,7 +140,8 @@
"./core/renderers/zelos/path_object.js",
"./core/renderers/zelos/drawer.js",
"./core/renderers/zelos/renderer.js",
"./core/utils/aria.js",
"./core/utils/keycodes.js",
"./core/dropdowndiv.js",
"./core/field_textinput.js",
"./core/field_image.js",
"./core/renderers/zelos/constants.js",
@@ -145,6 +152,13 @@
"./core/renderers/measurables/spacer_row.js",
"./core/renderers/measurables/round_corner.js",
"./core/renderers/common/path_object.js",
"./core/events/events_marker_move.js",
"./core/keyboard_nav/marker.js",
"./core/interfaces/i_ast_node_location_svg.js",
"./core/interfaces/i_ast_node_location.js",
"./core/interfaces/i_ast_node_location_with_block.js",
"./core/keyboard_nav/ast_node.js",
"./core/renderers/common/marker_svg.js",
"./core/interfaces/i_positionable.js",
"./core/interfaces/i_drag_target.js",
"./core/interfaces/i_delete_area.js",
@@ -166,6 +180,7 @@
"./core/interfaces/i_toolbox.js",
"./core/utils/metrics.js",
"./core/interfaces/i_metrics_manager.js",
"./core/interfaces/i_registrable.js",
"./core/interfaces/i_flyout.js",
"./core/metrics_manager.js",
"./core/interfaces/i_deletable.js",
@@ -181,6 +196,10 @@
"./core/renderers/common/info.js",
"./core/renderers/measurables/field.js",
"./core/renderers/common/debugger.js",
"./core/utils/sentinel.js",
"./core/field_label.js",
"./core/input_types.js",
"./core/input.js",
"./core/renderers/measurables/input_connection.js",
"./core/renderers/measurables/in_row_spacer.js",
"./core/renderers/measurables/row.js",
@@ -188,42 +207,23 @@
"./core/renderers/measurables/base.js",
"./core/renderers/measurables/connection.js",
"./core/renderers/measurables/next_connection.js",
"./core/renderers/measurables/bottom_row.js",
"./core/renderers/common/debug.js",
"./core/renderers/common/block_rendering.js",
"./core/variables_dynamic.js",
"./core/events/events_var_rename.js",
"./core/events/events_var_delete.js",
"./core/variable_map.js",
"./core/names.js",
"./core/events/events_marker_move.js",
"./core/renderers/common/marker_svg.js",
"./core/keyboard_nav/marker.js",
"./core/keyboard_nav/ast_node.js",
"./core/keyboard_nav/cursor.js",
"./core/marker_manager.js",
"./core/field_label.js",
"./core/input_types.js",
"./core/interfaces/i_registrable_field.js",
"./core/field_registry.js",
"./core/input.js",
"./core/interfaces/i_registrable.js",
"./core/utils/keycodes.js",
"./core/shortcut_registry.js",
"./core/interfaces/i_keyboard_accessible.js",
"./core/interfaces/i_ast_node_location_with_block.js",
"./core/interfaces/i_ast_node_location.js",
"./core/interfaces/i_ast_node_location_svg.js",
"./core/dropdowndiv.js",
"./core/theme.js",
"./core/constants.js",
"./core/interfaces/i_connection_checker.js",
"./core/connection_db.js",
"./core/config.js",
"./core/rendered_connection.js",
"./core/utils/svg_paths.js",
"./core/renderers/common/constants.js",
"./core/field.js",
"./core/renderers/measurables/bottom_row.js",
"./core/renderers/common/debug.js",
"./core/renderers/common/block_rendering.js",
"./core/variables_dynamic.js",
"./core/events/events_block_base.js",
"./core/events/events_block_change.js",
"./core/events/events_var_rename.js",
"./core/events/events_var_delete.js",
"./core/variable_map.js",
"./core/names.js",
"./core/events/events_ui_base.js",
"./core/events/events_bubble_open.js",
"./core/procedures.js",
@@ -234,31 +234,32 @@
"./core/utils/style.js",
"./core/utils/deprecation.js",
"./core/utils/svg_math.js",
"./core/bubble_dragger.js",
"./core/connection_type.js",
"./core/internal_constants.js",
"./core/constants.js",
"./core/block_svg.js",
"./core/block_animations.js",
"./core/gesture.js",
"./core/touch.js",
"./core/browser_events.js",
"./core/tooltip.js",
"./core/block_svg.js",
"./core/events/events_block_base.js",
"./core/events/events_block_change.js",
"./core/utils/xml.js",
"./core/mutator.js",
"./core/field.js",
"./core/field_registry.js",
"./core/utils/aria.js",
"./core/field_dropdown.js",
"./core/msg.js",
"./core/utils/colour.js",
"./core/utils/parsing.js",
"./core/extensions.js",
"./core/block.js",
"./core/utils/string.js",
"./core/utils/object.js",
"./core/dialog.js",
"./core/utils/xml.js",
"./core/events/events_var_base.js",
"./core/events/events_var_create.js",
"./core/variable_model.js",
"./core/variables.js",
"./core/utils/object.js",
"./core/events/events_abstract.js",
"./core/registry.js",
"./core/events/utils.js",