diff --git a/blocks/loops.js b/blocks/loops.js index d8dae09ba..a60df7b8b 100644 --- a/blocks/loops.js +++ b/blocks/loops.js @@ -336,10 +336,10 @@ Blockly.Constants.Loops.CONTROL_FLOW_IN_LOOP_CHECK_MIXIN = { /** * Called whenever anything on the workspace changes. * Add warning if this flow block is not nested inside a loop. - * @param {!Blockly.Events.Abstract} e Change event. + * @param {!Blockly.Events.Abstract} _e Change event. * @this Blockly.Block */ - onchange: function(/* e */) { + onchange: function(_e) { if (!this.workspace.isDragging || this.workspace.isDragging()) { return; // Don't change state at the start of a drag. } diff --git a/blocks/procedures.js b/blocks/procedures.js index c679ce54d..591a751a1 100644 --- a/blocks/procedures.js +++ b/blocks/procedures.js @@ -1048,10 +1048,10 @@ Blockly.Blocks['procedures_ifreturn'] = { /** * Called whenever anything on the workspace changes. * Add warning if this flow block is not nested inside a loop. - * @param {!Blockly.Events.Abstract} e Change event. + * @param {!Blockly.Events.Abstract} _e Change event. * @this Blockly.Block */ - onchange: function(/* e */) { + onchange: function(_e) { if (!this.workspace.isDragging || this.workspace.isDragging()) { return; // Don't change state at the start of a drag. } diff --git a/blocks/variables_dynamic.js b/blocks/variables_dynamic.js index 03b34c2cb..b0ad6206b 100644 --- a/blocks/variables_dynamic.js +++ b/blocks/variables_dynamic.js @@ -142,7 +142,13 @@ Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_GETTER_SETTER_MI } } }, - onchange: function() { + /** + * Called whenever anything on the workspace changes. + * Set the connection type for this block. + * @param {!Blockly.Events.Abstract} _e Change event. + * @this Blockly.Block + */ + onchange: function(_e) { var id = this.getFieldValue('VAR'); var variableModel = this.workspace.getVariableById(id); if (this.type == 'variables_get_dynamic') { diff --git a/core/connection.js b/core/connection.js index 53f0bb2db..320039fd2 100644 --- a/core/connection.js +++ b/core/connection.js @@ -704,11 +704,11 @@ Blockly.Connection.prototype.getShadowDom = function() { * and always return an empty list (the default). * {@link Blockly.RenderedConnection} overrides this behavior with a list * computed from the rendered positioning. - * @param {number} maxLimit The maximum radius to another connection. + * @param {number} _maxLimit The maximum radius to another connection. * @return {!Array.} List of connections. * @private */ -Blockly.Connection.prototype.neighbours_ = function(/* maxLimit */) { +Blockly.Connection.prototype.neighbours_ = function(_maxLimit) { return []; }; diff --git a/core/field.js b/core/field.js index ccfd05518..8d9d54b01 100644 --- a/core/field.js +++ b/core/field.js @@ -869,7 +869,7 @@ Blockly.Field.prototype.getClickTarget_ = function() { /** * Return the absolute coordinates of the top-left corner of this field. * The origin (0,0) is the top-left corner of the page body. - * @return {!Blockly.utils.Coordinate} Object with .x and .y properties. + * @return {!goog.math.Coordinate} Object with .x and .y properties. * @private */ Blockly.Field.prototype.getAbsoluteXY_ = function() { diff --git a/core/utils_coordinate.js b/core/utils_coordinate.js index 3d66561e2..7d08362d3 100644 --- a/core/utils_coordinate.js +++ b/core/utils_coordinate.js @@ -35,8 +35,8 @@ goog.provide('Blockly.utils.Coordinate'); /** * Class for representing coordinates and positions. - * @param {number=} opt_x Left, defaults to 0. - * @param {number=} opt_y Top, defaults to 0. + * @param {number} x Left. + * @param {number} y Top. * @struct * @constructor */ diff --git a/core/utils_rect.js b/core/utils_rect.js index c9cefbeec..bc87b5abc 100644 --- a/core/utils_rect.js +++ b/core/utils_rect.js @@ -41,7 +41,6 @@ goog.provide('Blockly.utils.Rect'); * @param {number} h Height. * @struct * @constructor - * @implements {goog.math.IRect} */ Blockly.utils.Rect = function(x, y, w, h) { /** @type {number} */ @@ -58,8 +57,7 @@ Blockly.utils.Rect = function(x, y, w, h) { }; /** - * Tests whether this rectangle entirely contains another rectangle or - * coordinate. + * Tests whether this rectangle contains a x/y coordinate. * * @param {number} x The x coordinate to test for containment. * @param {number} y The y coordinate to test for containment. diff --git a/core/workspace_comment_render_svg.js b/core/workspace_comment_render_svg.js index 6aff07c45..024140376 100644 --- a/core/workspace_comment_render_svg.js +++ b/core/workspace_comment_render_svg.js @@ -292,10 +292,10 @@ Blockly.WorkspaceCommentSvg.prototype.deleteMouseDown_ = function(e) { /** * Handle a mouse-out on comment's delete icon. - * @param {!Event} e Mouse out event. + * @param {!Event} _e Mouse out event. * @private */ -Blockly.WorkspaceCommentSvg.prototype.deleteMouseOut_ = function(/*e*/) { +Blockly.WorkspaceCommentSvg.prototype.deleteMouseOut_ = function(_e) { // Restore highlight on the delete icon. Blockly.utils.removeClass( /** @type {!Element} */ (this.deleteIconBorder_),