From d4196c1105d3d7719e967edb0cecd0d7f76508c0 Mon Sep 17 00:00:00 2001 From: Christopher Allen Date: Thu, 15 Jul 2021 11:24:15 +0100 Subject: [PATCH] Update goog_module.md with suggested fixes * Fix typos. * Reinstate "Proposed Changes" section. * Mark text that should be edit with ALL CAPS. --- .github/PULL_REQUEST_TEMPLATE/goog_module.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/goog_module.md b/.github/PULL_REQUEST_TEMPLATE/goog_module.md index f47407d32..b2341a52b 100644 --- a/.github/PULL_REQUEST_TEMPLATE/goog_module.md +++ b/.github/PULL_REQUEST_TEMPLATE/goog_module.md @@ -1,20 +1,24 @@ - + ## The basics -- [ ] I branched from `goog.module` -- [ ] My pull request is against `goog.module` +- [ ] I branched from `goog_module` +- [ ] My pull request is against `goog_module` - [ ] My code follows the [style guide]( https://developers.google.com/blockly/guides/modify/web/style-guide) -- [ ] My code is presented in the form suggeseted in the [module +- [ ] My code is presented in the form suggested in the [module conversion guide](https://github.com/google/blockly/issues/5026) -- [ ] I have run `npm test` locally already. +- [ ] I have run `npm test`. ## The details ### Resolves Part of #5026 +### Proposed Changes + +Converts `PATH/TO/FILE.js` to `goog.module` with ES6 `const`/`let`. + ### Additional Information