From d7ab81504c2fac2d446fd84db084a77d1203bd18 Mon Sep 17 00:00:00 2001 From: Christopher Allen Date: Tue, 14 Jun 2022 22:21:04 +0100 Subject: [PATCH] fix(tests): Fix race condition causing flakiness in PHP generator test (#6213) Turns out process.exit() was sometimes getting called before the (async) fs.writeFile had finished writing the last of the generator output files. --- tests/generators/run_generators_in_browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generators/run_generators_in_browser.js b/tests/generators/run_generators_in_browser.js index 97dcf9727..280a59fe5 100644 --- a/tests/generators/run_generators_in_browser.js +++ b/tests/generators/run_generators_in_browser.js @@ -24,7 +24,7 @@ async function runLangGeneratorInBrowser(browser, filename, codegenFn) { await browser.execute(codegenFn); var elem = await browser.$("#importExport"); var result = await elem.getValue(); - fs.writeFile(filename, result, function(err) { + fs.writeFileSync(filename, result, function(err) { if (err) { return console.log(err); }