From da16a66f33f063ce76af4e38857972f3e8f7f92f Mon Sep 17 00:00:00 2001 From: Christopher Allen Date: Thu, 2 Dec 2021 16:47:27 +0000 Subject: [PATCH] refactor: msg.js: use named export, remove declareLegacyNamespace (#5768) --- blocks/lists.js | 2 +- blocks/logic.js | 2 +- blocks/loops.js | 2 +- blocks/procedures.js | 2 +- blocks/text.js | 2 +- core/block_svg.js | 2 +- core/blockly.js | 18 ++++++++++++++++++ core/contextmenu.js | 2 +- core/contextmenu_items.js | 5 +++-- core/field_textinput.js | 2 +- core/field_variable.js | 2 +- core/inject.js | 2 +- core/msg.js | 15 ++++----------- core/names.js | 2 +- core/procedures.js | 2 +- core/utils/parsing.js | 2 +- core/variable_map.js | 4 ++-- core/variables.js | 2 +- core/variables_dynamic.js | 2 +- scripts/gulpfiles/chunks.json | 4 ++-- scripts/migration/renamings.js | 4 ++++ tests/deps.js | 4 ++-- 22 files changed, 50 insertions(+), 34 deletions(-) diff --git a/blocks/lists.js b/blocks/lists.js index 11d4c1afd..72721c211 100644 --- a/blocks/lists.js +++ b/blocks/lists.js @@ -12,7 +12,6 @@ goog.module('Blockly.blocks.lists'); -const Msg = goog.require('Blockly.Msg'); const xmlUtils = goog.require('Blockly.utils.xml'); const {Align} = goog.require('Blockly.Input'); /* eslint-disable-next-line no-unused-vars */ @@ -20,6 +19,7 @@ const {Block} = goog.requireType('Blockly.Block'); const {Blocks} = goog.require('Blockly.blocks'); const {ConnectionType} = goog.require('Blockly.ConnectionType'); const {FieldDropdown} = goog.require('Blockly.FieldDropdown'); +const {Msg} = goog.require('Blockly.Msg'); const {Mutator} = goog.require('Blockly.Mutator'); /* eslint-disable-next-line no-unused-vars */ const {Workspace} = goog.requireType('Blockly.Workspace'); diff --git a/blocks/logic.js b/blocks/logic.js index d48044777..a7afb8140 100644 --- a/blocks/logic.js +++ b/blocks/logic.js @@ -16,11 +16,11 @@ goog.module('Blockly.blocks.logic'); const AbstractEvent = goog.requireType('Blockly.Events.Abstract'); const Events = goog.require('Blockly.Events'); const Extensions = goog.require('Blockly.Extensions'); -const Msg = goog.require('Blockly.Msg'); const common = goog.require('Blockly.common'); const xmlUtils = goog.require('Blockly.utils.xml'); /* eslint-disable-next-line no-unused-vars */ const {Block} = goog.requireType('Blockly.Block'); +const {Msg} = goog.require('Blockly.Msg'); const {Mutator} = goog.require('Blockly.Mutator'); /* eslint-disable-next-line no-unused-vars */ const {RenderedConnection} = goog.requireType('Blockly.RenderedConnection'); diff --git a/blocks/loops.js b/blocks/loops.js index 9a40720fa..cc3c27d37 100644 --- a/blocks/loops.js +++ b/blocks/loops.js @@ -17,12 +17,12 @@ const AbstractEvent = goog.requireType('Blockly.Events.Abstract'); const ContextMenu = goog.require('Blockly.ContextMenu'); const Events = goog.require('Blockly.Events'); const Extensions = goog.require('Blockly.Extensions'); -const Msg = goog.require('Blockly.Msg'); const Variables = goog.require('Blockly.Variables'); const common = goog.require('Blockly.common'); const xmlUtils = goog.require('Blockly.utils.xml'); /* eslint-disable-next-line no-unused-vars */ const {Block} = goog.requireType('Blockly.Block'); +const {Msg} = goog.require('Blockly.Msg'); /** @suppress {extraRequire} */ goog.require('Blockly.FieldDropdown'); /** @suppress {extraRequire} */ diff --git a/blocks/procedures.js b/blocks/procedures.js index 3ed36b830..fc08337a9 100644 --- a/blocks/procedures.js +++ b/blocks/procedures.js @@ -16,7 +16,6 @@ goog.module('Blockly.blocks.procedures'); const AbstractEvent = goog.requireType('Blockly.Events.Abstract'); const ContextMenu = goog.require('Blockly.ContextMenu'); const Events = goog.require('Blockly.Events'); -const Msg = goog.require('Blockly.Msg'); const Procedures = goog.require('Blockly.Procedures'); const Variables = goog.require('Blockly.Variables'); const Xml = goog.require('Blockly.Xml'); @@ -30,6 +29,7 @@ const {Blocks} = goog.require('Blockly.blocks'); const {FieldCheckbox} = goog.require('Blockly.FieldCheckbox'); const {FieldLabel} = goog.require('Blockly.FieldLabel'); const {FieldTextInput} = goog.require('Blockly.FieldTextInput'); +const {Msg} = goog.require('Blockly.Msg'); const {Mutator} = goog.require('Blockly.Mutator'); const {Names} = goog.require('Blockly.Names'); /* eslint-disable-next-line no-unused-vars */ diff --git a/blocks/text.js b/blocks/text.js index 755283fb6..9072c7fa1 100644 --- a/blocks/text.js +++ b/blocks/text.js @@ -13,7 +13,7 @@ goog.module('Blockly.blocks.texts'); const Extensions = goog.require('Blockly.Extensions'); -const Msg = goog.require('Blockly.Msg'); +const {Msg} = goog.require('Blockly.Msg'); /* eslint-disable-next-line no-unused-vars */ const xmlUtils = goog.require('Blockly.utils.xml'); const {Align} = goog.require('Blockly.Input'); diff --git a/core/block_svg.js b/core/block_svg.js index 09c6b8b33..0abd81246 100644 --- a/core/block_svg.js +++ b/core/block_svg.js @@ -16,7 +16,6 @@ goog.module('Blockly.BlockSvg'); const ContextMenu = goog.require('Blockly.ContextMenu'); -const Msg = goog.require('Blockly.Msg'); const Tooltip = goog.require('Blockly.Tooltip'); const blockAnimations = goog.require('Blockly.blockAnimations'); const blocks = goog.require('Blockly.serialization.blocks'); @@ -58,6 +57,7 @@ const {Icon} = goog.requireType('Blockly.Icon'); /* eslint-disable-next-line no-unused-vars */ const {Input} = goog.requireType('Blockly.Input'); const {MarkerManager} = goog.require('Blockly.MarkerManager'); +const {Msg} = goog.require('Blockly.Msg'); /* eslint-disable-next-line no-unused-vars */ const {Mutator} = goog.requireType('Blockly.Mutator'); const {Rect} = goog.require('Blockly.utils.Rect'); diff --git a/core/blockly.js b/core/blockly.js index 9702271ba..e59dd9254 100644 --- a/core/blockly.js +++ b/core/blockly.js @@ -129,6 +129,7 @@ const {MenuItem} = goog.require('Blockly.MenuItem'); const {Menu} = goog.require('Blockly.Menu'); const {MetricsManager} = goog.require('Blockly.MetricsManager'); const {Mutator} = goog.require('Blockly.Mutator'); +const {Msg} = goog.require('Blockly.Msg'); const {Names} = goog.require('Blockly.Names'); const {Options} = goog.require('Blockly.Options'); const {RenderedConnection} = goog.require('Blockly.RenderedConnection'); @@ -654,6 +655,7 @@ exports.Menu = Menu; exports.MenuItem = MenuItem; exports.MetricsManager = MetricsManager; exports.Mutator = Mutator; +exports.Msg = Msg; exports.Names = Names; exports.Options = Options; exports.Procedures = Procedures; @@ -711,6 +713,22 @@ exports.uiPosition = uiPosition; exports.utils = utils; exports.zelos = zelos; +// If Blockly is compiled with ADVANCED_COMPILATION and/or loaded as a +// CJS or ES module there will not be a Blockly global variable +// created. This can cause problems because a very common way of +// loading translations is to use a