CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-04 23:50:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7859 from BeksOmega/fix/previewer-disposing

Browse Source 
fix: connection previewer disposing too early
This commit is contained in:
Maribeth Bottorff
2024-02-15 15:38:14 -08:00
committed by GitHub
parent e59df7ba3d 9e46ed77ae
commit da3ec253bf
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/block_dragger.ts
View File

@@ -382,7 +382,6 @@ export class BlockDragger implements IBlockDragger {
blockAnimation.disconnectUiStop(); blockAnimation.disconnectUiStop();
this.connectionPreviewer.hidePreview(); this.connectionPreviewer.hidePreview();
this.connectionPreviewer.dispose();
const preventMove = const preventMove =
!!this.dragTarget_ && !!this.dragTarget_ &&
@@ -417,6 +416,9 @@ export class BlockDragger implements IBlockDragger {
); );
} }
} }
// Must dispose after `updateBlockAfterMove_` is called to not break the
// dynamic connections plugin.
this.connectionPreviewer.dispose();
this.workspace_.setResizesEnabled(true); this.workspace_.setResizesEnabled(true);
eventUtils.setGroup(false); eventUtils.setGroup(false);