CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-07 09:00:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix a bug where selection outlines could be cut off when connecting blocks. (#8789)

Browse Source
This commit is contained in:
Aaron Dodson
2025-02-27 13:04:37 -08:00
committed by GitHub
parent d016801089
commit dcd2d0e539
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
core/rendered_connection.ts
View File

@@ -533,6 +533,21 @@ export class RenderedConnection extends Connection {
childBlock.updateDisabled(); childBlock.updateDisabled();
childBlock.queueRender(); childBlock.queueRender();
// If either block being connected was selected, visually un- and reselect
// it. This has the effect of moving the selection path to the end of the
// list of child nodes in the DOM. Since SVG z-order is determined by node
// order in the DOM, this works around an issue where the selection outline
// path could be partially obscured by a new block inserted after it in the
// DOM.
const selection = common.getSelected();
const selectedBlock =
(selection === parentBlock && parentBlock) ||
(selection === childBlock && childBlock);
if (selectedBlock) {
selectedBlock.removeSelect();
selectedBlock.addSelect();
}
// The input the child block is connected to (if any). // The input the child block is connected to (if any).
const parentInput = parentBlock.getInputWithBlock(childBlock); const parentInput = parentBlock.getInputWithBlock(childBlock);
if (parentInput) { if (parentInput) {