CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 09:30:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add isDragging to canConnectWithReason and delete newly unused code paths.

Browse Source
This commit is contained in:
Rachel Fenichel
2020-07-14 16:57:29 -06:00
parent e3c8d834cb
commit e24f3cef9b
9 changed files with 63 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/mocha/connection_test.js
View File

@@ -8,7 +8,7 @@ suite('Connection type checker', function() {
suiteSetup(function() {
this.checker = new Blockly.ConnectionTypeChecker();
});
suite('Can Connect With Reason', function() {
suite('Safety checks', function() {
function assertReasonHelper(checker, one, two, reason) {
chai.assert.equal(checker.canConnectWithReason(one, two), reason);
// Order should not matter.
@@ -229,9 +229,9 @@ suite('Connection type checker', function() {
this.con2 = new Blockly.Connection({}, Blockly.NEXT_STATEMENT);
});
function assertCheckTypes(checker, one, two) {
chai.assert.isTrue(checker.passesTypeChecks(one, two));
chai.assert.isTrue(checker.doTypeChecks(one, two));
// Order should not matter.
chai.assert.isTrue(checker.passesTypeChecks(one, two));
chai.assert.isTrue(checker.doTypeChecks(one, two));
}
test('No Types', function() {
assertCheckTypes(this.checker, this.con1, this.con2);
@@ -258,7 +258,7 @@ suite('Connection type checker', function() {
test('No Compatible Types', function() {
this.con1.setCheck('type1');
this.con2.setCheck('type2');
chai.assert.isFalse(this.checker.passesTypeChecks(this.con1, this.con2));
chai.assert.isFalse(this.checker.doTypeChecks(this.con1, this.con2));
});
});
});