From e47d33148ef7a083809023c0c080c611da49718b Mon Sep 17 00:00:00 2001 From: Rachel Fenichel Date: Thu, 16 Jul 2020 14:36:39 -0600 Subject: [PATCH] Review feedback --- core/connection.js | 2 +- core/connection_checker.js | 6 ++++-- core/interfaces/i_connection_checker.js | 4 +++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/core/connection.js b/core/connection.js index dfbc0ac3a..8914c56f9 100644 --- a/core/connection.js +++ b/core/connection.js @@ -16,8 +16,8 @@ goog.require('Blockly.Events'); goog.require('Blockly.Events.BlockMove'); goog.require('Blockly.Xml'); -goog.requireType('Blockly.IConnectionChecker'); goog.requireType('Blockly.IASTNodeLocationWithBlock'); +goog.requireType('Blockly.IConnectionChecker'); /** diff --git a/core/connection_checker.js b/core/connection_checker.js index cb04e1e40..d880fc8a5 100644 --- a/core/connection_checker.js +++ b/core/connection_checker.js @@ -13,8 +13,9 @@ goog.provide('Blockly.ConnectionChecker'); -goog.requireType('Blockly.IConnectionChecker'); goog.requireType('Blockly.Connection'); +goog.requireType('Blockly.IConnectionChecker'); + /** * Class for connection type checking logic. @@ -45,7 +46,8 @@ Blockly.ConnectionChecker.prototype.canConnect = function(one, two, * connection, and return an error code if there are problems. * @param {Blockly.Connection} one Connection to check compatibility with. * @param {Blockly.Connection} two Connection to check compatibility with. - * @param {boolean} isDragging [description] + * @param {boolean} isDragging True if the connection is being made by dragging + * a block. * @return {number} Blockly.Connection.CAN_CONNECT if the connection is legal, * an error code otherwise. * @public diff --git a/core/interfaces/i_connection_checker.js b/core/interfaces/i_connection_checker.js index f2987f5aa..8bb5322bc 100644 --- a/core/interfaces/i_connection_checker.js +++ b/core/interfaces/i_connection_checker.js @@ -15,6 +15,7 @@ goog.provide('Blockly.IConnectionChecker'); goog.requireType('Blockly.Connection'); + /** * Class for connection type checking logic. * @interface @@ -38,7 +39,8 @@ Blockly.IConnectionChecker.prototype.canConnect; * connection, and return an error code if there are problems. * @param {Blockly.Connection} one Connection to check compatibility with. * @param {Blockly.Connection} two Connection to check compatibility with. - * @param {boolean} isDragging [description] + * @param {boolean} isDragging True if the connection is being made by dragging + * a block. * @return {number} Blockly.Connection.CAN_CONNECT if the connection is legal, * an error code otherwise. * @public