From eb5f1cc94aebd5f62be8f0c090a96f3e5a3f8146 Mon Sep 17 00:00:00 2001 From: Sam El-Husseini Date: Wed, 2 Oct 2019 16:12:17 -0700 Subject: [PATCH] Fix 6 warnings in components/ (#3141) --- core/components/component.js | 6 ++---- core/components/menu/menu.js | 4 +++- core/components/tree/treecontrol.js | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/core/components/component.js b/core/components/component.js index 92776a3a9..f64e161aa 100644 --- a/core/components/component.js +++ b/core/components/component.js @@ -39,10 +39,8 @@ goog.require('Blockly.utils.style'); Blockly.Component = function() { /** - * Whether the component is rendered right-to-left. Right-to-left is set - * lazily when {@link #isRightToLeft} is called the first time, unless it has - * been set by calling {@link #setRightToLeft} explicitly. - * @private {?boolean} + * Whether the component is rendered right-to-left. + * @private {boolean} */ this.rightToLeft_ = Blockly.Component.defaultRightToLeft; diff --git a/core/components/menu/menu.js b/core/components/menu/menu.js index 67c51f35a..00fd13e4e 100644 --- a/core/components/menu/menu.js +++ b/core/components/menu/menu.js @@ -270,7 +270,9 @@ Blockly.Menu.prototype.setHighlightedIndex = function(index) { // Bring the highlighted item into view. This has no effect if the menu is not // scrollable. if (child) { - Blockly.utils.style.scrollIntoContainerView(child.getElement(), this.getElement()); + Blockly.utils.style.scrollIntoContainerView( + /** @type {!Element} */ (child.getElement()), + /** @type {!Element} */ (this.getElement())); } }; diff --git a/core/components/tree/treecontrol.js b/core/components/tree/treecontrol.js index de0e461dd..b147c9da7 100644 --- a/core/components/tree/treecontrol.js +++ b/core/components/tree/treecontrol.js @@ -262,6 +262,7 @@ Blockly.tree.TreeControl.prototype.exitDocument = function() { /** * Adds the event listeners to the tree. * @private + * @suppress {deprecated} */ Blockly.tree.TreeControl.prototype.attachEvents_ = function() { var el = this.getElement();