From eea2794e38d668a0a711ac20870591d528d01958 Mon Sep 17 00:00:00 2001 From: Neil Fraser Date: Mon, 11 Jun 2018 00:25:46 -0700 Subject: [PATCH] Remove goog.dom.TagName --- core/field_textinput.js | 4 +--- core/inject.js | 2 +- core/toolbox.js | 4 +--- core/tooltip.js | 4 +--- core/widgetdiv.js | 4 +--- 5 files changed, 5 insertions(+), 13 deletions(-) diff --git a/core/field_textinput.js b/core/field_textinput.js index 093715eb7..6ccb643f8 100644 --- a/core/field_textinput.js +++ b/core/field_textinput.js @@ -29,7 +29,6 @@ goog.provide('Blockly.FieldTextInput'); goog.require('Blockly.Field'); goog.require('Blockly.Msg'); goog.require('goog.dom'); -goog.require('goog.dom.TagName'); goog.require('goog.userAgent'); @@ -191,8 +190,7 @@ Blockly.FieldTextInput.prototype.showInlineEditor_ = function(quietInput) { Blockly.WidgetDiv.show(this, this.sourceBlock_.RTL, this.widgetDispose_()); var div = Blockly.WidgetDiv.DIV; // Create the input. - var htmlInput = - goog.dom.createDom(goog.dom.TagName.INPUT, 'blocklyHtmlInput'); + var htmlInput = goog.dom.createDom('input', 'blocklyHtmlInput'); htmlInput.setAttribute('spellcheck', this.spellcheck_); var fontSize = (Blockly.FieldTextInput.FONTSIZE * this.workspace_.scale) + 'pt'; diff --git a/core/inject.js b/core/inject.js index 19c1e8285..0e8e944a5 100644 --- a/core/inject.js +++ b/core/inject.js @@ -56,7 +56,7 @@ Blockly.inject = function(container, opt_options) { throw Error('Error: container is not in current document.'); } var options = new Blockly.Options(opt_options || {}); - var subContainer = goog.dom.createDom(goog.dom.TagName.DIV, 'injectionDiv'); + var subContainer = goog.dom.createDom('div', 'injectionDiv'); container.appendChild(subContainer); var svg = Blockly.createDom_(subContainer, options); diff --git a/core/toolbox.js b/core/toolbox.js index ee5b4bf1b..000e8b968 100644 --- a/core/toolbox.js +++ b/core/toolbox.js @@ -32,7 +32,6 @@ goog.require('Blockly.HorizontalFlyout'); goog.require('Blockly.Touch'); goog.require('Blockly.VerticalFlyout'); goog.require('goog.dom'); -goog.require('goog.dom.TagName'); goog.require('goog.events'); goog.require('goog.events.BrowserFeature'); goog.require('goog.html.SafeHtml'); @@ -155,8 +154,7 @@ Blockly.Toolbox.prototype.init = function() { * HTML container for the Toolbox menu. * @type {Element} */ - this.HtmlDiv = - goog.dom.createDom(goog.dom.TagName.DIV, 'blocklyToolboxDiv'); + this.HtmlDiv = goog.dom.createDom('div', 'blocklyToolboxDiv'); this.HtmlDiv.setAttribute('dir', workspace.RTL ? 'RTL' : 'LTR'); svg.parentNode.insertBefore(this.HtmlDiv, svg); diff --git a/core/tooltip.js b/core/tooltip.js index 25527eeef..891571256 100644 --- a/core/tooltip.js +++ b/core/tooltip.js @@ -36,7 +36,6 @@ goog.provide('Blockly.Tooltip'); goog.require('goog.dom'); -goog.require('goog.dom.TagName'); /** @@ -132,8 +131,7 @@ Blockly.Tooltip.createDom = function() { return; // Already created. } // Create an HTML container for popup overlays (e.g. editor widgets). - Blockly.Tooltip.DIV = - goog.dom.createDom(goog.dom.TagName.DIV, 'blocklyTooltipDiv'); + Blockly.Tooltip.DIV = goog.dom.createDom('div', 'blocklyTooltipDiv'); document.body.appendChild(Blockly.Tooltip.DIV); }; diff --git a/core/widgetdiv.js b/core/widgetdiv.js index be8a0e14e..61215b852 100644 --- a/core/widgetdiv.js +++ b/core/widgetdiv.js @@ -34,7 +34,6 @@ goog.provide('Blockly.WidgetDiv'); goog.require('Blockly.Css'); goog.require('goog.dom'); -goog.require('goog.dom.TagName'); goog.require('goog.style'); @@ -66,8 +65,7 @@ Blockly.WidgetDiv.createDom = function() { return; // Already created. } // Create an HTML container for popup overlays (e.g. editor widgets). - Blockly.WidgetDiv.DIV = - goog.dom.createDom(goog.dom.TagName.DIV, 'blocklyWidgetDiv'); + Blockly.WidgetDiv.DIV = goog.dom.createDom('div', 'blocklyWidgetDiv'); document.body.appendChild(Blockly.WidgetDiv.DIV); };