From f4961f602edb11db04bbbf39a64983f015209f3e Mon Sep 17 00:00:00 2001 From: Maribeth Bottorff Date: Thu, 15 Feb 2024 15:38:14 -0800 Subject: [PATCH] Merge pull request #7859 from BeksOmega/fix/previewer-disposing fix: connection previewer disposing too early (cherry picked from commit da3ec253bf4af918d5914c87c62b3f4caa0322be) --- core/block_dragger.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/block_dragger.ts b/core/block_dragger.ts index e6be29391..26d265183 100644 --- a/core/block_dragger.ts +++ b/core/block_dragger.ts @@ -382,7 +382,6 @@ export class BlockDragger implements IBlockDragger { blockAnimation.disconnectUiStop(); this.connectionPreviewer.hidePreview(); - this.connectionPreviewer.dispose(); const preventMove = !!this.dragTarget_ && @@ -417,6 +416,9 @@ export class BlockDragger implements IBlockDragger { ); } } + // Must dispose after `updateBlockAfterMove_` is called to not break the + // dynamic connections plugin. + this.connectionPreviewer.dispose(); this.workspace_.setResizesEnabled(true); eventUtils.setGroup(false);