mirror of
https://github.com/google/blockly.git
synced 2026-01-07 00:50:27 +01:00
fix!: refactor warning icon (#7112)
* feat: add basic warning icon * feat: work on actually using the warning icon * chore: add docs * chore: delete old warning icon * chore: fix build * chore: my own comments * chore: move Warning to icons.WarningIcon * chore: move properties to the module level * chore: properly override and call super * chore: properly use optional chaining * chore: fixup comment typo * chore: change imports to import type * chore: reduces changes in block js files * chore: add renaming
This commit is contained in:
@@ -2231,6 +2231,7 @@ export class Block implements IASTNodeLocation, IDeletable {
|
||||
*/
|
||||
removeIcon(type: string): boolean {
|
||||
if (!this.hasIcon(type)) return false;
|
||||
this.getIcon(type)?.dispose();
|
||||
this.icons = this.icons.filter((icon) => icon.getType() !== type);
|
||||
return true;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user