CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 09:30:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix!: refactor warning icon (#7112)

Browse Source 
* feat: add basic warning icon

* feat: work on actually using the warning icon

* chore: add docs

* chore: delete old warning icon

* chore: fix build

* chore: my own comments

* chore: move Warning to icons.WarningIcon

* chore: move properties to the module level

* chore: properly override and call super

* chore: properly use optional chaining

* chore: fixup comment typo

* chore: change imports to import type

* chore: reduces changes in block js files

* chore: add renaming
This commit is contained in:
Beka Westberg
2023-06-02 09:34:34 -07:00
committed by GitHub
parent 3ae4a61842
commit f4e378d096
9 changed files with 248 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/bubbles/bubble.ts
View File

@@ -184,7 +184,7 @@ export abstract class Bubble implements IBubble {
}
/** Sets the colour of the background and tail of this bubble. */
protected setColour(colour: string) {
public setColour(colour: string) {
this.colour = colour;
this.tail.setAttribute('fill', colour);
this.background.setAttribute('fill', colour);