From fee606e2e010aa228046efef2298d51aaf617027 Mon Sep 17 00:00:00 2001 From: Sam El-Husseini Date: Mon, 9 Dec 2019 13:04:28 -0800 Subject: [PATCH] Render negative elem spacing in debugger. (#3493) * Render negative elem spacing in debugger. --- core/renderers/common/debugger.js | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/core/renderers/common/debugger.js b/core/renderers/common/debugger.js index 207648e24..294ffc0d0 100644 --- a/core/renderers/common/debugger.js +++ b/core/renderers/common/debugger.js @@ -121,14 +121,11 @@ Blockly.blockRendering.Debug.prototype.drawSpacerElem = function(elem, rowHeight return; } - // Don't render elements with negative spacing. - if (elem.width < 0) { - return; - } - - var xPos = elem.xPos; + var width = Math.abs(elem.width); + var isNegativeSpacing = elem.width < 0; + var xPos = isNegativeSpacing ? elem.xPos - width : elem.xPos; if (isRtl) { - xPos = -(xPos + elem.width); + xPos = -(xPos + width); } var yPos = elem.centerline - elem.height / 2; this.debugElements_.push(Blockly.utils.dom.createSvgElement('rect', @@ -136,10 +133,10 @@ Blockly.blockRendering.Debug.prototype.drawSpacerElem = function(elem, rowHeight 'class': 'elemSpacerRect blockRenderDebug', 'x': xPos, 'y': yPos, - 'width': elem.width, + 'width': width, 'height': elem.height, 'stroke': 'pink', - 'fill': 'pink', + 'fill': isNegativeSpacing ? 'black' : 'pink', 'fill-opacity': '0.5', 'stroke-width': '1px' },