Commit Graph

9277 Commits

Author SHA1 Message Date
RoboErikG
e74910c8a0 Update block-test version 2025-08-12 10:32:32 -07:00
Aaron Dodson
fb63360b9f refactor: Remove duplicated method from contextmenu_items.ts. (#9289) 2025-08-12 08:55:54 -07:00
RoboErikG
b211c02e3c Change browser test timeout to 2 hours 2025-08-11 10:10:10 -07:00
dependabot[bot]
79d3140495 chore(deps): bump actions/download-artifact from 4 to 5 (#9287)
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-11 17:39:48 +01:00
dependabot[bot]
2e252a4bd8 chore(deps): bump google-github-actions/deploy-appengine (#9273)
Bumps [google-github-actions/deploy-appengine](https://github.com/google-github-actions/deploy-appengine) from 2.1.5 to 2.1.7.
- [Release notes](https://github.com/google-github-actions/deploy-appengine/releases)
- [Changelog](https://github.com/google-github-actions/deploy-appengine/blob/main/CHANGELOG.md)
- [Commits](https://github.com/google-github-actions/deploy-appengine/compare/v2.1.5...v2.1.7)

---
updated-dependencies:
- dependency-name: google-github-actions/deploy-appengine
  dependency-version: 2.1.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-11 09:38:45 -07:00
Aaron Dodson
7d1d745416 fix: Drag immovable and shadow blocks along with their parent. (#9281) 2025-08-06 14:08:01 -07:00
Aaron Dodson
f9d0ec9d24 refactor: Associate comment bar buttons with the comment view. (#9278) 2025-08-06 14:04:12 -07:00
Maribeth Moffatt
62f3b8914a chore: add tests for clipboard (#9254)
* chore: add tests for clipboard

* chore: clean up
2025-08-06 14:01:59 -07:00
Aaron Dodson
af57a3eaa3 refactor: Make InsertionMarkerPreviewer's block serialization amenable to subclassing. (#9282) 2025-08-06 12:45:17 -07:00
Aaron Dodson
44e78b1456 feat: Add an option to copy subsequent blocks when getting copy data from a block. (#9279) 2025-08-05 11:17:10 -07:00
Aaron Dodson
88151fcadd fix: Display focused icons without transparency. (#9268) 2025-08-04 13:18:31 -07:00
Maribeth Moffatt
f24940e781 fix: dont add comments to full block fields (#9263)
* fix: dont add comments to full block fields

* chore: remove some nonnull assertions
2025-08-04 13:14:44 -07:00
dependabot[bot]
683a4357ff chore(deps): bump gulp-rename from 2.0.0 to 2.1.0 (#9277)
Bumps [gulp-rename](https://github.com/hparra/gulp-rename) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/hparra/gulp-rename/releases)
- [Changelog](https://github.com/hparra/gulp-rename/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hparra/gulp-rename/compare/v2.0.0...v2.1.0)

---
updated-dependencies:
- dependency-name: gulp-rename
  dependency-version: 2.1.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-04 11:13:43 -07:00
dependabot[bot]
d5e347db44 chore(deps): bump actions/first-interaction from 1 to 2 (#9274)
Bumps [actions/first-interaction](https://github.com/actions/first-interaction) from 1 to 2.
- [Release notes](https://github.com/actions/first-interaction/releases)
- [Commits](https://github.com/actions/first-interaction/compare/v1...v2)

---
updated-dependencies:
- dependency-name: actions/first-interaction
  dependency-version: '2'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-04 10:02:34 -07:00
RoboErikG
9fc0c386b4 Merge pull request #9275 from google/dependabot/npm_and_yarn/develop/concurrently-9.2.0
chore(deps): bump concurrently from 9.1.2 to 9.2.0
2025-08-04 09:00:51 -07:00
RoboErikG
65289dde09 Merge pull request #9270 from google/dependabot/npm_and_yarn/develop/eslint-plugin-jsdoc-52.0.2
chore(deps): bump eslint-plugin-jsdoc from 51.3.1 to 52.0.2
2025-08-04 08:59:56 -07:00
dependabot[bot]
5e48e0db8c chore(deps): bump concurrently from 9.1.2 to 9.2.0
Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 9.1.2 to 9.2.0.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](https://github.com/open-cli-tools/concurrently/compare/v9.1.2...v9.2.0)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-version: 9.2.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-04 13:58:13 +00:00
dependabot[bot]
71256d69a0 chore(deps): bump eslint-plugin-jsdoc from 51.3.1 to 52.0.2
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 51.3.1 to 52.0.2.
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v51.3.1...v52.0.2)

---
updated-dependencies:
- dependency-name: eslint-plugin-jsdoc
  dependency-version: 52.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-04 12:22:09 +00:00
michaela-mm
d9421892fb fix: Check for existing event group in cleanUp() (#9265) 2025-08-01 11:30:23 -07:00
Aaron Dodson
c037e7d47d fix: Scroll CommentBarButtons into view on selection. (#9259) 2025-07-30 09:48:00 -07:00
Aaron Dodson
8a578f5ce3 fix: Allow overriding VariableModel via options.plugins. (#9257) 2025-07-30 08:58:30 -07:00
Maribeth Moffatt
c661dd1c94 fix: dont save ids when copying blocks and comments (#9255) 2025-07-28 14:35:55 -07:00
Aaron Dodson
c9a8221a2d fix: Fix displaying HTML elements in FieldDropdown. (#9258) 2025-07-28 13:33:52 -07:00
RoboErikG
b44f7bf1b0 Merge pull request #9207 from google/dependabot/npm_and_yarn/develop/blockly/theme-modern-7.0.1
chore(deps): bump @blockly/theme-modern from 6.0.10 to 7.0.1
2025-07-25 10:09:07 -07:00
dependabot[bot]
0de5b17c8a chore(deps): bump @blockly/theme-modern from 6.0.10 to 7.0.1
Bumps [@blockly/theme-modern](https://github.com/google/blockly-samples/tree/HEAD/plugins/theme-modern) from 6.0.10 to 7.0.1.
- [Release notes](https://github.com/google/blockly-samples/releases)
- [Changelog](https://github.com/google/blockly-samples/blob/master/plugins/theme-modern/CHANGELOG.md)
- [Commits](https://github.com/google/blockly-samples/commits/@blockly/theme-modern@7.0.1/plugins/theme-modern)

---
updated-dependencies:
- dependency-name: "@blockly/theme-modern"
  dependency-version: 7.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-24 16:29:34 +00:00
Maribeth Moffatt
f37e7fede2 chore: fix docs generation script (#9251)
* chore: pin api-documenter to a version that uses markdown tables

* chore: fix docs generation errors

* chore: update patch for api-documenter
2025-07-24 09:28:18 -07:00
Aaron Dodson
3c7add57ee fix: Make non-autoclosing flyouts stay open. (#9245)
* chore: Add tests for toolbox/flyout/focus autoclose behavior.

* fix: Don't force-close non-autoclosing flyouts.
2025-07-18 14:27:49 -07:00
Aaron Dodson
908712e19d fix: Refer to correct replacement method in deprecation warning. (#9237) 2025-07-15 11:06:27 -07:00
RoboErikG
7e47bf440c Merge pull request #9238 from RoboErikG/toolbox-categories-tests
fix: Fix toolbox categories tests
2025-07-14 11:31:45 -07:00
dependabot[bot]
c1c7ddb293 chore(deps): bump chai from 5.2.0 to 5.2.1 (#9235)
Bumps [chai](https://github.com/chaijs/chai) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](https://github.com/chaijs/chai/compare/v5.2.0...v5.2.1)

---
updated-dependencies:
- dependency-name: chai
  dependency-version: 5.2.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-14 11:17:27 -07:00
Aaron Dodson
7479c2b5c7 fix: Fix order of arguments in IVariableMap.createVariable(). (#9231) 2025-07-14 10:22:09 -07:00
dependabot[bot]
ec01df4ada chore(deps): bump @microsoft/api-documenter from 7.26.26 to 7.26.29 (#9234)
Bumps [@microsoft/api-documenter](https://github.com/microsoft/rushstack/tree/HEAD/apps/api-documenter) from 7.26.26 to 7.26.29.
- [Changelog](https://github.com/microsoft/rushstack/blob/main/apps/api-documenter/CHANGELOG.md)
- [Commits](https://github.com/microsoft/rushstack/commits/@microsoft/api-documenter_v7.26.29/apps/api-documenter)

---
updated-dependencies:
- dependency-name: "@microsoft/api-documenter"
  dependency-version: 7.26.29
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-14 18:11:03 +01:00
Erik Pasternak
55bd1aff79 Enable categories test 2025-07-14 10:09:51 -07:00
Aaron Dodson
9f66f0c596 fix: Fire a VarTypeChange event when changing a variable's type. (#9236) 2025-07-14 09:53:17 -07:00
Aaron Dodson
52634e4dec fix: Focus the first element in flyouts. (#9228)
* fix: Focus the first element in flyouts.

* refactor: Adjust retrieval of flyout elements.
2025-07-14 08:55:13 -07:00
dependabot[bot]
802d3f887d chore(deps): bump google-closure-compiler (#9233)
Bumps [google-closure-compiler](https://github.com/google/closure-compiler-npm) from 20250625.0.0 to 20250709.0.0.
- [Release notes](https://github.com/google/closure-compiler-npm/releases)
- [Commits](https://github.com/google/closure-compiler-npm/compare/v20250625.0.0...v20250709.0.0)

---
updated-dependencies:
- dependency-name: google-closure-compiler
  dependency-version: 20250709.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-07-14 08:35:50 -07:00
Erik Pasternak
2c6c2e1a9d fix: Fix toolbox categories tests (Almost)
This fixes the the toolbox categories tests except for dragging out the four
empty statement blocks, which is fixed by https://github.com/google/blockly-samples/pull/2580

Once the latest version of samples is published the toolbox suite can be
re-enabled.
2025-07-11 13:50:22 -07:00
Aaron Dodson
d5f3d15726 feat: Add support for keyboard navigation to/from block comments. (#9227)
* refactor: Update `TextInputBubble` to use `CommentEditor` for text editing.

* feat: Designate `Bubble` as implementing `IFocusableNode`.

* feat: Dismiss focused bubbles on Escape.

* feat: Add support for keyboard navigation to block comments.

* fix: Scroll comment editors rather than zooming the workspace.

* chore: Add param to docstring.
2025-07-11 10:54:19 -07:00
Maribeth Moffatt
60b7ee1325 release: merge master into develop after v12.2.0
release: merge master into develop after v12.2.0
Merge pull request #9225 from google/master
2025-07-09 17:04:12 -07:00
Maribeth Moffatt
c92314d410 release: v12.2.0
release: v12.2.0
Merge pull request #9224 from google/rc/v12.2.0
blockly-v12.2.0
2025-07-09 13:46:31 -07:00
Maribeth Moffatt
fae8b7fd9e release: merge develop into rv/v12.2.0 2025-07-09 13:40:03 -07:00
Ben Henning
5747feef45 fix: Revert drop down and widget div PRs (#9222)
* Revert "fix: Auto-close widget divs on lost focus (#9216)"

This reverts commit bea183d85d.

* Revert "fix: Auto close drop-down divs on lost focus (reapply) (#9213)"

This reverts commit 0e16b0405a.
2025-07-09 12:13:33 -07:00
Ben Henning
bea183d85d fix: Auto-close widget divs on lost focus (#9216)
## The basics

- [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/core#making_and_verifying_a_change)

## The details
### Resolves

Fixes https://github.com/google/blockly-keyboard-experimentation/issues/563

### Proposed Changes

This expands the functionality introduced in #9213 to also include widget divs.

### Reason for Changes

MakeCode makes use of widget div in several field editors, so the issues described in https://github.com/google/blockly-keyboard-experimentation/issues/563 aren't fully mitigated with #9213 alone.

This PR essentially adds the same support for auto-closing as drop-down divs now have, and enables this functionality by default.

Note the drop-down div change: it was missed in #9123 that the API change for drop-down div's `show` function is actually API-breaking, so this updates that API to be properly backward compatible (and reverts one test change that makes use of it).

The `FocusManager` change actually corrects an implementation issue from #9123: not updating the tracked focus status before calling the callback can result in focus being inadvertently restored if the callback triggers returning focus due to a lost focus situation. This was wrong for drop-down divs, too, but it's harder to notice there because the dismissal of the drop-down div happens on a timer (which means there's sufficient time for `FocusManager`'s state to correct prior to attempting to return from the ephemeral focus state).

Demonstration of fixed behavior (since the inline number editor uses a widget div):

[Screen recording 2025-07-08 2.12.31 PM.webm](https://github.com/user-attachments/assets/7c3c7c3c-224c-48f4-b4af-bde86feecfa8)

### Test Coverage

New widget div tests have been added to verify the new parameter and auto-close functionality.

The `FocusManager` test was updated to account for the new, and correct, behavior around the internal tracked ephemeral focus state.

Note that some `tabindex` state has been clarified and cleaned up in the test index page and `FocusManager`. It's fine (and preferable) for ephemeral-used elements to always be focusable rather than making them dynamically so (which avoids state bleed across test runs which was happening one of the new tests).

https://github.com/google/blockly-keyboard-experimentation/pull/649 includes additional tests for validating widget behaviors.

### Documentation

No new documentation should be needed here--the API documentation changes should be sufficient.

One documentation update was made in `dropdowndiv.ts` that corrects the documentation parameter ordering.

### Additional Information

Nothing further to add.
2025-07-08 16:06:24 -07:00
Maribeth Moffatt
c0489b41e0 feat: add copy api and paste into correct workspace (#9215)
* feat: add copy api and paste into correct workspace

* fix: dont paste into unrendered workspaces

* fix: paste precondition and add test
2025-07-08 16:05:53 -07:00
RoboErikG
89af298918 Merge pull request #9183 from RoboErikG/fix-browser-tests-2025-06
fix: Fix more browser tests
2025-07-08 15:20:41 -07:00
Erik Pasternak
2fba036a8d Add a todo for enabling the toolbox categories tests 2025-07-08 15:17:33 -07:00
Erik Pasternak
1e40641f45 Fix formatting 2025-07-08 14:35:28 -07:00
Erik Pasternak
274891d34e Responses to comments
- Switch to using scrollBoundsIntoView instead of scrolling the flyout
- Use webdriverio Key.Escape instead of the string code for it
2025-07-08 14:27:50 -07:00
Aaron Dodson
fc9164de8f fix: Prevent loss of focus when deleting a workspace comment. (#9200)
* fix: Prevent loss of focus when deleting a workspace comment.

* chore: Add test verifying workspace comment focus behavior on deletion.
2025-07-08 13:50:26 -07:00
dependabot[bot]
8580d763b3 chore(deps): bump google-closure-compiler from 20240317.0.0 to 20250625.0.0 (#9187)
* chore(deps): bump google-closure-compiler

  Bumps [google-closure-compiler](https://github.com/google/closure-compiler-npm) from 20240317.0.0 to 20250625.0.0.
  - [Release notes](https://github.com/google/closure-compiler-npm/releases)
  - [Commits](https://github.com/google/closure-compiler-npm/compare/v20240317.0.0...v20250625.0.0)

  ---
  updated-dependencies:
  - dependency-name: google-closure-compiler
    dependency-version: 20250625.0.0
    dependency-type: direct:development
    update-type: version-update:semver-major
  ...

  Signed-off-by: dependabot[bot] <support@github.com>

* chore(build): Update import of google-closure-compiler

  The packaging of this module changed and so how we import it needs
  to change as well.

* fix(build): Remove no-longer-supported compiler option

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christopher Allen <cpcallen+git@google.com>
2025-07-08 14:28:57 +01:00