Commit Graph

113 Commits

Author SHA1 Message Date
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Sam El-Husseini f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Rachel Fenichel 0b09d179ae Merge pull request #4642 from rachel-fenichel/event_data_type
Move bind/unbind events functions to new file, with example usage.
2021-02-25 12:00:22 -08:00
Rachel Fenichel 1d8c234d33 Update uses of bindEvent_, bindEventWithChecks_, and unbindEvent_. Add missing requires for Blockly.browserEvents. 2021-02-23 11:23:28 -08:00
Monica Kozbial cd8860058e Upgrade closure compiler (#4631)
* Add missing casts

* Update google-closure-compiler version
2021-02-23 11:06:33 -08:00
Rachel Fenichel 54c4e8de39 Rename Blockly.eventHandling->Blockly.browserEvents and replace all Blockly.EventData annotations 2021-02-22 13:23:19 -08:00
alschmiedt a3adc42e8a Remove keyboard navigation from core (#4593) 2021-01-19 11:50:51 -08:00
alschmiedt f1498e7f07 Keyboard shortcuts (#4421)
* Adds shortcut registry and removes action and key map (#4398)

* Adds Shortcut tests and refactored navigation tests (#4412)

* Adds shortcut items (#4408)

* Add shortcuts for navigation (#4409)

* Add final keyboard shortcut cleanup (#4413)
2020-11-02 13:30:05 -08:00
Monica Kozbial 4ac4332f5e Update logic for field default values. (#3953)
* Update logic for field default values.

* Fix bugs

* Use contant for default value.

* Fix FieldColour

* Update field number tests.

* Update field angle test.

* Minor update.

* Update field checkbox test.

* Undo enabling logging

* Remove only.

* Update field colour test.

* Update invalid test cases for field colour

* Update field label tests

* Update field textinput test.

* Minor cleanup

* Make lint happy.
2020-06-12 15:18:28 -07:00
Sam El-Husseini 1052f7548b Enable unusedPrivateMembers check (#3924)
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
Sam El-Husseini 06f6c22a27 Fix field colour in headless (#3795) 2020-04-03 14:36:19 -07:00
Sam El-Husseini 13ac939b91 Support passing renderer overrides in options (#3734)
* Support passing in renderer options through workspace options.
2020-03-10 18:36:29 -07:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini 917f58ab0f Fix bugs with apply colour (#3483) 2019-12-03 13:22:41 -08:00
Sam El-Husseini 2a8e7d9ac8 [zelos] Full field colour (#3461)
* Support showing the colour value on the entire block.
2019-11-22 13:50:33 -08:00
Sam El-Husseini 2dea7038d5 Moves field layout constants into the renderer (#3437)
* Add field constants into renderer constants
2019-11-13 16:41:35 -08:00
Beka Westberg dad8738e75 Cleaned up unbindEvent_ calls (#3429)
* Cleaned up unbindEvent_ calls.
2019-11-12 10:14:31 -08:00
alschmiedt 40bdfac017 Fix setting focus for workspace (#3425)
* Fix setting focus for workspace
2019-11-11 16:44:58 -08:00
Neil Fraser 013f2714a3 Cleanup aria usage. (#3261)
Use enums instead of arbitrary strings.
Delete unused Aria properties
Add missing requires.
Delete unused code.
2019-10-15 22:43:23 -07:00
Sam El-Husseini 2224bb2a4e More field dispose (#3201)
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Beka Westberg f4f9a67903 Fixed field editor disposal (#3109)
* Fixed field editor disposal.
2019-10-08 16:48:31 -07:00
Sam El-Husseini 1d113b5069 Add support for setting the direction in RTL. (#3192) 2019-10-07 17:28:18 -07:00
Sam El-Husseini d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Sam El-Husseini fba98fca5b Move the dropdown field into the dropdown div. (#3122)
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini a57c7ffb13 Clean up fields by passing the right type in fromJson (#3095) 2019-09-26 12:03:17 -07:00
Neil Fraser 75cf614104 Break CSS into modules. (#3084)
* Break CSS into modules.

Drops the compile test by 3 KB.
Remove obsolete .blocklyDraggable class stub (it used to be dynamically changed).
Remove unused menuseparator CSS.
2019-09-25 18:01:19 -07:00
Neil Fraser b84cda2c76 Strip out more bloat from toolbox (#3068)
Also removes three private accesses from workspaceSvg into toolbox tree.

The strategy for workspace.updateToolbox is no longer to clear and repopulate the toolbox, but rather to throw away the old toolbox and rebuild a new one.  This is simpler and more reliable.

This commit trims off another KB from the compiled code.
2019-09-23 15:18:32 -07:00
alschmiedt c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00
Neil Fraser 28953d8ea0 Simplify Blockly.utils.IdGenerator
Also drop unused menu highlight hook.
2019-09-20 10:36:06 -07:00
Sam El-Husseini cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
Sam El-Husseini 8fae0411f7 Check if a type exists before testing instanceof (#3031)
* Check if a type exists before instance of
2019-09-17 16:28:18 -07:00
Sam El-Husseini f3f3329355 Fix configure method (#2915)
* Fix configure method.
2019-09-12 17:01:03 -07:00
Sam El-Husseini 8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini 03b1e7f8d4 Fixes toolbox and menu dropdown on mobile. (#2931)
* Fixes toolbox and menu dropdown for mobile.
2019-08-30 10:23:42 -07:00
Beka Westberg 23e0733f21 Changed field and colour constructors to use better organization. (#2900) 2019-08-23 10:54:44 -07:00
Beka Westberg 0d482c6488 Changed colour field to new configuration paradigm. 2019-08-20 09:44:14 -07:00
Sam El-Husseini 8a04d5d71b Field colour + Blockly actions (#2855)
* Update field colour to support blockly actions
2019-08-19 16:09:38 -07:00
Neil Fraser 096959fde9 Cleanup of last fortnight’s commits. (#2865)
No functional changes.
2019-08-19 14:07:48 -07:00
Sam El-Husseini ca83f97074 Colour field accessibility (#2836)
* Implement key board navigation and aria accessibility for the colour field.
2019-08-16 13:49:05 -07:00
Beka Westberg 0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Rachel Fenichel 40ba284c3f Change constant 2019-08-06 13:40:06 -07:00
Rachel Fenichel c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00
Rachel Fenichel 3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
Neil Fraser 45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Neil Fraser 6aedfab4d1 Misc JSDoc fixes. (#2747) 2019-07-30 16:28:48 -07:00
Sam El-Husseini 57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Rachel Fenichel b5c75ff24d Merge pull request #2651 from rachel-fenichel/field_corrected_sizes
Add getCorrectedSize functions to fields
2019-07-22 16:45:13 -07:00
Rachel Fenichel fc4372dbc2 Add TODOs with github issue number 2019-07-22 16:29:44 -07:00