Commit Graph

65 Commits

Author SHA1 Message Date
alschmiedt d58c80db76 Refactor flyout and toolbox metrics (#4648) 2021-03-15 12:37:23 -07:00
alschmiedt 869e4eb366 Update flyout metrics to work with the new metrics manager (#4684) 2021-03-09 17:09:49 -08:00
Rachel Fenichel f7e0d5f4ea Use existing toolbox position enum 2021-03-05 14:16:43 -08:00
Rachel Fenichel 59084a043c TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc 2021-03-05 13:48:45 -08:00
alschmiedt 26104d280d Update metrics to support mutators (#4679) 2021-03-05 11:44:29 -08:00
Monica Kozbial 0246e2a132 Fix flyout metrics and workspace scroll (#4674)
* Fix flyout metrics and max scroll logic in scroll

* Fix horizontal scroll wheel logic
2021-03-05 11:34:29 -08:00
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Monica Kozbial 57749e6eb8 Updating bump logic to support single-direction scrollbars (#4652)
* Updating bump logic to support single-direction scrollbars
2021-03-01 12:20:12 -08:00
Maribeth Bottorff 4fd6d1b229 Add overrideable function to get flyout scale (#4647) 2021-02-26 12:06:27 -08:00
Monica Kozbial d42afc7e69 Add missing madding to flyout (#4657) 2021-02-25 12:00:46 -08:00
Monica Kozbial dd7e365882 Scrolling readability refactor (#4643)
* Refactors scrolling logic in scrollbars and adds comments to be more readable
* Updates JSDoc description for ScrollbarPair.set and Scrollbar.set
2021-02-24 15:09:43 -08:00
Rachel Fenichel 26d2b51681 Fix missing require types 2021-02-17 11:17:48 -08:00
Monica Kozbial 17d7d1b449 Use ScrollbarPair and WorkspaceDragger in flyouts (#4607)
* Use ScrollbarPair for flyouts

* Address PR comments

* Fix compile error
2021-02-02 11:46:06 -08:00
Maribeth Bottorff b5c77137bd factor out getX and getY methods for flyouts (#4463) 2020-11-19 10:12:06 -08:00
alschmiedt 8eb794f30e Uses the ws scroll value when updating flyout (#4415) 2020-10-30 13:30:53 -07:00
Sam El-Husseini fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
Beka Westberg 111b47980d Fix toolbox sizes not being updated properly (#4139)
* Fix toolbox changing size

* Fix flyout changing size

* Fix mutator bumping blocks

* Fix accessing .flyout_
2020-08-13 08:19:40 -07:00
alschmiedt 0f00f42580 Adds Ability to Add a Flyout as a Plugin (#4059) 2020-07-22 17:13:19 -07:00
Sam El-Husseini 1052f7548b Enable unusedPrivateMembers check (#3924)
* Add unusedPrivateMembers check
2020-05-28 17:44:16 -07:00
Sam El-Husseini e3babee1f3 Add Blockly.utils.Metrics @record (#3913)
* Add Blockly.utils.Metrics
2020-05-21 15:03:17 -07:00
Sam El-Husseini 1e251e812b Hide the dropdown div when the flyout toolbox is scrolled (#3884) 2020-05-06 09:41:58 -07:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Neil Fraser 123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Sam El-Husseini cd412b678e Remove firefox workaround that is no longer needed (#3349) 2019-10-30 11:44:05 -07:00
Sam El-Husseini 4f02ceeba0 Make Blockly options an interface (#3312)
* Make workspace options an interface so it can be extended in the d.ts.
2019-10-22 14:20:26 -04:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Neil Fraser 6e76b6f49e Make flyout buttons be an optional module. 2019-09-24 10:58:33 -07:00
kozbial a12a47e0f8 Fixing require ordering and bug in horizontal layout computation. 2019-09-12 11:05:30 -07:00
kozbial b26f50ab8d Fixing x positioning of blocks with output connections in vertical flyout. 2019-09-12 11:05:30 -07:00
Sam El-Husseini 8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Neil Fraser 45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Neil Fraser 6947010c49 Change Rect to use top/bottom/left/right
Instead of top/left/height/width.  Given our uses of Rect, it makes the math slightly simpler.

This is a setup for using Rect in other places.  Currently it is only used to describe delete areas.
2019-06-07 10:32:57 -07:00
Neil Fraser 3dfac9a2ba Alphabetize require statements.
Search and replace for userAgent didn’t take into account alphabetic ordering.
Also some line wraping.
2019-06-07 10:32:57 -07:00
Neil Fraser 566f182fa8 Move Blockly.userAgent to Blockly.utils.userAgent 2019-06-07 10:32:57 -07:00
Neil Fraser 5bf7069a2f Remove goog.math.Coordinate 2019-06-07 10:32:57 -07:00
Neil Fraser f2c57dea1b Remove goog.math.Rect dependency 2019-06-07 10:32:57 -07:00
Neil Fraser 9f528922a7 Fix some dependencies 2019-05-24 15:45:05 -07:00
Neil Fraser 28ad3a9bd3 Blockly.utils.userAgent moved to Blockly.userAgent 2019-05-10 16:56:26 -07:00
Neil Fraser 4062030731 Remove goog.userAgent dependency. 2019-05-10 14:03:21 -07:00
Beka Westberg b93253c69c Fixed Mutator Flyout Being Positioned Incorrectly RTL (#2378)
* Fixed mutator flyout being positioned incorrectly.

* Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.
2019-04-15 10:02:07 -07:00
Neil Fraser e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Beka Westberg 5b25843b98 Fixed trashcan flyout positioning. 2019-03-29 08:19:24 -07:00
Beka Westberg a0aa84d861 Changed absolute metrics to avoid simple toolboxes. 2019-02-23 14:34:26 -08:00
Beka Westberg 4e7e712549 Added scroll delta mode constants. 2019-02-21 07:35:44 -08:00
Beka Westberg 363ff487a4 Changed trashcan and zoom controls to be positioned in the opposite corner of the toolbox. Fixed trashcan hotspot being incorrect. 2019-01-28 15:24:56 -08:00
Neil Fraser aa09ad9175 Line wrap at 80. 2018-10-16 11:34:10 -07:00
Neil Fraser 0583bee502 Correct requires for goog.dom 2018-07-11 12:20:02 -07:00
Neil Fraser 8f7674ea08 Correct requires for goog.events 2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 3909bd420a Remove all goog.asserts and goog.isXxx
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00