Commit Graph

64 Commits

Author SHA1 Message Date
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Rachel Fenichel 750b62030b First pass at creating connectionTypes and inputTYpes 2021-03-04 10:22:24 -08:00
Rachel Fenichel 4e31deca2b Align constants -> Blockly.constants.ALIGN enum 2021-02-26 11:12:53 -08:00
Sam El-Husseini f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Rachel Fenichel 6791e1aff2 Fix missing requires and requireTypes in zelos 2021-02-02 11:38:08 -08:00
Sam El-Husseini fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
Monica Kozbial a9223b0b22 Typo fixes. (#3769) 2020-03-25 15:47:27 -07:00
Sam El-Husseini 9b071ff7f7 [Zelos] Value to stack block support (#3741)
* Zelos value to stack block support
2020-03-12 11:47:47 -07:00
Sam El-Husseini 0db1f418ab Fix block connected bounds for Zelos and minimalist renderers. (#3740)
* Fix block connected bounds for zelos and minimalist renderers.
2020-03-12 11:04:29 -07:00
Sam El-Husseini 56ca1e4330 [zelos] Fix centered textinputs (#3703)
* Fix bug in centering text inputs. Shouldn't add right corner element for output only blocks.
2020-02-21 12:03:28 -08:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini 33e082414d Adjust what the spacers at after the top and before the bottom rows depend on. Make them depend on the top row's minHeight and desired height. (#3686) 2020-02-10 08:58:07 -08:00
Sam El-Husseini 95aadbffb1 [zelos] Set a maximum width for dynamic connection shapes. (#3685)
* Set a maximum width for dynamic connection shapes.

* Only render the left side connection if a block has a statement input
2020-02-07 15:13:51 -08:00
Sam El-Husseini 899162c420 Fix zelos top row spacer height when it precedes a statement input. (#3587) 2020-01-13 18:39:24 -08:00
Sam El-Husseini 4f80bd6cbf Simplify zelos tight nesting logic (#3583) 2020-01-13 15:47:54 -08:00
Sam El-Husseini 8013f80251 Start hat support in zelos. (#3580)
* Start hat support in zelos.
2020-01-13 13:22:49 -08:00
Sam El-Husseini 1661d640d6 Geras inline alignment of rows + max bottom row width (#3575)
* Add a desired width getter method for input rows. Override in geras to fix the width of the bottom row and statement input to a max width.
2020-01-13 10:40:52 -08:00
Sam El-Husseini 8b50df01c0 Fix zelos statement input alignment for spacers (#3578) 2020-01-13 10:32:49 -08:00
Sam El-Husseini e162f3b45f [zelos] Don't add next notch in a statement input if the connection block doesn't have a next connection (#3562)
* Don't add a next notch for statement inputs that have a connected block without a next connection.
2020-01-09 08:37:20 -08:00
Sam El-Husseini e530f209cd Fix bug in zelos tight nesting code. (#3565) 2020-01-08 08:47:10 -08:00
Sam El-Husseini 267877115f Adjust single field row alignment so that it takes up less vertical space (#3557) 2020-01-07 13:52:57 -08:00
Sam El-Husseini ec0ba27afc Reduce an empty row surrounded by statement inputs to match size of bottom row (#3544) 2020-01-06 12:39:07 -08:00
Sam El-Husseini 6794f282d4 [zelos] Fix breakout loop block (#3545)
* Fix breakout loop block by only applying the small padding if the block doesn't have a statement input
2020-01-06 12:38:54 -08:00
Sam El-Husseini b6596ceddb Deal with the case where we have two dummy inputs on the same row, one with left alignment and the other right. (#3540) 2020-01-03 15:31:28 -08:00
Sam El-Husseini 8c80c3e509 [zelos] Bump / tight nest for all rows that are preceded and followed by a notch (#3541)
* Bump inputs past notch for every row that has a prev and next notch. Use the same logic for tight nesting.
2020-01-03 15:31:11 -08:00
Sam El-Husseini 3d66eab311 [zelos] Output connection position (#3516)
* Move connection point for output connections to the left and centerline
2019-12-16 14:06:10 -08:00
Sam El-Husseini 38e2b9d3ca [zelos] Statement input centreline (#3513)
* Make statement inputs in zelos use the top row centreline.
2019-12-15 02:34:58 -08:00
Sam El-Husseini 595bc5270f Remove BEFORE/AFTER statement input spacer measurable (#3506)
* Remove before / after statement input measurable and use spacer properties instead.
2019-12-11 19:29:31 -08:00
Sam El-Husseini bb5939f77c [zelos] Multi-line rendering (#3501)
* Add isMultiRow property and computation for padding with multirow blocks.
2019-12-11 14:12:36 -08:00
Sam El-Husseini 2b335dcb6b Make alignment common renderer behaviour (#3498)
* Make alignment common
2019-12-11 13:42:10 -08:00
Sam El-Husseini 38fe5189bb [zelos] Limit vertical tightnesting (#3504)
* Limit vertical tight nesting to blocks with a certain height

* Use const.
2019-12-10 16:51:36 -08:00
Sam El-Husseini a779d44104 Reduce the vertical spacing for spacers before and after an input row if it contains non-shadow connected blocks. (#3496) 2019-12-09 13:17:00 -08:00
Sam El-Husseini f5bb5b6143 Zelos horizontal tight nesting. (#3490)
* Reduce the amount of implicit spacing added by the connection shape by adding negative spacing to the first and last spacer in an output block
2019-12-06 10:51:50 -08:00
Sam El-Husseini 4eb791bd70 [zelos] Add right connection shape element. (#3488)
* Add right connection shape element
2019-12-05 17:51:39 -08:00
Sam El-Husseini bcb9e949d2 Adjust zelos spacing constants (#3487) 2019-12-05 11:20:51 -08:00
Sam El-Husseini 5ddf374327 [zelos] bump fields to min x position (#3464)
* Bump up all non-text fields in the first row to a min x position.
2019-11-25 15:40:46 -08:00
Sam El-Husseini 30a49c3225 Statement inputs have minimum widths. (#3463) 2019-11-22 13:53:49 -08:00
Sam El-Husseini d8476306f4 Fix up more zelos spacing (#3445)
* Fix up more of zelos spacing
2019-11-14 16:04:46 -08:00
Sam El-Husseini 36cc9a2e89 Zelos constants (#3419) 2019-11-08 10:59:10 -08:00
Sam El-Husseini ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Sam El-Husseini 7d174727b0 Fix warnings for code used by blocks (#3362) 2019-10-30 08:11:18 -07:00
Sam El-Husseini a79ea1652a [Zelos] Fix dynamic connection shape size (#3324)
* Better reporting of connection height and width for dynamic connections
2019-10-25 00:33:53 -04:00
Sam El-Husseini 06b5bb1945 Might right corner support to common. Making it so there's always a right corner element, square by default. (#3311) 2019-10-23 21:58:43 -04:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini 99ce193b1f Base renderer next / prev connection fixes. (#3135) 2019-10-02 12:35:00 -07:00
Rachel Fenichel ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Neil Fraser 872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Monica Kozbial a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Monica Kozbial a8af9fea21 Move populate for topRow and bottomRow to info (#3057)
* Move populate for topRow and bottomRow from measurable definition to info.

* Fix local variable and circular dependency.
2019-09-20 13:24:46 -07:00
Rachel Fenichel 77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00