Commit Graph

150 Commits

Author SHA1 Message Date
Beka Westberg f16c9c0beb Refactored field validation. 2019-05-24 14:23:42 -07:00
Beka Westberg 354d402c49 Refactored field.init into field.initView and field.initModel 2019-05-03 07:12:46 -07:00
Beka Westberg 123b5dc91e Added fromXml and toXml to fields. 2019-04-25 16:00:09 -07:00
Beka Westberg e8573bc0db Added isSerializable function and SERIALIZABLE property to fields. 2019-04-21 08:28:37 -07:00
Neil Fraser f118d33855 Corrections to JSDoc comments 2019-03-29 15:24:37 -07:00
Neil Fraser e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Neil Fraser db0dbc69ee Update todos and requires. 2018-10-16 11:34:10 -07:00
Neil Fraser aa09ad9175 Line wrap at 80. 2018-10-16 11:34:10 -07:00
Neil Fraser 51e86263c7 Correct requires for goog.math.* 2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 03bf9f5e71 Remove goog.string 2018-07-11 12:20:02 -07:00
Neil Fraser 3909bd420a Remove all goog.asserts and goog.isXxx
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Rachel Fenichel a572a15874 Merge pull request #1827 from rachel-fenichel/feature/references_variables
Add a referencesVariables function to field
2018-04-27 15:34:53 -07:00
Rachel Fenichel 66fde72ab6 Change comment on function 2018-04-27 13:25:06 -07:00
Neil Fraser 4cb4b42f8d Use named properties on Msg. 2018-04-27 11:50:51 -07:00
Rachel Fenichel a8767ee6c9 Add a referencesVariables function to field 2018-04-25 15:15:05 -07:00
Rachel Fenichel 8de5b3ee9f Get rid of variable redeclaration 2018-03-15 13:04:09 -07:00
Rachel Fenichel 615c403b44 Use @nocompress annotation to fix advanced compilation. 2018-03-01 12:35:55 -08:00
Mark Gibson 54f0e06e21 Customising field types using a register of fields #1584 (#1594)
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Mark Gibson 2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel fb897d7786 Even more lint. 90 errors remaining. 2018-01-23 18:33:30 -08:00
Rachel Fenichel 06ae9ade8e Don't update the field until all checks pass 2018-01-19 15:49:39 -08:00
Rachel Fenichel 7314bdfb3a Fix #1499 and add some validation 2018-01-17 16:54:12 -08:00
Rachel Fenichel b593d44379 Make the potential variable map null when not needed 2018-01-12 14:51:02 -08:00
Rachel Fenichel 80b397f532 Respond to more review comments 2018-01-10 17:27:43 -08:00
Rachel Fenichel a43b0e7010 Respond to commit comments and make compressed blockly work again 2018-01-10 17:02:02 -08:00
Rachel Fenichel 5d6d7519cd Remove some TODOs; add a variable-referencing block to the simple playground flyout 2018-01-08 14:14:26 -08:00
Rachel Fenichel b342fb2121 Fix problem with clearing flyout after a variable was deleted. 2018-01-02 16:42:28 -08:00
Rachel Fenichel 6218750207 Fix events for variable fields on new blocks; fix tests 2017-12-19 11:28:23 -08:00
Rachel Fenichel e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel 7e411b5428 Fix checkmarks when the variable dropdown is open. 2017-12-13 11:50:08 -08:00
Rachel Fenichel 61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel 1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel f37386d2bf Fix default variable name 2017-12-13 11:50:07 -08:00
Rachel Fenichel 3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Rachel Fenichel 19939dc16a All but XML tests now pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel 3728cfed45 Update tests in workspace_test. Get rid of renameVariable 2017-12-13 11:50:07 -08:00
Rachel Fenichel c55b6afc6f Fix tests in field_variable_test.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel 47457d1683 Fix renaming 2017-12-13 11:50:07 -08:00
Rachel Fenichel c157412fc5 Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables 2017-12-13 11:50:07 -08:00
RoboErikG a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
Tianwei Du 492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
Neil Fraser e100c66659 Linting. 2017-10-24 14:06:29 -07:00
Neil Fraser 4262b09002 Resolve 106 warnings. 2017-10-24 14:06:29 -07:00
picklesrus 5518873389 Revert "Remove all all instances calling setValue on variable fields with the name instead of the id" (#1296)
* Revert "Create WorkspaceViewport class (#1291)"

This reverts commit 6c00d77c9e.

* Revert "Remove all all instances calling setValue with name. (#1254)"

This reverts commit 8e8b6b27af.
2017-08-28 16:55:44 -07:00
marisaleung 8e8b6b27af Remove all all instances calling setValue with name. (#1254) 2017-08-24 14:34:01 -07:00
marisaleung 733d869f8e Add VariableType checks. 2017-07-20 16:47:37 -07:00
marisaleung 170b16706f Modularize Rename Variable prompt and allow custom context menus for flyout. 2017-07-06 15:41:18 -07:00