Commit Graph

40 Commits

Author SHA1 Message Date
Aaron Dodson 6b07ccab96 chore: Remove declareLegacyNamespace from renderers (#5528)
* chore: Remove declareLegacyNamespace from Geras renderer

* chore: Remove declareLegacyNamespace from minimalist renderer

* chore: Remove declareLegacyNamespace from thrasos renderer

* chore: Remove declareLegacyNamespace from zelos renderer

* fix: Move debugger functionality out of Blockly.blockRendering to avoid dependency cycle when re-exporting submodules

* chore: Remove declareLegacyNamespace from Blockly.blockRendering.*
2021-09-24 08:33:35 -07:00
Rachel Fenichel 3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
kozbial 6bf9a336f4 clang-format core/renderers/thrasos/info.js 2021-08-16 11:23:51 -07:00
kozbial ce662f43d9 Migrate core/renderers/thrasos/info.js named requires 2021-08-16 11:23:51 -07:00
kozbial 1cd9e1c8ea Migrate core/renderers/thrasos/info.js to goog.module 2021-08-16 11:23:51 -07:00
kozbial 60ed51a0b3 Migrate core/renderers/thrasos/info.js to ES6 const/let 2021-08-16 11:23:51 -07:00
kozbial 0def8c0a99 Migrate core/renderers/thrasos/renderer.js named requires 2021-08-16 11:01:50 -07:00
kozbial 9daf2f3be1 Migrate core/renderers/thrasos/renderer.js to goog.module 2021-08-16 11:01:50 -07:00
Christopher Allen 1197afcee7 Fix JSDoc type annotations causing closure-make-deps warnings
Some type annotations were missing curly brackets, which makes
closure-make-deps emit uninteresting warnings.  Now any output
from the command will be informative and related to whatever
one is presently working on.
2021-07-12 03:17:14 +01:00
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Sam El-Husseini f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Rachel Fenichel 1f4891e309 Fix missing requires and requireTypes in thrasos 2021-02-02 11:38:08 -08:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Monica Kozbial fdb1d71e88 Editable field spacing (#3635)
* Substituting checks for isEditable.

* Add isField checks.

* Add parentheses for casting.

* Update value of isEditable and use for spacing.

* Changing to double equals.
2020-01-23 13:10:33 -08:00
Sam El-Husseini c3867443f5 Fix value to stack width measurement (#3559)
* Include width of connected block in value to stack width measurement.
2020-01-07 16:05:34 -08:00
Sam El-Husseini 2b335dcb6b Make alignment common renderer behaviour (#3498)
* Make alignment common
2019-12-11 13:42:10 -08:00
Sam El-Husseini 70c24cf94e CSS in renderers (#3446)
* Have each renderer declare some CSS that is specific to the renderer.
2019-11-18 16:14:19 -08:00
Sam El-Husseini e7752e6ea2 Dummy input right alignment (#3342)
* Fix dummy input alignment in geras.
2019-10-28 16:20:54 -07:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Rachel Fenichel ecf69d851d Use row height for spacer height. 2019-10-01 16:41:58 -07:00
Neil Fraser 872aa45fae More straightening out of dependencies. 2019-09-27 10:48:14 -07:00
Monica Kozbial a14ac351b5 Adding checks for whether to add elem spacer on row ends (#3060)
* Adding checks for whether elem spacer shouldbe added to start and end of row.

* Fix eslint and add package visibility.
2019-09-20 14:20:14 -07:00
Rachel Fenichel 77185906d8 Renderers define which paths a block has. (#2981)
* Move render elements into a path object.
2019-09-16 12:13:32 -07:00
Sam El-Husseini e339ae26bc Move the rendering object to live on the workspace_svg (#3016)
* Move the rendering object onto the workspace allowing the various workspaces to have different renderers.
2019-09-13 14:20:34 -07:00
Sam El-Husseini fc420b7037 Support for registering renderers and switching between them (#3013)
* Added support for registering renderers and for choosing which renderer the workspace wants to use.
2019-09-13 10:30:20 -07:00
kozbial 90a10e5f44 Fix logic in shouldStartNewRow_ and between row padding in geras. 2019-09-12 11:34:08 -07:00
Sam El-Husseini 8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel 4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Rachel Fenichel 2ffe71f0a0 Remove references to dark path offset; fix highlights while dragging' 2019-09-05 11:59:28 -07:00
Rachel Fenichel 87e7be9619 Cleanup 2019-09-04 17:19:31 -07:00
Rachel Fenichel 581705cc7b Create a Renderer base class and extend it for each type of renderer 2019-09-04 17:16:08 -07:00
Rachel Fenichel e35f4d5070 More cleanup. 2019-09-04 16:26:53 -07:00
Rachel Fenichel b4ac23df6c Remove useless variable. 2019-09-04 16:26:53 -07:00
Rachel Fenichel 135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini 189c561f49 Rendering type checker (#2950)
* Convert all rendering types to use a type enum flag.
2019-09-03 14:39:02 -07:00
Rachel Fenichel d3fea64f99 Fix width on dummy row. 2019-08-30 17:50:06 -07:00
Rachel Fenichel bc50143130 Remove special case for spacer after statement 2019-08-29 15:05:09 -07:00
Rachel Fenichel a81c633be7 Centralize references to Blockly.blockRendering.constants 2019-08-22 18:08:59 -07:00
Rachel Fenichel dd9fdf908f Slightly less fragile 2019-08-21 15:24:37 -07:00
Rachel Fenichel e86c852936 Split render_info 2019-08-21 14:33:43 -07:00