Commit Graph

528 Commits

Author SHA1 Message Date
kozbial bdf16d88e0 clang-format core/renderers/geras/measurables/input.js 2021-08-11 13:51:05 -07:00
kozbial 8f83073cdb Migrate core/renderers/geras/measurables/input.js named requires 2021-08-11 13:51:05 -07:00
kozbial 26d4431ae5 Migrate core/renderers/geras/measurables/input.js to goog.module 2021-08-11 13:51:05 -07:00
kozbial 87568c5869 Split classes from core/renderers/geras/measurables/input.js into multiple files 2021-08-11 13:51:05 -07:00
kozbial 88a7779cb2 clang-format core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial 35cf6482e3 Migrate core/renderers/measurables/inputs.js named requires 2021-08-11 13:49:50 -07:00
kozbial 59dee77fa8 Migrate core/renderers/measurables/inputs.js to goog.module 2021-08-11 13:49:50 -07:00
kozbial 3081c40a02 Migrate core/renderers/measurables/input_connection.js to ES6 const/let 2021-08-11 13:49:50 -07:00
kozbial 09573bcf16 Split classes from core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial 62fff867d8 clang-format core/renderers/common/renderer.js 2021-08-11 13:45:38 -07:00
kozbial 15c512f6ea Migrate core/renderers/common/renderer.js named requires 2021-08-11 13:45:38 -07:00
kozbial c1bf49ae5c Migrate core/renderers/common/renderer.js to goog.module 2021-08-11 13:45:38 -07:00
kozbial 684047d22f Migrate core/renderers/common/renderer.js to ES6 const/let 2021-08-11 13:45:38 -07:00
kozbial 8aa437b44a Migrate core/renderers/minimalist/drawer.js named requires 2021-08-11 13:44:17 -07:00
kozbial 7c45b039f3 Migrate core/renderers/minimalist/drawer.js to goog.module 2021-08-11 13:44:17 -07:00
Christopher Allen 4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson 228ecb0f2d Migrate core/renderers/geras/renderer.js to goog.module syntax (#5307)
* Migrate core/renderers/geras/renderer.js to goog.module

* Migrate core/renderers/geras/renderer.js to named requires

* clang-format core/renderers/geras/renderer.js
2021-08-11 08:30:05 -07:00
Aaron Dodson 0f7f597758 Migrate core/renderers/geras/drawer.js to goog.module syntax (#5300)
* Migrate core/renderers/geras/drawer.js to ES6 const/let

* Migrate core/renderers/geras/drawer.js to goog.module

* Migrate core/renderers/geras/drawer.js to named requires

* clang-format core/renderers/geras/drawer.js

* Remove Blockly prefix on call to blockRendering in core/renderers/geras/drawer.js
2021-08-11 08:26:04 -07:00
Aaron Dodson 18283e816f Migrate core/renderers/measurables/base.js to goog.module syntax (#5308)
* Migrate core/renderers/measurables/base.js to goog.module

* Migrate core/renderers/measurables/base.js to named requires
2021-08-11 08:11:44 -07:00
kozbial 1487698343 Remove extra newline and remove unecessary package annotation 2021-08-09 18:23:07 -07:00
kozbial 70d8ca2a20 clang-format core/renderers/common/block_rendering.js 2021-08-09 18:23:07 -07:00
kozbial f565120efb Migrate core/renderers/common/block_rendering.js named requires 2021-08-09 18:23:07 -07:00
kozbial a4a3b6a068 Migrate core/renderers/common/block_rendering.js to goog.module 2021-08-09 18:23:07 -07:00
kozbial 440be28b4a Migrate core/renderers/common/block_rendering.js to ES6 const/let 2021-08-09 18:23:07 -07:00
Aaron Dodson b5444b4e89 Migrate core/renderers/geras/path_object.js to goog.module syntax (#5306)
* Migrate core/renderers/geras/path_object.js to goog.module

* Migrate core/renderers/geras/path_object.js to named requires

* clang-format core/renderers/geras/path_object.js
2021-08-09 12:30:07 -07:00
Aaron Dodson 2b6d275440 Migrate core/renderers/measurables/types.js to goog.module syntax (#5309)
* Migrate core/renderers/measurables/types.js to goog.module

* Migrate core/renderers/measurables/types.js to named requires

* clang-format core/renderers/measurables/types.js
2021-08-05 13:57:16 -07:00
Aaron Dodson d0b5f6db8b Migrate core/renderers/geras/highlight_constants.js to goog.module syntax (#5303)
* Migrate core/renderers/geras/highlight_constants.js to ES6 const/let

* Migrate core/renderers/geras/highlight_constants.js to goog.module

* Migrate core/renderers/geras/highlight_constants.js to named requires

* clang-format core/renderers/geras/highlight_constants.js
2021-08-05 10:13:03 -07:00
Aaron Dodson 80b521e8d7 Migrate core/renderers/geras/info.js to goog.module syntax (#5305)
* Migrate core/renderers/geras/info.js to ES6 const/let

* Migrate core/renderers/geras/info.js to goog.module

* Migrate core/renderers/geras/info.js to named requires

* clang-format core/renderers/geras/info.js
2021-08-05 08:09:10 -07:00
Aaron Dodson fba87c93c4 Migrate core/renderers/geras/highlighter.js to goog.module syntax (#5304)
* Migrate core/renderers/geras/highlighter.js to ES6 const/let

* Migrate core/renderers/geras/highlighter.js to goog.module

* Migrate core/renderers/geras/highlighter.js to named requires

* clang-format core/renderers/geras/highlighter.js
2021-08-04 12:12:53 -07:00
kozbial b233c5f10a Update visibility of constants 2021-08-04 09:20:20 -07:00
kozbial 99b30b92ce clang-format core/renderers/common/marker_svg.js 2021-08-04 09:20:20 -07:00
kozbial 3b43a19705 Migrate core/renderers/common/marker_svg.js named requires 2021-08-04 09:20:20 -07:00
kozbial 7aa382154c Migrate core/renderers/common/marker_svg.js to goog.module 2021-08-04 09:20:20 -07:00
kozbial 8eda99ea34 Migrate core/renderers/common/marker_svg.js to ES6 const/let 2021-08-04 09:20:20 -07:00
Monica Kozbial bec82da358 Remove require destructuring (#5294) 2021-08-03 15:07:14 -07:00
Aaron Dodson 87ccee7843 clang-format core/renderers/geras/constants.js 2021-08-03 10:42:26 -07:00
Aaron Dodson 0203eec8c7 Migrate core/renderers/geras/constants.js to named requires 2021-08-03 10:40:25 -07:00
Aaron Dodson 8e30d9ebd1 Migrate core/renderers/geras/constants.js to goog.module 2021-08-03 10:37:17 -07:00
kozbial 3d8a79fe96 Add missing eslint disable to core/renderers/common/i_path_object.js 2021-07-30 15:49:17 -07:00
kozbial 03de38c41a Add eslint disable 2021-07-30 15:19:26 -07:00
kozbial 31b10f1489 Migrate core/renderers/common/i_path_object.js named requires 2021-07-30 15:19:26 -07:00
kozbial 3aae7ffbde Migrate core/renderers/common/i_path_object.js to goog.module 2021-07-30 15:19:26 -07:00
Rachel Fenichel 55207a2e7f clang-format core/renderers/common/path_object.js 2021-07-27 14:41:29 -07:00
Rachel Fenichel cf3d22c490 Migrate core/renderers/common/path_object.js named requires 2021-07-27 14:39:02 -07:00
Rachel Fenichel c068a3b6f9 Migrate core/renderers/common/path_object.js to goog.module 2021-07-27 14:26:04 -07:00
Rachel Fenichel 1dfee3a722 Make defs private and add nullability 2021-07-23 16:39:40 -07:00
Rachel Fenichel a392696c7a Convert core/renderers/common/constants.js to const/let 2021-07-23 15:07:30 -07:00
Rachel Fenichel 4aef7e3bcd clang-format core/renderers/common/constants.js 2021-07-23 15:00:14 -07:00
Rachel Fenichel 82c1d8c47a Migrate core/renderers/common/constants.js named requires 2021-07-23 14:48:55 -07:00
Rachel Fenichel e9c1e67d17 Migrate core/renderers/common/constants.js to goog.module 2021-07-23 14:38:20 -07:00