Commit Graph

33 Commits

Author SHA1 Message Date
Rachel Fenichel e8d6f7f408 chore: auto-fix violations of comma-dangle rule (#5625) 2021-10-21 09:01:51 -07:00
Aaron Dodson 3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser 90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Christopher Allen d2d5dc4b71 fix: Use require instead of requireType for interfaces (#5568)
But only if the interface is used in an @implements or @extends
declaration.

Fixes #5450
2021-09-29 17:44:21 +01:00
Monica Kozbial 49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Aaron Dodson e0693a65d2 chore: Remove declareLegacyNamespace() from files in core (#5525)
* chore: Remove declareLegacyNamespace() from files in core

* fix: Update missing/errant re-exports in blockly.js
2021-09-23 14:48:52 -07:00
kozbial e5359e4bf5 Update named require in core/metrics_manager.js 2021-08-18 09:54:19 -07:00
kozbial e340b00027 clang-format core/metrics_manager.js 2021-08-18 09:54:19 -07:00
kozbial 5b0160db70 Migrate core/metrics_manager.js named requires 2021-08-18 09:54:19 -07:00
kozbial 30fe1aacec Migrate core/metrics_manager.js to goog.module 2021-08-18 09:54:19 -07:00
kozbial c449f516d7 Migrate core/metrics_manager.js to ES6 const/let 2021-08-18 09:54:19 -07:00
kozbial 7974e6325b Split classes from core/metrics_manager.js into multiple files 2021-08-18 09:54:19 -07:00
Christopher Allen 4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Neil Fraser d519ab8f54 JSDoc improvements 2021-05-27 21:30:26 -07:00
Neil Fraser dd0314bc0b Normalize comments 2021-05-19 09:57:14 -07:00
Monica Kozbial e295102eda Update Flyout metrics and implement adjustable margin for scrollbars. (#4763) 2021-04-09 11:16:34 -07:00
Monica Kozbial babf940ef5 Fix flyout scroll metrics (#4726)
* Fix flyout scroll metrics
2021-03-24 10:07:28 -07:00
Monica Kozbial 7fdf579985 Update jsdoc (#4714) 2021-03-18 15:52:04 -07:00
alschmiedt 869e4eb366 Update flyout metrics to work with the new metrics manager (#4684) 2021-03-09 17:09:49 -08:00
Rachel Fenichel 6a1ee141ea Lint 2021-03-05 14:23:43 -08:00
Rachel Fenichel f7e0d5f4ea Use existing toolbox position enum 2021-03-05 14:16:43 -08:00
Rachel Fenichel 59084a043c TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc 2021-03-05 13:48:45 -08:00
alschmiedt 26104d280d Update metrics to support mutators (#4679) 2021-03-05 11:44:29 -08:00
Monica Kozbial ef8a5a1fe1 Add PluginManager (#4672)
* Add PluginManager.
2021-03-04 16:51:06 -08:00
Monica Kozbial 57749e6eb8 Updating bump logic to support single-direction scrollbars (#4652)
* Updating bump logic to support single-direction scrollbars
2021-03-01 12:20:12 -08:00
Sam El-Husseini ab8a11784d Fix event related missing requires (#4656)
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
Rachel Fenichel ea39e03b8c Merge pull request #4637 from rachel-fenichel/missing_require_feb
Fix missing requireTypes
2021-02-18 14:07:20 -08:00
alschmiedt 7b30cc76a4 Adds tests for metrics manager (#4635) 2021-02-18 13:45:53 -08:00
Rachel Fenichel 05ab37690e Missing requiretypes, m through r 2021-02-17 14:39:15 -08:00
alschmiedt d81703a745 Metrics register (#4630) 2021-02-12 16:16:33 -08:00
alschmiedt a8f28c6b11 Metrics refactor (#4627) 2021-02-10 16:19:56 -08:00