e8d6f7f408
chore: auto-fix violations of comma-dangle rule ( #5625 )
2021-10-21 09:01:51 -07:00
3851b14627
refactor: Migrate to named exports ( #5623 )
...
* refactor: Migrate to named exports
* fix: Sort requires
* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
90b3f75d82
Remove @author tags ( #5601 )
...
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.
Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
ec9092fd67
Changes Css.register API to accept string param ( #5472 )
...
* Chnages Css.register API to accept string param
* Address self review comments and nits
* Fix code-comment
* Address minor review comments and nits
* Allow passing an array of strings when registering CSS
* Fix lint errors
Co-authored-by: Aaron Dodson <adodson@google.com >
2021-10-14 15:47:10 -07:00
b25e24fd02
chore: Run clang-format on core/*.js ( #5589 )
...
* Run clang-format on core/*.js
* Revert changes for css formatting
2021-10-07 10:32:02 -07:00
ca61d8cbc6
fix: Fix errors in injected CSS ( #5587 )
2021-10-07 09:58:18 -07:00
d2d5dc4b71
fix: Use require instead of requireType for interfaces ( #5568 )
...
But only if the interface is used in an @implements or @extends
declaration.
Fixes #5450
2021-09-29 17:44:21 +01:00
49bc2b1ae4
Replace namespace annotation with class annotation in files that define a class ( #5566 )
2021-09-28 15:57:09 -07:00
d8fbe1b05b
Add namespace and alias annotations to jsdoc ( #5550 )
...
* Add annotations to files under core/events
* Add annotations to files under core/interfaces
* Add annotations to files under core/keyboard_nav
* Add annotations to files under core/renderers
* Add annotations to files under core/serialization
* Add annotations to files under core/theme
* Add annotations to files under core/toolbox
* Add annotations to files under core/utils
* Add annotations to files under core
2021-09-27 14:42:54 -07:00
2b34748e0e
chore: remove declareLegacyNamespace from events ( #5532 )
...
- Adds an extra events/utils.js file to hold helper methods related to events.
2021-09-24 14:20:32 -07:00
e0693a65d2
chore: Remove declareLegacyNamespace() from files in core ( #5525 )
...
* chore: Remove declareLegacyNamespace() from files in core
* fix: Update missing/errant re-exports in blockly.js
2021-09-23 14:48:52 -07:00
d83eb1364b
fix: enable missingRequire in build_tasks ( #5510 )
2021-09-21 13:19:55 -07:00
c31895dc60
fix: Add missing require for Blockly.utils.object, .Size ( #5427 )
...
Some files were using Blockly.utils.object.inherits (or .mixin) without
having imported Blockly.utils.object.
Similarly, trashcan.js tried to use utils.Size as a constructor
instead of importing Size from Blockly.utils.Size.
2021-09-03 22:45:54 +01:00
4c40378b9a
Use goog.requireType when importing interfaces (etc.) ( #5343 )
...
* Use goog.requireType when importing I* interfaces
Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.
This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.
* Use goog.requireType when only using import for type specifications
Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.
* Remove spurious eslint-disable no-unused-vars
There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.
Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.
* Remove obsolete Closure Compiler error group
stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
adc4c02abf
Fix lint
2021-07-27 16:39:44 -07:00
5a5aabb7e7
clang-format core/zoom_controls.js
2021-07-27 09:05:27 -07:00
40c095f496
Migrate core/zoom_controls.js named requires
2021-07-27 09:05:27 -07:00
bc7c5115e1
Migrate core/zoom_controls.js to goog.module
2021-07-27 09:05:27 -07:00
61bbffc29e
Migrate core/zoom_controls.js to ES6 const/let
2021-07-27 09:05:27 -07:00
cf7a8b95b8
Remove extra requires of Blockly.constants
2021-07-21 15:35:19 -07:00
cc7a263fb3
Replace references to SPRITE and SOUND_LIMIT with internalConstants versions
2021-07-21 15:33:55 -07:00
7b286dbf82
Update the registered component ids ( #4898 )
2021-06-17 17:50:04 -07:00
ff34e067f8
Update positionable jsdoc ( #4908 )
2021-06-14 13:14:01 -07:00
0014ad3257
Add id to component interface ( #4887 )
2021-06-10 16:03:43 -07:00
d2579a7369
Add removeComponent to ComponentManager ( #4884 )
2021-06-09 22:29:33 -07:00
5344ad6c21
Add support for IAutoHideable ( #4855 )
2021-05-27 17:01:11 -07:00
1cadbb94bd
Rename PluginManager and related elements ( #4857 )
...
* Rename PluginManager and related elements to use component instead of plugin
* Rename types to capabilities
2021-05-27 16:14:33 -07:00
dd0314bc0b
Normalize comments
2021-05-19 09:57:14 -07:00
6259579c64
Add positioning helpers for trashcan and zoom controls ( #4807 )
2021-05-07 17:13:48 -07:00
0cc79b1366
Fix missing require - constructors ( #4676 )
...
* Fix missing constructors
2021-04-21 12:11:13 -07:00
b6628da5bb
Always scroll center on zoom reset ( #4725 )
...
* Always scroll center on zoom reset
2021-03-24 10:08:42 -07:00
8386566894
Update IPositionable position JSDoc ( #4705 )
2021-03-19 16:39:27 -07:00
bea85cda1c
Positionables bugfix ( #4685 )
...
* Apply fixes to positionable logic
* Update variable name and add @private annotation
2021-03-08 11:20:30 -08:00
855185c6cf
Merge pull request #4682 from rachel-fenichel/toolbox_constants
...
Use Blockly.utils.toolbox.Position enum everywhere
2021-03-08 10:52:58 -08:00
d4897061d7
Cleanup comment ( #4680 )
2021-03-05 15:47:00 -08:00
f837f1e44e
Add zoom support for single-direction-scroll ( #4653 )
...
* Add zoom support for single-direction scroll
2021-03-05 14:37:41 -08:00
f7e0d5f4ea
Use existing toolbox position enum
2021-03-05 14:16:43 -08:00
59084a043c
TOOLBOX_AT_TOP and friends -> constants.toolboxPosition.TOP, etc
2021-03-05 13:48:45 -08:00
63d26dc186
Add extra requires check ( #4677 )
...
* Add extra requires check
2021-03-05 09:50:51 -08:00
ef8a5a1fe1
Add PluginManager ( #4672 )
...
* Add PluginManager.
2021-03-04 16:51:06 -08:00
f2cec81584
Adding Positionable interface ( #4669 )
...
* Adding IPositionable interface.
2021-03-02 16:17:17 -08:00
f97730e83c
Sort requires ( #4658 )
...
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
ab8a11784d
Fix event related missing requires ( #4656 )
...
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
1d8c234d33
Update uses of bindEvent_, bindEventWithChecks_, and unbindEvent_. Add missing requires for Blockly.browserEvents.
2021-02-23 11:23:28 -08:00
54c4e8de39
Rename Blockly.eventHandling->Blockly.browserEvents and replace all Blockly.EventData annotations
2021-02-22 13:23:19 -08:00
c9be2402bd
More missing requires
2021-01-12 12:38:21 -08:00
40ef586260
Refactoring Ui events in core ( #4418 )
...
* Ui events base (#4370 )
* Add constants for new ui event types
* Add property to indicate an event as UI event
* Click events (#4372 )
* Creating new ui base class.
* Refactor theme event (#4391 )
* Add themeName property to theme event
* Refactor marker move events. (#4389 )
* Refactor trashcan open event (#4392 )
* Refactor selected event (#4387 )
* Refactor toolbox item change event (#4394 )
* Refactor bubble open events (#4390 )
* Refactor block drag event (#4388 )
* Viewport events (#4395 )
* Fix event filtering for ui events (#4401 )
* Move events to new directory and rename Ui events base (#4400 )
* Move events to new directory and rename Ui events base
* Add missing fromJson implementation for click event (#4410 )
* Adding serialization tests for events
* Zoom controls event (#4407 )
* Refactor zoom event
* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
fba35d342c
Add missing require Blockly.constants ( #4366 )
2020-10-12 17:56:42 -04:00
db40e44b7c
Move Blockly.utils.dom.SvgElementType to Blockly.utils.Svg ( #4285 )
...
* Move SVGElementType to its own file shaving off 2.7KB
2020-09-16 14:42:58 -07:00
f8f98831af
Add zoom controls tests. ( #4159 )
2020-08-12 18:39:35 -07:00
Rachel Fenichel
Aaron Dodson
Neil Fraser
Sandeep Dubey
Monica Kozbial
Christopher Allen
alschmiedt
kozbial
Sam El-Husseini