Commit Graph

6981 Commits

Author SHA1 Message Date
kozbial c1bf49ae5c Migrate core/renderers/common/renderer.js to goog.module 2021-08-11 13:45:38 -07:00
kozbial 684047d22f Migrate core/renderers/common/renderer.js to ES6 const/let 2021-08-11 13:45:38 -07:00
kozbial 8aa437b44a Migrate core/renderers/minimalist/drawer.js named requires 2021-08-11 13:44:17 -07:00
kozbial 7c45b039f3 Migrate core/renderers/minimalist/drawer.js to goog.module 2021-08-11 13:44:17 -07:00
Christopher Allen 4c40378b9a Use goog.requireType when importing interfaces (etc.) (#5343)
* Use goog.requireType when importing I* interfaces

Interfaces have no code, so should never be referred to outside of
(JSDoc) comments, and so the modules that define only interfaces never
need to be goog.require'd - goog.requireType is always sufficient.

This commit fixes imports of all modules whose name matches
/(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in
core/interfaces/.

* Use goog.requireType when only using import for type specifications

Where a module is imported only to used in JSDoc comments it can
(and should) be goog.requireType'd instead of goog.require'd.

* Remove spurious eslint-disable no-unused-vars

There were a few cases where modules were being imported with
goog.require (because they are referred to in code, not just JSDoc
comments) but were prefaced by a spurious eslint suppress.

Remove these, restoring the invariant that an import gets an eslint
if and only if it is a requireType.

* Remove obsolete Closure Compiler error group

stricterMissingRequire has been superceded by missingRequire, and now
causes a Java null pointer exception if supplied.
2021-08-11 18:50:45 +01:00
Aaron Dodson a5729043c1 Migrate core/events/events_block_drag.js to goog.module syntax (#5286)
* Migrate core/events/events_block_drag.js to ES6 const/let

* Migrate core/events/events_block_drag.js to goog.module

* Migrate core/events/events_block_drag.js to named requires

* clang-format core/events/events_block_drag.js
2021-08-11 08:40:01 -07:00
Aaron Dodson 4b6ccf868c Migrate core/events/events_theme_change.js to goog.module syntax (#5279)
* Migrate core/events/events_theme_change.js to ES6 const/let

* Migrate core/events/events_theme_change.js to goog.module

* Migrate core/events/events_theme_change.js to named requires

* clang-format core/events/events_theme_change.js
2021-08-11 08:35:01 -07:00
Aaron Dodson 228ecb0f2d Migrate core/renderers/geras/renderer.js to goog.module syntax (#5307)
* Migrate core/renderers/geras/renderer.js to goog.module

* Migrate core/renderers/geras/renderer.js to named requires

* clang-format core/renderers/geras/renderer.js
2021-08-11 08:30:05 -07:00
Aaron Dodson 0f7f597758 Migrate core/renderers/geras/drawer.js to goog.module syntax (#5300)
* Migrate core/renderers/geras/drawer.js to ES6 const/let

* Migrate core/renderers/geras/drawer.js to goog.module

* Migrate core/renderers/geras/drawer.js to named requires

* clang-format core/renderers/geras/drawer.js

* Remove Blockly prefix on call to blockRendering in core/renderers/geras/drawer.js
2021-08-11 08:26:04 -07:00
Aaron Dodson 18283e816f Migrate core/renderers/measurables/base.js to goog.module syntax (#5308)
* Migrate core/renderers/measurables/base.js to goog.module

* Migrate core/renderers/measurables/base.js to named requires
2021-08-11 08:11:44 -07:00
Rachel Fenichel df389f2c6a Merge pull request #5354 from google/dependabot/npm_and_yarn/develop/concurrently-6.2.1
Bump concurrently from 6.2.0 to 6.2.1
2021-08-10 17:57:43 -07:00
dependabot[bot] ed500ba617 Bump concurrently from 6.2.0 to 6.2.1
Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](https://github.com/open-cli-tools/concurrently/compare/v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-11 00:50:57 +00:00
Rachel Fenichel 4285caabb8 Merge pull request #5301 from google/dependabot/npm_and_yarn/develop/blockly/theme-modern-2.1.22
Bump @blockly/theme-modern from 2.1.21 to 2.1.22
2021-08-10 17:49:25 -07:00
Rachel Fenichel 104097ebdf Merge pull request #5271 from google/dependabot/npm_and_yarn/develop/blockly/block-test-1.1.3
Bump @blockly/block-test from 1.1.2 to 1.1.3
2021-08-10 17:49:10 -07:00
kozbial 2a62c06a92 Update script to use python3 command 2021-08-10 16:43:08 -07:00
Aaron Dodson a04debf275 Fix issue that prevented Mocha and generator tests from running on certain configurations (#5344)
* Fix issue that prevented Mocha and generator tests from running on certain configurations

* Link to Blockly issue re: --disable-gpu flag
2021-08-10 15:11:56 -07:00
kozbial a7fcf881fa Add missing eslint disable line for required interface 2021-08-10 11:20:03 -07:00
kozbial ee53e8e812 Update optional requires 2021-08-10 11:18:38 -07:00
Aaron Dodson 6bae1ce9f9 Migrate core/workspace_svg.js to goog.module syntax (#5334)
* Migrate core/workspace_svg.js to ES6 const/let

* Migrate core/workspace_svg.js to goog.module

* Migrate core/workspace_svg.js to named requires

* clang-format core/workspace_svg.js
2021-08-10 08:09:46 -07:00
kozbial 6ad723afbc Add eslint disable 2021-08-09 18:53:11 -07:00
kozbial 6863d7fa08 clang-format core/toolbox/toolbox.js 2021-08-09 18:53:11 -07:00
kozbial a2e9509542 Migrate core/toolbox/toolbox.js named requires 2021-08-09 18:53:11 -07:00
kozbial ec1567020b Migrate core/toolbox/toolbox.js to goog.module 2021-08-09 18:53:11 -07:00
kozbial 8875dbd50c Migrate core/toolbox/toolbox.js to ES6 const/let 2021-08-09 18:53:11 -07:00
kozbial d7840db736 clang-formant core/events/variable_events.js 2021-08-09 18:52:07 -07:00
kozbial dc2438eb28 Migrate core/events/block_events.js named requires 2021-08-09 18:52:07 -07:00
kozbial 9ac531ba58 Migrate core/events/block_events.js to goog.module 2021-08-09 18:52:07 -07:00
kozbial 6e821fb9fc Migrate core/events/block_events.js to ES6 const/let 2021-08-09 18:52:07 -07:00
kozbial d1ab960f0f Split classes from core/events/variable_events.js into multiple files 2021-08-09 18:52:07 -07:00
kozbial 2f71d18e8a Update jsdoc comment for classes 2021-08-09 18:26:43 -07:00
kozbial 5acdd5e4bc clang-format core/events/block_events.js 2021-08-09 18:26:43 -07:00
kozbial 7889b02d9b Migrate core/events/block_events.js named requires 2021-08-09 18:26:43 -07:00
kozbial fd0385dd63 Migrate core/events/block_events.js to goog.module 2021-08-09 18:26:43 -07:00
kozbial 20dad54d38 Migrate core/events/block_events.js to ES6 const/let 2021-08-09 18:26:43 -07:00
kozbial abbc1b3de3 Split classes from core/events/block_events.js into multiple files 2021-08-09 18:26:43 -07:00
kozbial 1487698343 Remove extra newline and remove unecessary package annotation 2021-08-09 18:23:07 -07:00
kozbial 70d8ca2a20 clang-format core/renderers/common/block_rendering.js 2021-08-09 18:23:07 -07:00
kozbial f565120efb Migrate core/renderers/common/block_rendering.js named requires 2021-08-09 18:23:07 -07:00
kozbial a4a3b6a068 Migrate core/renderers/common/block_rendering.js to goog.module 2021-08-09 18:23:07 -07:00
kozbial 440be28b4a Migrate core/renderers/common/block_rendering.js to ES6 const/let 2021-08-09 18:23:07 -07:00
Aaron Dodson 08a8c0be6d Migrate core/contextmenu_registry.js to goog.module syntax (#5149)
* Migrate core/contextmenu_registry.js to ES6 const/let

* Migrate core/contextmenu_registry.js to goog.module

* Migrate core/contextmenu_registry.js to named requires

* clang-format core/contextmenu_registry.js

* Make core/contextmenu_registry.js constructor private
2021-08-09 15:02:03 -07:00
kozbial 7eedf623d5 Change private static variable to local variable. 2021-08-09 14:59:22 -07:00
kozbial e10be5444f clang-format core/workspace.js 2021-08-09 14:59:22 -07:00
kozbial 74b5a12c6d Migrate core/workspace.js named requires 2021-08-09 14:59:22 -07:00
kozbial ac4fa41cb3 Migrate core/workspace.js to goog.module 2021-08-09 14:59:22 -07:00
kozbial 5f669a7607 Migrate core/workspace.js to ES6 const/let 2021-08-09 14:59:22 -07:00
Aaron Dodson fbd7c8ab79 Migrate core/events/workspace_events.js to goog.module syntax (#5274)
* Migrate core/events/workspace_events.js to ES6 const/let

* Migrate core/events/workspace_events.js to goog.module

* Migrate core/events/workspace_events.js to named requires

* clang-format core/events/workspace_events.js

* Update build artifact sizes in check_metadata.sh

* Add comment about root cause of build artifact size change

* Migrate core/events/workspace_events.js to ES6 const/let

* Migrate core/events/workspace_events.js to goog.module

* Migrate core/events/workspace_events.js to named requires

* clang-format core/events/workspace_events.js

* Clarify require name for Blockly.Events.Abstract
2021-08-09 12:43:06 -07:00
Aaron Dodson b5444b4e89 Migrate core/renderers/geras/path_object.js to goog.module syntax (#5306)
* Migrate core/renderers/geras/path_object.js to goog.module

* Migrate core/renderers/geras/path_object.js to named requires

* clang-format core/renderers/geras/path_object.js
2021-08-09 12:30:07 -07:00
Aaron Dodson 0ffdc6106d Migrate core/block_svg.js to goog.module syntax (#5323)
* Migrate core/block_svg.js to ES6 const/let

* Migrate core/block_svg.js to goog.module

* Migrate core/block_svg.js to named requires

* clang-format core/block_svg.js

* Migrate to goog.module.get for optional Comment/Warning in core/block_svg.js

* Lint changes in core/block_svg.js
2021-08-09 12:24:06 -07:00
kozbial b636c79ac0 Add description and reorder requires 2021-08-06 18:05:53 -07:00