* Move Menu + MenuItem out of /core/components to /core
Blockly.Menu and Blockly.MenuItem no longer depend on Blockly.Component and thus should not be in /core/component.
Also delete Blockly.utils.uiMenu in the process.
* Remove cargo-culted bloat from CSS
The `goog-menuitem-icon` and `goog-menuitem-noicon` classes are not present in Blockly. Blockly doesn’t support the CSS compiler, so #noflip has no effect. Shorten uncompressible warning string.
Also remove the “Copied from Closure” notes. These were intended so that the CSS could be easily updated as the Closure Library evolved. We are no longer linked to the Closure Library.
* Fix bug (in prod) where menu highlighting is lost
Previously, open playground. Right-click on workspace. Mouse-over “Add comment” (it highlights). Mouse over “Download screenshot” (disabled option). Mouse over “Add comment” (highlighting is lost).
Also remove `canHighlightItem` helper function. In theory this helps abstract the concept of non-highlightable options. But in practice it was only called in one of the several places that it should have been. This was a false abstraction.
* Add support for Space/PgUp/PgDn/Home/End to menus
* Eliminate calls to clearHighlighted
The JSDoc for `setHighlightedIndex` specifically states, “If another item was previously highlighted, it is un-highlighted.” This is not what was implemented, but it should be. This commit adds the un-highlighting, and removes all the calls previously required to correct this bug.
* Stop wrapping at top or bottom of menu.
Real OS menus don’t wrap when one cursors off the top or bottom.
Also, replace the overly complicated helper function with a simple 1/-1 step value.
* Remove unused menu code
* Simplify menu roles
Remove unneeded sets to RTL on Menu (only MenuItem cares).
* Fix lack of disposal for context menus.
Context menus only disposed properly when an option was clicked. If they were dismissed by clicking outside the menu there was no disposal. This might result in a memory leak.
Also un-extract (inject?) several now trivial functions.
* Remove Component dependency from Menu & MenuItem
Component is now only used by the category tree.
* Remove unused functions in Component
These were used by Menu/MenuItem.
* Fix dependencies.
* Record highlighted menu item by object, not index
Less code, simpler.
* Rename CSS classes goog-menu* to blocklyMenu*
Old classes remain in DOM and are deprecated so that any custom CSS will continue to function.
* Remove unused focus tracker in tree.
* Add support for space/enter to toggle tree cats
* Delete unsettable .isUserCollapsible_ from tree
* Change visibility tags throughout menus.
The previous tags were inherited from Closure and don’t reflect current usage in the Blockly codebase.
The core/components/tree files are non-compliant in this regard, but I’m not going to update them since they need to be replaced and there’s no need to create an interim API change.
* Remove property on DOM element linking to JS obj
Performance is slower (O(n) rather than (O(1)), but ’n’ is the number of entries on the menu, so shouldn’t be more than a dozen or so.
* Fixes a compile error (node != element)
Usually we avoid parentElement in Blockly. That’s because it has very spotty behaviour with SVG. But in this case we are in pure HTML.
* Google changed from an Inc to an LLC.
This happened back in 2017 but we didn’t notice. Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.
* Remove project description/titles from licenses
This is no longer part of Google’s header requirements. Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).
* License no longer requires URL.
* Fix license regexps.
Random improvements to require statements.
Removal of some obviously dead CSS.
.blocklyDropDownDiv no longer supresses text selection (see comment in PR).
This PR drops the compiled size by 4 KB, which is larger than I was expecting.
* Added Max Instances property to Blocks
* eslint cleanup
* eslint cleanup 2
* Moved maxInstances property from block to workspace (as a map of block type to max instances). isDuplicate() changed to correctly handle siblings/branches.
* eslint cleanup
* Changed checking types to map. Added hasBlockLimits. Fixed Nits.
* Added limit_instances test block. eslint fixes.
* fixup! Added limit_instances test block. eslint fixes.
* Changed sorting objects to a private static function of the workspace. Fixed nits. Undeleted .eslintrc
* Reverted .gitignore file.
* Added getBlockTypeCounts() to utils. Added isCapacityAvailable() to workspace. Changed clipboard to save typeCountsMap rather than object.
* Add skeleton for workspace comments
* XML parsing and encoding of workspace comments.
* Minor fix: piping the height and width from xml to newWorkspaceComment
* Move height and width into workspace_comment_svg
* rename newWorkspaceComment to newComment
* minor refactoring. PR changes
* Functions for managing the comment's lifecycle
* Add initial tests
* Add another test
* Add basic rendering of a comment.
* Cleanup remaining highlighting steps from render
* Fix lint
* Fix aslant
* Add basic comment translate
* Simplify render code into one setPath method
* Move steps to setPath_
* Remove svg elements when disposing of a comment; some code cleanup
* Add a workspace comment on context menu click and position it where the initial context menu was clicked.
* Minor rendering changes, fixes RTL. Fix positioning of new (context menu) comments while workspace is scaled.
* PR feedback
* Gesture code for dragging comments
* Add comment (block drag) surface methods
* minor comment fix
* Comment fixes
* Add comment dragger
* Making rendered private
* Require CommentDragger
* Make basic comment dragging work
* Increase the border around the comment to make a bigger drag handle
* Remove typo
* Allow comments to be selected. Highlight selected comment. Only edit comment on click. Updated comment rendering.
* minor refactor: remove commented out code
* PR comments
* lint and rebuild
* Fix renamed function call
* Fix workspace getMetrics by storing comment size as a number, not a string
* Enable comment deletion when dragging over the toolbox or trash can
* Give issue references to some todos
* Create a helper function for workspace comment creation
* Integrate sam's workspace comments, using the bubble dragger
* Remove comment_dragger references
* Remove comment dragger.js
* Remove pointer handling
* Fix lint
* Move comment XML functions into the comment files.
* Fix tests
* Fix type annotations
* Fix comments on comments
* Fix compiler errors related to visibility.
* Fix merge issues and add an issue number to a TODO
* Add a new message for default text on workspace comments, and rebuild
* Add support for a context menu on workspace comment showing delete and duplication options.
Add copy and paste support.
* PR comment feedback
* Show a delete icon on the comment when selected. Delete icon deletes the comment. Comment can be deleted if dragged onto the toolbox or the trash icon. A normal bubble cannot be deleted that way.
* use isDeletable instead
* Support drag of the comment during editing mode using the top handle.
* Add skeletons for all workspace comment events
* Rebuild with new comments
* Get rid of confused TODO
* JSDoc on a function
* Fix broken tests
* More PR feedback
* Fix lint
* Delete comment on mouse out, highlight on mouse down.
* Fix lint.
* Show delete hand cursor when dragging a comment to delete over the toolbox
* Focus textarea on select
* Add delete events
* Remove workspace comment create event, and add TODO placeholder
* Provide default values if comment height and width are missing in XML
* Set comment handle fill to none by default
* Rebuild
* Comment de/serialization should include location.
* Add comment move events, with undo and redo
* Add comment change events
* Move files up to core
* Add package/private annotations wherever possible
* Move the workspace comment events up to core and into a single file
* Mark things package or private where possible
* Get rid of unnecessary changes to messge files
* Fix lint
* Fix some review feedback
* Make changes to the comment db happen in addTopComment and removeTopComment
* Add css classes for toggling comment focus
* Clean up css for comment focus
* Rebuild
* New widget div functions, used in context menu code
* Make all widget div positioning functions use the same argument order
* Use new widget div functions for fields
* share code for measuring menu size
* Get rid of positionMenu
* Update copyright date
* Rebuild blockly_uncompressed because there's a new require in town
* Add block drag surface translateSurfaceBy
* Add dragged connection manager
* Add gesture.js
* Add GestureHandler
* Implemented gesture skeleton
* Most basic workspace dragging
* Add dragged connection manager
* cleanup
* doc
* more cleanup
* Add gesture handler
* Add translateSurfaceInternal
* core/block_dragger.js
* cleanup
* Pull in changes to dragged connection manager
* Pull in changes to dragged connection manager
* comments
* more annotations
* Add workspace dragger
* Add coordinate annotations
* Start on block dragging
* Limit number of concurrent gestures
* Add some TODOs
* start using dragged connection manager
* Set origin correctly for dragging blocks
* Connect or delete at the end of a block drag.
* cleanup
* handle field clicks and block + workspace right-clicks
* move code into BlockDragger class, but still reach into Gesture internals a lot
* Clean up block dragger
* Call blockDragger constructor with correct arguments
* Enable block dragging in a mutator workspace
* Add workspace dragger
* click todos
* Drag flyout with background
* more dragging from flyout
* nit
* fix dragging from flyouts
* Remove unused code and rename gestureHandler to gestureDB
* Rename gesture handler
* Added some jsdoc in gesture.js
* Update some docs
* Move some code to block_svg and clean up code
* Lots of coordinate annotations
* Fix block dragging when zoomed.
* Remove built files from branch
* More dragging work (#1026)
-- Drag bubbles while dragging blocks
-- Use bindEventWithChecks to work in touch on Android. Not tested anywhere else yet.
-- Handle dragging blocks while zoomed
-- Handle dragging blocks in mutators
-- Handle right-clicks (I hope)
-- Removed lots of unused code
* More dragging work (#1048)
- Removed gestureDB
- Removing uses of terminateDrag
- Cleaned up disposal code
* Dragging bugfixes (#1058)
- Get rid of flyout.dragMode_ and blockly.dragMode_
- Make drags from the flyout start from the top block in the group
- Block tooltips from being scheduled or shown during gestures
- Don't resize mutator bubbles mid-drag
* Fix events in new dragging (#1060)
* rebuild for testing
* unbuild
* Fix events
* rebuild
* Fix up cursors
* Use language files from develop
* Remove handled TODOS
* attempt to fix IE rerendering bug, and recalculate workspace positions on scroll
* Rebuild all the things
* Comment cleanup; annotations; delete unused variables.
