6d83b9bc28
Add keyword-spacing rule to eslint
2018-03-19 13:10:29 -07:00
3f77ceb823
Tighten line length rule from 120 to 100
2018-03-19 13:08:47 -07:00
701b187640
Fix #1699
2018-03-16 15:00:31 -07:00
6ff49fb3bf
Prevent fatal errors in browsers that don't support dataset.
2018-03-16 14:46:05 -07:00
554e644017
Don't compute (useless) location of trashcan while workspace is being built.
...
Theoretical performance bump, fixes crash in Opera 12.
2018-03-16 14:46:05 -07:00
b1e4648c3c
Use dataset instead of ID.
2018-03-16 14:46:05 -07:00
867dcdb716
Add IDs to bubbles.
2018-03-16 14:46:05 -07:00
81bc4674bc
Add hook for custom context menus on the workspace
2018-03-16 10:58:23 -07:00
70d782f24c
Merge pull request #1708 from rachel-fenichel/compiler_warnings
...
Warnings in drag surface classes
2018-03-15 14:45:16 -07:00
33d30f1907
Merge pull request #1707 from google/rachel-fenichel-patch-2
...
Get rid of variable redeclaration
2018-03-15 13:57:22 -07:00
f3107a49d0
Warnings in drag surface classes
2018-03-15 13:05:43 -07:00
8de5b3ee9f
Get rid of variable redeclaration
2018-03-15 13:04:09 -07:00
d1d60eb62a
Make undoStack_ and redoStack_ protected
2018-03-15 13:02:12 -07:00
d4c3835a5e
Fix more compiler warnings
2018-03-14 17:37:32 -07:00
90a3730424
Fix more compiler warnings
2018-03-14 17:05:19 -07:00
40bb0d1221
Merge pull request #1687 from samelhusseini/develop_pointerfixes
...
Pointer Event fixes
2018-03-12 15:04:50 -07:00
c7b29d0bc0
Expose block ID in SVG. ( #1698 )
2018-03-12 14:04:03 -07:00
dc2ab1bbed
Update css.js
2018-03-09 15:41:50 -08:00
580ef211d7
Fixed to touch gesture
2018-03-06 11:03:04 -08:00
6326830e85
Don't handle a touch gesture event if the gesture has been cancelled.
2018-03-05 09:50:38 -08:00
fda7122b86
Fix lint
2018-03-02 16:00:30 -08:00
8d9dad8898
Remove unnecessary code, better styling.
2018-03-02 15:33:44 -08:00
b32dbcdb94
Pointer Event fixes ensuring they replace all mouse events, and fix comment focusing issue.
2018-03-02 15:01:58 -08:00
7ea0e1b8c3
Merge pull request #1680 from google/rachel-fenichel-patch-1
...
Mark bindEvent_ and bindEventWithChecks_ package instead of private
2018-03-02 13:51:21 -08:00
a9a696117b
Merge pull request #1683 from google/rachel-fenichel-patch-3
...
Make getEventWorkspace_ protected.
2018-03-02 13:51:00 -08:00
e22923df75
Make getEventWorkspace_ protected.
...
Fixes 12 warnings
2018-03-01 18:32:15 -08:00
a5db01559f
Mark unbindEvent_ package instead of private
...
Fixes ~20 compiler warnings.
2018-03-01 18:15:37 -08:00
7356c664a0
Merge pull request #1614 from rachel-fenichel/bugfix/double_events
...
Don't register mouse events if pointer events are supported
2018-03-01 18:04:51 -08:00
5920e6aa39
Mark bindEvent_ and bindEventWithChecks_ package instead of private
...
Fixes 50 compiler warnings.
2018-03-01 17:56:49 -08:00
6565b2103b
Merge pull request #1672 from rachel-fenichel/split_event_files
...
Split event files
2018-03-01 13:15:53 -08:00
870813747a
Fix misspelled annotation.
2018-03-01 13:01:44 -08:00
615c403b44
Use @nocompress annotation to fix advanced compilation.
2018-03-01 12:35:55 -08:00
4c9b602523
Move event classes into separate files, and update requires accordingly
2018-02-27 17:47:33 -08:00
2f55c0c2be
move events.js into an events folder inside core
2018-02-27 17:22:01 -08:00
10dbf2cc6d
Random typos.
...
@rachel-fenichel LGTMs in person.
2018-02-21 17:47:01 -08:00
9cd6b1ec24
Print a warning if JSON color value is invalid. ( #1639 )
...
Ignores the invalid color, defaulting to black.
2018-02-21 13:55:32 -08:00
e3700c02e4
Merge pull request #1651 from AnmAtAnm/rm-todos-in-docs
...
Moving TODO from doc comment to single line comment.
2018-02-21 11:06:31 -08:00
13cb64392f
Fix some JsDoc annotations ( #1650 )
2018-02-21 11:01:01 -08:00
91e2d03eea
Moving TODO from doc comment to single line comment.
2018-02-21 10:58:52 -08:00
f45c6faf05
Fix #1619 . buildTooltipWithFieldValue() => buildTooltipWithFieldText() ( #1638 )
...
Fix #1619 . buildTooltipWithFieldValue() => buildTooltipWithFieldText()
The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
2018-02-16 16:51:18 -08:00
8c8412af74
Just check whether the window exists, instead of using goog.events.BroswerFeature
2018-02-16 15:01:13 -08:00
f3a4664dea
Delete extra variables at the end of a procedure argument edit
2018-02-15 17:18:23 -08:00
e5a2ef30f2
Switch to goog.events.BrowserFeature.POINTER_EVENTS
2018-02-15 11:26:06 -08:00
73417b8317
Reduce size of XML by omitting empty variable tag.
2018-02-14 11:22:55 -08:00
2a00055e57
Don't register mouse events if pointer events are supported
2018-02-14 10:42:27 -08:00
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
e1e3f273d2
Remove forceRerender() from FieldDropDown.
...
Errantly forced whole block to rerender, including fields that
had not yet been initialized.
Fixes #1609
2018-02-13 15:01:33 -08:00
5e0928e4f3
Break circular dependency
2018-02-13 10:44:07 -08:00
3463799d83
Merge pull request #1599 from rachel-fenichel/bugfix/sb-1373
...
Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace
2018-02-12 14:43:40 -08:00
dc7783ee01
Warn conflicts with Blockly.Generator.prototype ( #1603 )
...
Console warning if block prototypeName conflicts with Blockly.Generator.prototype.
2018-02-12 13:44:54 -08:00
Rachel Fenichel
Neil Fraser
Neil Fraser
Sam El-Husseini
Sam El-Husseini
Andrew n marshall
Mark Gibson