10dbf2cc6d
Random typos.
...
@rachel-fenichel LGTMs in person.
2018-02-21 17:47:01 -08:00
9cd6b1ec24
Print a warning if JSON color value is invalid. ( #1639 )
...
Ignores the invalid color, defaulting to black.
2018-02-21 13:55:32 -08:00
e3700c02e4
Merge pull request #1651 from AnmAtAnm/rm-todos-in-docs
...
Moving TODO from doc comment to single line comment.
2018-02-21 11:06:31 -08:00
13cb64392f
Fix some JsDoc annotations ( #1650 )
2018-02-21 11:01:01 -08:00
91e2d03eea
Moving TODO from doc comment to single line comment.
2018-02-21 10:58:52 -08:00
f45c6faf05
Fix #1619 . buildTooltipWithFieldValue() => buildTooltipWithFieldText() ( #1638 )
...
Fix #1619 . buildTooltipWithFieldValue() => buildTooltipWithFieldText()
The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
2018-02-16 16:51:18 -08:00
f3a4664dea
Delete extra variables at the end of a procedure argument edit
2018-02-15 17:18:23 -08:00
73417b8317
Reduce size of XML by omitting empty variable tag.
2018-02-14 11:22:55 -08:00
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
e1e3f273d2
Remove forceRerender() from FieldDropDown.
...
Errantly forced whole block to rerender, including fields that
had not yet been initialized.
Fixes #1609
2018-02-13 15:01:33 -08:00
5e0928e4f3
Break circular dependency
2018-02-13 10:44:07 -08:00
3463799d83
Merge pull request #1599 from rachel-fenichel/bugfix/sb-1373
...
Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace
2018-02-12 14:43:40 -08:00
dc7783ee01
Warn conflicts with Blockly.Generator.prototype ( #1603 )
...
Console warning if block prototypeName conflicts with Blockly.Generator.prototype.
2018-02-12 13:44:54 -08:00
f471a23b2b
Add comment
2018-02-12 13:25:07 -08:00
57852f0249
Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace.
2018-02-08 17:23:22 -08:00
6a018515af
Make WorkspaceSvg.refreshToolboxSelection_ package instead of private
2018-02-08 16:45:19 -08:00
e58c8a32d4
Merge pull request #1590 from rachel-fenichel/feature/bubble_dragger
...
Create a Dragger for moving bubbles around
2018-02-07 14:19:23 -08:00
2308ae8c22
Remove underscore from fromJson_
2018-02-07 18:18:35 +00:00
6ab7cd25f5
Missing semi-colon!
2018-02-07 12:44:01 +00:00
d40ef474ae
See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers
2018-02-07 12:22:26 +00:00
9d2cb829a9
Move code into the bubble dragger where possible
2018-02-06 18:56:26 -08:00
7acd4133aa
Remove unused code in the bubble dragger.
2018-02-06 18:07:21 -08:00
68914be67d
Wire up bubble dragging, with coordinate problems
2018-02-05 16:57:44 -08:00
3b168f5370
Fix #1538
2018-01-26 15:20:19 -08:00
870219e750
Get rid of the last indentation lint (that is checked by eslint) and turn indentation back to erroring instead of warning.
2018-01-25 17:33:43 -08:00
f19d7a811c
Merge pull request #1562 from rachel-fenichel/bugfix/matching_names
...
Fix #1559
2018-01-25 17:08:46 -08:00
68ff863ea9
Fix indentation
2018-01-25 13:00:08 -08:00
cb75946a3c
Set indent problems to warnings, and fix all errors.
2018-01-25 12:43:11 -08:00
794520e225
Add documentation
2018-01-24 17:17:31 -08:00
96e2d7d102
Fix #1559
2018-01-24 17:05:58 -08:00
c6881677ad
Merge pull request #1561 from rachel-fenichel/cleanup/lint
...
Indentation lint that blocks moving to eslint 4.0
2018-01-24 16:48:18 -08:00
2b7b4bf3af
More lint
2018-01-24 16:40:07 -08:00
3e62ffc20a
Split at higher level for multiline function calls
2018-01-24 11:26:41 -08:00
799148da7e
More spaces
2018-01-24 10:22:13 -08:00
36993430e1
createVariable(..) => createVariableButtonHandler(..)
...
Clarifying the role of Blockly.Variables.createVariableButtonHandler(..).
Updating documentation a making sure it (and its deprecated previous name)
are properly exported.
2018-01-24 09:54:21 -08:00
3575d53018
57 errors remaining
2018-01-23 18:42:45 -08:00
fb897d7786
Even more lint. 90 errors remaining.
2018-01-23 18:33:30 -08:00
9a53e96d53
More lint fixes
2018-01-23 18:22:53 -08:00
1e3450a051
Indentation lint that blocks moving to eslint 4.0
2018-01-23 17:27:35 -08:00
e61b51afcb
Merge pull request #1546 from rachel-fenichel/bugfix/1499
...
Fix #1499 and add some validation
2018-01-22 17:54:11 -08:00
06ae9ade8e
Don't update the field until all checks pass
2018-01-19 15:49:39 -08:00
0d085c27b2
Removing Events.disable()/.enable() from disableOrphans.
...
Tested in Blockly Games and BlockFactory. Tests also pass.
2018-01-19 10:40:18 -08:00
e648f11e2d
Make another function public
2018-01-18 15:59:26 -08:00
5cd6a51197
Make some functions public
2018-01-18 15:35:59 -08:00
7314bdfb3a
Fix #1499 and add some validation
2018-01-17 16:54:12 -08:00
68cee9da42
Fix #1539
2018-01-17 11:19:38 -08:00
3f61f71f35
Merge pull request #1531 from google/variables_by_id
...
Variables by ID
2018-01-16 17:54:55 -08:00
fa91c6b36f
Make some functions package
2018-01-16 12:41:52 -08:00
b593d44379
Make the potential variable map null when not needed
2018-01-12 14:51:02 -08:00
a30ad6ff3a
More code cleanup for review
2018-01-12 13:28:17 -08:00
Neil Fraser
Andrew n marshall
Rachel Fenichel
Mark Gibson