Commit Graph

188 Commits

Author SHA1 Message Date
Sam El-Husseini
6bd6bdefbc Upgrade closure + support for closure-library dependency (#3554)
* Upgrade closure and include hints on how to include the closure library in the build.

* Revert build-uncomprssed.

* Sort uncompressed.

* nit: comment.
2020-01-14 12:59:43 -08:00
Sam El-Husseini
20e55b67d7 Fix bug with dropdown menu propagating the opening click event to a menu item (#3570)
* Prevent dropdown field menu from propagating a click event onto a menu item when the dropdown appears above the field
2020-01-09 18:08:29 -08:00
Sam El-Husseini
8d6ff39e64 [zelos] Support dropdown fields with no border rect (#3547)
* Dropdown fields without a border rect.
2020-01-06 13:16:59 -08:00
Sam El-Husseini
06c714d13b Fix dropdown field alignment in zelos when baseline is not centered (IE / Edge) (#3534) 2020-01-02 14:36:06 -08:00
Sam El-Husseini
63f7af115c [zelos] Set field rect background colour (#3500)
* More consistent field rect colour in zelos. Only overriding in full block fields. Fix disabled block colours.

* Use a better constant name and fix build.
2019-12-10 08:31:43 -08:00
Sam El-Husseini
b038c1cef5 [zelos] Set dropdown div colour to match block colour (#3462)
* Set dropdown div colour to match block colour
2019-11-27 09:30:29 -08:00
Sam El-Husseini
c868a86bdd Field dropdown with an SVG arrow (#3442)
* Add SVG arrow as an option on the dropdown field
2019-11-14 15:00:49 -08:00
Sam El-Husseini
2dea7038d5 Moves field layout constants into the renderer (#3437)
* Add field constants into renderer constants
2019-11-13 16:41:35 -08:00
Sam El-Husseini
95f2b232b9 Field constants (#3423)
* Move field text sizing constants to renderer constants
2019-11-11 16:13:50 -08:00
Sam El-Husseini
ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Neil Fraser
123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Rachel Fenichel
5ef08fc0d4 Switch to using the style object in the path object. 2019-10-30 14:47:23 -07:00
Rachel Fenichel
ca1e49bf8e Fields now go through blockSvg for colours. 2019-10-30 14:43:42 -07:00
Rachel Fenichel
6f520335ea Cleanup of colouring code, and move it into path_object. 2019-10-30 14:42:13 -07:00
Rachel Fenichel
85c4db5a10 First pass at colourers 2019-10-30 14:42:13 -07:00
Sam El-Husseini
649dc116ed Using a HTML canvas for computing the text width (#3000)
* Use a helper HTML canvas element to measure text width for better performance
2019-10-24 13:02:32 -04:00
Neil Fraser
013f2714a3 Cleanup aria usage. (#3261)
Use enums instead of arbitrary strings.
Delete unused Aria properties
Add missing requires.
Delete unused code.
2019-10-15 22:43:23 -07:00
Sam El-Husseini
2224bb2a4e More field dispose (#3201)
* Dispose of element references in fields.
* Fewer warnings
2019-10-15 17:56:53 -05:00
Beka Westberg
f4f9a67903 Fixed field editor disposal (#3109)
* Fixed field editor disposal.
2019-10-08 16:48:31 -07:00
Sam El-Husseini
d0772ad496 Fix compiler warnings related to fields. (#3144)
* Fix compiler warnings related to fields.
2019-10-03 15:58:46 -07:00
Sam El-Husseini
fba98fca5b Move the dropdown field into the dropdown div. (#3122)
* Move the dropdown field into the dropdown div.
2019-10-03 14:35:28 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Neil Fraser
76af463ec4 Removing require for Blockly.FlyoutButton
Should have been in the previous PR, since that’s the point.

Also, a recompile given all the recent dependency changes.
2019-09-24 12:15:03 -07:00
Beka Westberg
593383e18a Changed variable field to use configuration (#3065)
* Changed variable field to use new configuration.
2019-09-23 11:14:03 -07:00
alschmiedt
c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00
Sam El-Husseini
9318c370f9 Handle blockly actions on the dropdown fields. (#3064)
* Handle blockly actions on the dropdown fields.
2019-09-20 15:07:35 -07:00
Beka Westberg
e053084621 Changed dropdown field to use new configuration. (#3061) 2019-09-20 13:35:13 -07:00
Sam El-Husseini
c524980f31 Cache dynamic dropdown options (#3036)
* Cache dynamic dropdown options and only re-generate on initialization and render.
2019-09-18 13:05:25 -07:00
Sam El-Husseini
f3f3329355 Fix configure method (#2915)
* Fix configure method.
2019-09-12 17:01:03 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini
f23b659898 Remove this.text_ (#2910)
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
mirandago
d9d234363c Dropdown scrolls to selected element (#2897)
* Dropdown scrolls to selected element
2019-08-26 10:23:41 -07:00
Sam El-Husseini
ff76ee5b0d Dropdown field with Blockly.Menu (#2832)
* Switch dropdown field from using goog.ui.Menu to Blockly.Menu
2019-08-16 18:22:05 -07:00
Beka Westberg
0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg
84937a0ff6 Fixed lint error. 2019-08-16 09:57:27 -07:00
Beka Westberg
cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Rachel Fenichel
ed245a3c9e Remove dealWithOffsetFields 2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70 Cleanup and comments 2019-08-06 11:03:53 -07:00
Rachel Fenichel
3802a0c960 Remove getCorrectedSize for fields 2019-08-05 16:01:50 -07:00
Rachel Fenichel
16f0992764 Enable operator-linebreak rule 2019-07-31 09:45:27 -07:00
Neil Fraser
45e5fb4157 More JSDoc and lint corrections 2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83 Remove all calls to goog.math (#2739)
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Neil Fraser
84f5afd0e3 Typo: enutral -> neutral 2019-07-25 11:32:02 -07:00
Rachel Fenichel
fc4372dbc2 Add TODOs with github issue number 2019-07-22 16:29:44 -07:00
Rachel Fenichel
f469a388ed Add getCorrectedSize functions to fields 2019-07-17 11:00:20 -07:00
Beka Westberg
b98eef2ae2 Fixed rendering of images & text dropdown. 2019-06-24 10:20:26 -07:00
Beka Westberg
6f69b85639 Removed unnecessary todo's. 2019-06-11 14:24:48 -07:00
Beka Westberg
4b0397de17 Cleaned up utils renamings. Readded widget div hide in field angle. 2019-06-11 13:48:01 -07:00
Beka Westberg
303115953e Moved to #2125 disposal. Cleaned up some doc. 2019-06-11 13:32:09 -07:00
Beka Westberg
0122f36450 Fixed field disposal, and reorganized editor creation. 2019-06-11 13:30:50 -07:00