Commit Graph

100 Commits

Author SHA1 Message Date
Aaron Dodson
edc2a5cd0c fix: Fix compilation errors under Closure's strict mode (#6073)
* fix: Fix errors under strict compilation.

* fix: Fix tests that referenced properties converted to data attributes.

* fix: Incorporate feedback on resolving compiler errors.

* refactor: Revert changes to skew and translate attributes.

* refactor: Introduce LegacyContextMenuOption type to correspond to documented fields.

* refactor: Introduce PathLeftShape and PathDownShape vs casting to PuzzleTab/Notch.

* chore: Added nullability modifiers to type annotations.

* refactor: Export FlyoutItem directly.

* chore: clang-format renderers/zelos/drawer.js.
2022-04-19 14:17:17 -07:00
Aaron Dodson
1647a3299a fix: Move @alias onto classes instead of constructors (#6003)
* fix: Move @alias onto classes instead of constructors

* fix: Fix JSDoc for constructors.
2022-03-16 15:48:32 -07:00
Beka Westberg
237e66cf29 refactor: convert row.js and base.js to ES6 classes (#5957)
* fix: remove unnecessary properties from rows

* refactor: run conversion script on measurables

* clean: cleanup from conversion

* fix: make debug build happy

* clean: format

* fix: remove widthWithConnectedBlocks assignment on element

* fix: add inline docs for statementEdge
2022-02-25 11:06:12 -08:00
Rachel Fenichel
97c19be612 refactor: convert renderer measurables to es6 classes (#5899)
* chore: use casts to narrow types in renderers

* chore: add @struct and type information on common measurables

* refactor: update some renderer measurables to es6 classes

* refactor: convert many measurables to es6 classes

* chore: format

* chore: rebuild
2022-02-01 15:43:11 -08:00
alschmiedt
0f3c06306f chore: runs clang format on all files (#5627) 2021-10-21 15:22:24 -07:00
Rachel Fenichel
e8d6f7f408 chore: auto-fix violations of comma-dangle rule (#5625) 2021-10-21 09:01:51 -07:00
Aaron Dodson
3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser
90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser
c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Monica Kozbial
49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial
d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Aaron Dodson
6b07ccab96 chore: Remove declareLegacyNamespace from renderers (#5528)
* chore: Remove declareLegacyNamespace from Geras renderer

* chore: Remove declareLegacyNamespace from minimalist renderer

* chore: Remove declareLegacyNamespace from thrasos renderer

* chore: Remove declareLegacyNamespace from zelos renderer

* fix: Move debugger functionality out of Blockly.blockRendering to avoid dependency cycle when re-exporting submodules

* chore: Remove declareLegacyNamespace from Blockly.blockRendering.*
2021-09-24 08:33:35 -07:00
Rachel Fenichel
3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
kozbial
d30b0f5f3c clang-formant core/renderers/measurables/connections.js 2021-08-17 12:41:28 -07:00
kozbial
673c64dab8 Migrate core/renderers/measurables/connections.js named requires 2021-08-17 12:41:28 -07:00
kozbial
974c73f0b9 Migrate core/renderers/measurables/connections.js to goog.module 2021-08-17 12:41:28 -07:00
kozbial
d50247664a Split classes from core/renderers/measurables/connections.js into multiple files 2021-08-17 12:41:28 -07:00
kozbial
a9d4adcbf0 Remove unused variables in core/renderers/measurables/top_row.js 2021-08-17 09:41:32 -07:00
kozbial
ec04c9ca36 Fix jsdoc in core/renderers/measurables/bottom_row.js 2021-08-17 09:41:32 -07:00
kozbial
57d6c40061 clang-format core/renderers/measurables/rows.js 2021-08-17 09:41:32 -07:00
kozbial
c56da8c93a Migrate core/renderers/measurables/rows.js named requires 2021-08-17 09:41:32 -07:00
kozbial
5038907c67 Migrate core/renderers/measurables/rows.js 2021-08-17 09:41:32 -07:00
kozbial
6bf554643a Migrate core/renderers/measurables/rows.js to goog.module 2021-08-17 09:41:32 -07:00
kozbial
11f4479faf Split classes from core/renderers/measurables/rows.js into multiple files 2021-08-17 09:41:32 -07:00
Aaron Dodson
dbe7aaa8c8 Migrate core/renderers/measurables/row_elements.js to goog.module syntax (#5381)
* Split provides in core/renderers/measurables/row_elements.js into individual files

* Migrate core/renderers/measurables/row_elements.js to ES6 const/let

* Migrate core/renderers/measurables/row_elements.js to goog.module

* Migrate core/renderers/measurables/row_elements.js to named requires

* clang-format core/renderers/measurables/row_elements.js
2021-08-16 15:54:11 -07:00
kozbial
88a7779cb2 clang-format core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
kozbial
35cf6482e3 Migrate core/renderers/measurables/inputs.js named requires 2021-08-11 13:49:50 -07:00
kozbial
59dee77fa8 Migrate core/renderers/measurables/inputs.js to goog.module 2021-08-11 13:49:50 -07:00
kozbial
3081c40a02 Migrate core/renderers/measurables/input_connection.js to ES6 const/let 2021-08-11 13:49:50 -07:00
kozbial
09573bcf16 Split classes from core/renderers/measurables/inputs.js 2021-08-11 13:49:50 -07:00
Aaron Dodson
18283e816f Migrate core/renderers/measurables/base.js to goog.module syntax (#5308)
* Migrate core/renderers/measurables/base.js to goog.module

* Migrate core/renderers/measurables/base.js to named requires
2021-08-11 08:11:44 -07:00
Aaron Dodson
2b6d275440 Migrate core/renderers/measurables/types.js to goog.module syntax (#5309)
* Migrate core/renderers/measurables/types.js to goog.module

* Migrate core/renderers/measurables/types.js to named requires

* clang-format core/renderers/measurables/types.js
2021-08-05 13:57:16 -07:00
Neil Fraser
d919b0af21 Update JSDoc from Array.<> to Array<>
Same with Object.
2021-05-27 21:30:26 -07:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Rachel Fenichel
9ce06fb7d3 Add missing requireTypes for core/renderers/measurables 2021-02-02 11:38:08 -08:00
Rachel Fenichel
0951b5e613 Update eslintrc for eslint v7, and resolve new lint errors 2020-08-10 15:10:48 -07:00
Monica Kozbial
a9223b0b22 Typo fixes. (#3769) 2020-03-25 15:47:27 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
8475976103 Fix start hats (#3651) 2020-01-24 13:02:27 -08:00
Monica Kozbial
fdb1d71e88 Editable field spacing (#3635)
* Substituting checks for isEditable.

* Add isField checks.

* Add parentheses for casting.

* Update value of isEditable and use for spacing.

* Changing to double equals.
2020-01-23 13:10:33 -08:00
Sam El-Husseini
1661d640d6 Geras inline alignment of rows + max bottom row width (#3575)
* Add a desired width getter method for input rows. Override in geras to fix the width of the bottom row and statement input to a max width.
2020-01-13 10:40:52 -08:00
Sam El-Husseini
fe555d9021 Rename input connection to connectionModel (#3571)
* Remove input measurable's connection property and rename references to connectionModel.
2020-01-09 18:09:15 -08:00
Monica Kozbial
26db9167db Move of render contant START_HAT into ConstantProvider. (#3563)
* Move of render contant START_HAT into ConstantProvider.
2020-01-07 16:18:05 -08:00
Sam El-Husseini
3d66eab311 [zelos] Output connection position (#3516)
* Move connection point for output connections to the left and centerline
2019-12-16 14:06:10 -08:00
Sam El-Husseini
adc06cc544 [zelos] Add extra offset for statement input to account for right corner width (#3508)
* Add additional offset to the statement input in zelos to account for the width of right corner.

* inside corners
2019-12-11 17:00:22 -08:00
Sam El-Husseini
4eb791bd70 [zelos] Add right connection shape element. (#3488)
* Add right connection shape element
2019-12-05 17:51:39 -08:00
Sam El-Husseini
ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Sam El-Husseini
337cb9c486 Fix path_object inheritance (#3403)
* Fix path_object inheritance, add zelos path_object
2019-11-05 16:36:30 -08:00
Neil Fraser
22c1eba546 Make warnings an optional module. 2019-11-01 11:52:12 -07:00
Sam El-Husseini
7d174727b0 Fix warnings for code used by blocks (#3362) 2019-10-30 08:11:18 -07:00