Commit Graph

199 Commits

Author SHA1 Message Date
Rachel Fenichel
daf78af13e fix!: fix or silence type errors (#6105)
* fix: add isBlockCreatable to IFlyout interface

* fix: add getClickTarget to IToolboxItem interface

* fix: fix some types in zelos renderer

* fix: add scrollToStart to IFlyout interface

* fix: add setVisible_ to IToolboxItem

* fix: use instanceof check for workspace comments in gesture code

* fix: data stored on the DOM for tooltips

* fix: use blockSvg to access icons

* fix: add instanceof check in shortcut_items.js

* fix: suppress warning about onKeyDown in tolbox

* fix: add instanceof check in workspace_svg

* fix: don't use dot accessor to avoid type problem

* fix: silence type errors in ast_node.js
2022-04-22 15:55:55 -07:00
Aaron Dodson
edc2a5cd0c fix: Fix compilation errors under Closure's strict mode (#6073)
* fix: Fix errors under strict compilation.

* fix: Fix tests that referenced properties converted to data attributes.

* fix: Incorporate feedback on resolving compiler errors.

* refactor: Revert changes to skew and translate attributes.

* refactor: Introduce LegacyContextMenuOption type to correspond to documented fields.

* refactor: Introduce PathLeftShape and PathDownShape vs casting to PuzzleTab/Notch.

* chore: Added nullability modifiers to type annotations.

* refactor: Export FlyoutItem directly.

* chore: clang-format renderers/zelos/drawer.js.
2022-04-19 14:17:17 -07:00
Aaron Dodson
1647a3299a fix: Move @alias onto classes instead of constructors (#6003)
* fix: Move @alias onto classes instead of constructors

* fix: Fix JSDoc for constructors.
2022-03-16 15:48:32 -07:00
Beka Westberg
237e66cf29 refactor: convert row.js and base.js to ES6 classes (#5957)
* fix: remove unnecessary properties from rows

* refactor: run conversion script on measurables

* clean: cleanup from conversion

* fix: make debug build happy

* clean: format

* fix: remove widthWithConnectedBlocks assignment on element

* fix: add inline docs for statementEdge
2022-02-25 11:06:12 -08:00
Beka Westberg
7e221c20de refactor: convert PathObject to an ES6 class (#5954)
* refactor: add super call to geras path_object

* refactor: run conversion script

* clean: cleanup from conversion script

* fix: make debug build happy

* clean: add clarifying comment

* clean: format
2022-02-23 14:12:32 -08:00
Rachel Fenichel
4cf1a5c886 refactor: convert some files to es classes (#5913)
* refactor: update workspace_comment and _svg to es classes

* refactor: update classes that extend icon to es classes

* refactor: update icon to es6 class

* refactor: update connection classes to es6 classes and add casts as needed

* refactor: update scrollbar to es6 class and add casts as needed

* refactor: update workspace_svg to es6 class

* refactor: update several files to es6 classes

* refactor: update several files to es6 classes

* refactor: update renderers/common/info.js to es6 class

* refactor: update several files to es6 classes

* chore: rebuild deps.js

* chore: run format
2022-02-04 10:58:22 -08:00
Rachel Fenichel
97c19be612 refactor: convert renderer measurables to es6 classes (#5899)
* chore: use casts to narrow types in renderers

* chore: add @struct and type information on common measurables

* refactor: update some renderer measurables to es6 classes

* refactor: convert many measurables to es6 classes

* chore: format

* chore: rebuild
2022-02-01 15:43:11 -08:00
Rachel Fenichel
f5caf964aa refactor: convert renderer classes to es6 classes (#5874)
* refactor: convert zelos renderer classes to es6 classes

* refactor: convert zelos measurables to es6 classes

* refactor: convert thrasos classes to es6 classes

* refactor: convert minimalist classes to es6 classes

* refactor: update geras classes to es6 classes

* chore: rebuild and format

* chore: fix indentation in comments
2022-01-14 12:43:13 -08:00
Christopher Allen
c0d22f2002 refactor: Rename ALIGN to Align and move from constants.js to input.js (#5742)
This constant is used to specify the alignment of
an Input, so it should live in the same file as the Input class.

I've done this as a separate named export, but it could alternatively
be made a static member of Input (i.e., Input.Align with only Input
being exported by name).

Where mocha tests were referring to Blockly.constants.ALIGN.*
without actually requiring Blockly.constants, I have reverted
them to refer to Blockly.ALIGN_* instead (pending conversion
to named requries).

Part of #5073.
2021-11-29 21:59:48 +00:00
Rachel Fenichel
f14a1c8034 chore: fix more lint (#5676)
* chore: fix assorted lint

* chore: clang-format

* chore: clang-format
2021-11-08 16:41:52 -08:00
yang
bc7329f34a fix(zelos): typo (#5649) 2021-10-31 23:21:15 -07:00
alschmiedt
0f3c06306f chore: runs clang format on all files (#5627) 2021-10-21 15:22:24 -07:00
Rachel Fenichel
e8d6f7f408 chore: auto-fix violations of comma-dangle rule (#5625) 2021-10-21 09:01:51 -07:00
Aaron Dodson
3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser
90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Neil Fraser
c929b3015b chore: Convert == to === and != to !== where possible. (#5599) 2021-10-15 09:17:04 -07:00
Monica Kozbial
49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial
d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Christopher Allen
8ab8536739 refactor: Migrate Blockly.ConnectionType to named exports (#5533)
* refactor: Migrate Blockly.ConnectionType to named exports
* Add corresponding information to renamings.js
2021-09-24 17:38:08 +01:00
Aaron Dodson
6b07ccab96 chore: Remove declareLegacyNamespace from renderers (#5528)
* chore: Remove declareLegacyNamespace from Geras renderer

* chore: Remove declareLegacyNamespace from minimalist renderer

* chore: Remove declareLegacyNamespace from thrasos renderer

* chore: Remove declareLegacyNamespace from zelos renderer

* fix: Move debugger functionality out of Blockly.blockRendering to avoid dependency cycle when re-exporting submodules

* chore: Remove declareLegacyNamespace from Blockly.blockRendering.*
2021-09-24 08:33:35 -07:00
Himanshu
3629ed5f65 refactor: Rename Blockly.connectionTypes to Blockly.ConnectionType (#5407)
* Renamed Blockly.connectionTypes to Blockly.ConnectionType
* Renamed core/connection_types.js to connection_type.js
* Add entry to renamings.js for renaming of Blockly.connectionTypes

Co-authored-by: Christopher Allen <cpcallen+git@google.com>
2021-09-24 12:45:10 +01:00
kozbial
61a0773427 Merge branch 'goog_module' into merge-develop-to-goog_module 2021-09-22 13:27:33 -07:00
alschmiedt
73580b0ddb chore: named exports for keyboard_nav* files (#5517) 2021-09-22 11:25:38 -07:00
kozbial
900dfc7c68 Remove references to fully qualified namespace 2021-09-22 09:37:47 -07:00
kozbial
fd251dae22 Merge branch 'goog_module' into merge-develop-to-goog_module 2021-09-22 09:27:52 -07:00
Rachel Fenichel
3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
kozbial
6fc90213a6 Merge branch 'develop' into merge-develop-to-goog_module 2021-09-21 16:04:33 -07:00
kozbial
5dd4e1ed50 Cleanup in core/renderers/zelos/measurables/inputs.js 2021-08-19 10:40:53 -07:00
kozbial
810e1e19a5 clang-format core/renderers/zelos/measurables/inputs.js 2021-08-19 10:40:53 -07:00
kozbial
a6271bb3d5 Migrate core/renderers/zelos/measurables/inputs.js named requires 2021-08-19 10:40:53 -07:00
kozbial
40474324f6 Migrate core/renderers/zelos/measurables/inputs.js to goog.module 2021-08-19 10:40:53 -07:00
kozbial
57644d1e29 Migrate core/renderers/zelos/measurables/inputs.js to ES6 const/let 2021-08-19 10:40:53 -07:00
kozbial
26802bcb7f clang-format core/renderers/zelos/measurables/rows.js 2021-08-19 09:35:26 -07:00
kozbial
297f2a0b60 Migrate core/renderers/zelos/measurables/rows.js named requires 2021-08-19 09:35:26 -07:00
kozbial
c85714b1c6 Migrate core/renderers/zelos/measurables/rows.js to goog.module 2021-08-19 09:35:26 -07:00
kozbial
ede4d3630b Migrate core/renderers/zelos/measurables/rows.js to ES6 const/let 2021-08-19 09:35:26 -07:00
kozbial
3e1099e2b8 Split classes from core/renderers/zelos/measurables/rows.js into multiple files 2021-08-19 09:35:26 -07:00
kozbial
bcfca5c198 clang-format core/renderers/zelos/measurables/row_elements.js 2021-08-18 15:57:53 -07:00
kozbial
b69800623b Migrate core/renderers/zelos/measurables/row_elements.js named requires 2021-08-18 15:57:53 -07:00
kozbial
d37df416e1 Migrate core/renderers/zelos/measurables/row_elements.js to goog.module 2021-08-18 15:57:53 -07:00
kozbial
72bbd3fa69 clang-format core/renderers/zelos/renderer.js 2021-08-18 09:43:17 -07:00
kozbial
9bfbd09a22 Migrate core/renderers/zelos/renderer.js named requires 2021-08-18 09:43:17 -07:00
kozbial
2ea51db549 Migrate core/renderers/zelos/renderer.js to goog.module 2021-08-18 09:43:17 -07:00
kozbial
e75a50b8b9 clang-format core/renderers/zelos/path_object.js 2021-08-17 12:31:31 -07:00
kozbial
07ddf67aa9 Migrate core/renderers/zelos/path_object.js named requires 2021-08-17 12:31:31 -07:00
kozbial
d6eb6c14ef Migrate core/renderers/zelos/path_object.js to goog.module 2021-08-17 12:31:31 -07:00
kozbial
b4b8b22994 Migrate core/renderers/zelos/path_object.js to ES6 const/let 2021-08-17 12:31:31 -07:00
hpnrep6
2a9ef4f0f0 fix: blocks with no next connections overlapping statement input in Zelos (#5369)
* Use zelos' StatementInput function in addInput_

* Add align check to addInput_
2021-08-13 17:32:26 -07:00
kozbial
012bb89986 Revert clang-format on comment in core/renderers/zelos/marker_svg.js 2021-08-12 17:04:18 -07:00
kozbial
08626a689a clang-format core/renderers/zelos/marker_svg.js 2021-08-12 17:04:18 -07:00