Commit Graph

41 Commits

Author SHA1 Message Date
Rachel Fenichel
daf78af13e fix!: fix or silence type errors (#6105)
* fix: add isBlockCreatable to IFlyout interface

* fix: add getClickTarget to IToolboxItem interface

* fix: fix some types in zelos renderer

* fix: add scrollToStart to IFlyout interface

* fix: add setVisible_ to IToolboxItem

* fix: use instanceof check for workspace comments in gesture code

* fix: data stored on the DOM for tooltips

* fix: use blockSvg to access icons

* fix: add instanceof check in shortcut_items.js

* fix: suppress warning about onKeyDown in tolbox

* fix: add instanceof check in workspace_svg

* fix: don't use dot accessor to avoid type problem

* fix: silence type errors in ast_node.js
2022-04-22 15:55:55 -07:00
Aaron Dodson
edc2a5cd0c fix: Fix compilation errors under Closure's strict mode (#6073)
* fix: Fix errors under strict compilation.

* fix: Fix tests that referenced properties converted to data attributes.

* fix: Incorporate feedback on resolving compiler errors.

* refactor: Revert changes to skew and translate attributes.

* refactor: Introduce LegacyContextMenuOption type to correspond to documented fields.

* refactor: Introduce PathLeftShape and PathDownShape vs casting to PuzzleTab/Notch.

* chore: Added nullability modifiers to type annotations.

* refactor: Export FlyoutItem directly.

* chore: clang-format renderers/zelos/drawer.js.
2022-04-19 14:17:17 -07:00
Aaron Dodson
1647a3299a fix: Move @alias onto classes instead of constructors (#6003)
* fix: Move @alias onto classes instead of constructors

* fix: Fix JSDoc for constructors.
2022-03-16 15:48:32 -07:00
Rachel Fenichel
4cf1a5c886 refactor: convert some files to es classes (#5913)
* refactor: update workspace_comment and _svg to es classes

* refactor: update classes that extend icon to es classes

* refactor: update icon to es6 class

* refactor: update connection classes to es6 classes and add casts as needed

* refactor: update scrollbar to es6 class and add casts as needed

* refactor: update workspace_svg to es6 class

* refactor: update several files to es6 classes

* refactor: update several files to es6 classes

* refactor: update renderers/common/info.js to es6 class

* refactor: update several files to es6 classes

* chore: rebuild deps.js

* chore: run format
2022-02-04 10:58:22 -08:00
Rachel Fenichel
97c19be612 refactor: convert renderer measurables to es6 classes (#5899)
* chore: use casts to narrow types in renderers

* chore: add @struct and type information on common measurables

* refactor: update some renderer measurables to es6 classes

* refactor: convert many measurables to es6 classes

* chore: format

* chore: rebuild
2022-02-01 15:43:11 -08:00
Rachel Fenichel
f5caf964aa refactor: convert renderer classes to es6 classes (#5874)
* refactor: convert zelos renderer classes to es6 classes

* refactor: convert zelos measurables to es6 classes

* refactor: convert thrasos classes to es6 classes

* refactor: convert minimalist classes to es6 classes

* refactor: update geras classes to es6 classes

* chore: rebuild and format

* chore: fix indentation in comments
2022-01-14 12:43:13 -08:00
Aaron Dodson
3851b14627 refactor: Migrate to named exports (#5623)
* refactor: Migrate to named exports

* fix: Sort requires

* fix: Remove duplicate deps
2021-10-20 15:53:23 -07:00
Neil Fraser
90b3f75d82 Remove @author tags (#5601)
Our files are up to a decade old, and have churned so much, that the initial author of the file no longer has much meaning.

Furthermore, this will encourage developers to post to the developer group, rather than emailing Googlers (usually me) directly.
2021-10-15 09:50:46 -07:00
Monica Kozbial
49bc2b1ae4 Replace namespace annotation with class annotation in files that define a class (#5566) 2021-09-28 15:57:09 -07:00
Monica Kozbial
d8fbe1b05b Add namespace and alias annotations to jsdoc (#5550)
* Add annotations to files under core/events

* Add annotations to files under core/interfaces

* Add annotations to files under core/keyboard_nav

* Add annotations to files under core/renderers

* Add annotations to files under core/serialization

* Add annotations to files under core/theme

* Add annotations to files under core/toolbox

* Add annotations to files under core/utils

* Add annotations to files under core
2021-09-27 14:42:54 -07:00
Aaron Dodson
6b07ccab96 chore: Remove declareLegacyNamespace from renderers (#5528)
* chore: Remove declareLegacyNamespace from Geras renderer

* chore: Remove declareLegacyNamespace from minimalist renderer

* chore: Remove declareLegacyNamespace from thrasos renderer

* chore: Remove declareLegacyNamespace from zelos renderer

* fix: Move debugger functionality out of Blockly.blockRendering to avoid dependency cycle when re-exporting submodules

* chore: Remove declareLegacyNamespace from Blockly.blockRendering.*
2021-09-24 08:33:35 -07:00
Rachel Fenichel
3adfaaf6d9 chore: named exports for block* files (#5512)
* chore: named export for block.js

* chore: named export for block_drag_surface.js

* chore: named export for block_dragger.js

* chore: named export for block_svg.js

* Fix import ordering

* chore: fix imports using requireType

* Remove extra require
2021-09-22 08:46:19 -07:00
kozbial
5dff47a1f8 clang-format core/renderers/zelos/drawer.js 2021-08-12 13:20:24 -07:00
kozbial
e9f2d7087b Migrate core/renderers/zelos/drawer.js named requires 2021-08-12 13:20:24 -07:00
kozbial
8073b0e282 Migrate core/renderers/zelos/drawer.js to goog.module 2021-08-12 13:20:24 -07:00
kozbial
7f213b968c Migrate core/renderers/zelos/drawer.js to ES6 const/let 2021-08-12 13:20:24 -07:00
kozbial
a4a3b6a068 Migrate core/renderers/common/block_rendering.js to goog.module 2021-08-09 18:23:07 -07:00
Sam El-Husseini
63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Sam El-Husseini
f97730e83c Sort requires (#4658)
* Cleanup gulp method to sort requires
2021-02-25 17:17:42 -08:00
Rachel Fenichel
6791e1aff2 Fix missing requires and requireTypes in zelos 2021-02-02 11:38:08 -08:00
Sam El-Husseini
9b071ff7f7 [Zelos] Value to stack block support (#3741)
* Zelos value to stack block support
2020-03-12 11:47:47 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
95aadbffb1 [zelos] Set a maximum width for dynamic connection shapes. (#3685)
* Set a maximum width for dynamic connection shapes.

* Only render the left side connection if a block has a statement input
2020-02-07 15:13:51 -08:00
Sam El-Husseini
e162f3b45f [zelos] Don't add next notch in a statement input if the connection block doesn't have a next connection (#3562)
* Don't add a next notch for statement inputs that have a connected block without a next connection.
2020-01-09 08:37:20 -08:00
Sam El-Husseini
e530f209cd Fix bug in zelos tight nesting code. (#3565) 2020-01-08 08:47:10 -08:00
Sam El-Husseini
267877115f Adjust single field row alignment so that it takes up less vertical space (#3557) 2020-01-07 13:52:57 -08:00
Sam El-Husseini
595bc5270f Remove BEFORE/AFTER statement input spacer measurable (#3506)
* Remove before / after statement input measurable and use spacer properties instead.
2019-12-11 19:29:31 -08:00
Sam El-Husseini
f5bb5b6143 Zelos horizontal tight nesting. (#3490)
* Reduce the amount of implicit spacing added by the connection shape by adding negative spacing to the first and last spacer in an output block
2019-12-06 10:51:50 -08:00
Sam El-Husseini
ee09aafd57 [zelos] Add input outlines on the path object. (#3410)
* Add input outlines on the path object.
2019-11-07 15:15:49 -08:00
Sam El-Husseini
a79ea1652a [Zelos] Fix dynamic connection shape size (#3324)
* Better reporting of connection height and width for dynamic connections
2019-10-25 00:33:53 -04:00
Sam El-Husseini
06b5bb1945 Might right corner support to common. Making it so there's always a right corner element, square by default. (#3311) 2019-10-23 21:58:43 -04:00
Sam El-Husseini
3d6eb48937 Render a notch after a statement input in zelos (#3326) 2019-10-23 21:58:18 -04:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Rachel Fenichel
4b17234cba Alphabetize requires 2019-09-10 13:01:13 -07:00
Sam El-Husseini
4c8e28c53d Dynamic output shapes (#2980)
* Round and triangle dynamic output shapes.
2019-09-06 13:04:01 -07:00
Rachel Fenichel
135ab7993e Use ascender/descender naming for top and bottom rows; tweak position calculation. 2019-09-04 16:26:53 -07:00
Sam El-Husseini
73d0b70c22 Add a spacer before and after a statement input and place use it to render a right corner before and after the statement input. (#2967) 2019-09-04 15:38:23 -07:00
Sam El-Husseini
189c561f49 Rendering type checker (#2950)
* Convert all rendering types to use a type enum flag.
2019-09-03 14:39:02 -07:00
Sam El-Husseini
06a882348b Render round right corners in zelos. (#2938)
* Render round right corners in zelos.
2019-08-30 18:11:01 -07:00
Sam El-Husseini
dc1e7b82fe Zelos notch (#2918)
* Add the zelos notch
2019-08-26 17:49:42 -07:00