Commit Graph

3871 Commits

Author SHA1 Message Date
Aaron Dodson
563defa3ba Migrate core/utils/dom.js to goog.module 2021-07-14 15:01:16 -07:00
Aaron Dodson
042b235764 Migrate core/utils/dom.js to ES6 const/let 2021-07-14 14:52:17 -07:00
Aaron Dodson
916b49a2e5 clang-format core/utils/svg_paths.js 2021-07-14 14:44:17 -07:00
Aaron Dodson
72a0761312 Migrate core/utils/svg_paths.js to goog.module 2021-07-14 14:43:15 -07:00
Aaron Dodson
46a3462026 clang-format core/utils/style.js 2021-07-14 14:11:25 -07:00
Aaron Dodson
55ac3741b7 Migrate core/utils/style.js to named requires 2021-07-14 14:10:42 -07:00
Aaron Dodson
656f4fc9d6 Migrate core/utils/style.js to goog.module 2021-07-14 13:58:05 -07:00
Aaron Dodson
78e72222c1 Migrate core/utils/style.js to ES6 const/let 2021-07-14 13:48:22 -07:00
alschmiedt
92bc3bba0f Merge pull request #5056 from alschmiedt/migrate_idgenerator
Migrate core/utils/idgenerator.js to goog.module syntax
2021-07-14 13:29:50 -07:00
alschmiedt
08911510d2 Migrate core/utils/idgenerator.js to goog.module 2021-07-14 13:23:57 -07:00
Aaron Dodson
bad4b7036f Merge pull request #5057 from gonfunko/object
Migrate object.js to goog.module syntax
2021-07-14 11:19:47 -07:00
kozbial
819a0f1596 clang-format core/utils/deprecation.js 2021-07-14 11:16:32 -07:00
kozbial
2bf717019f Migrate core/utils/deprecation.js to goog.module 2021-07-14 11:16:32 -07:00
kozbial
cd4831537e Migrate core/utils/deprecation.js to ES6 const/let 2021-07-14 11:16:32 -07:00
Aaron Dodson
b92fba1a5a Fixed missing semicolon. 2021-07-14 10:55:10 -07:00
kozbial
632ef12ed5 Migrate core/utils/keycodes.js to goog.module 2021-07-14 09:48:23 -07:00
Aaron Dodson
d224a2341d Migrate object.js to goog.module 2021-07-13 15:30:56 -07:00
Aaron Dodson
78b8e2fa85 Migrate object.js to ES6 const/let 2021-07-13 14:42:56 -07:00
Christopher Allen
d313ec804a Merge branch 'develop' into goog.module-prep
This resolves a conflict in `blockly_uncompressed.js`, and missing
updates to `test/deps.js`, caused by PR #5041.
2021-07-13 22:16:35 +01:00
jschanker
de1b3214be Enforce connection preconditions for setParent (#4999)
* Fix error conditions for setParent #4989

* Error now thrown when calling `a.setParent(b)` on non-null b if the output/previous connection of a is not connected to an input/next connection of b without removing block from old parent's child list.
* Commented out error for when calling `a.setParent(null)` if a is connected to superior block.
* Adjusted comment to reflect that blocks were no longer being disconnected in this method.
* Also changed == to === per #4924 (`newParent` and `this.parentBlock_` must both be instances of `Blockly.Block`).

* Fix error conditions for setParent #4989

* Error now thrown when calling `a.setParent(b)` on non-null b if the output/previous connection of a is not connected to an input/next connection of b without removing block from old parent's child list.
* Error now thrown when calling `a.setParent(null)` if a is connected to a superior block.
* Adjusted comment to reflect that blocks were no longer being disconnected in this method.
* Also changed == to === per #4924 (`newParent` and `this.parentBlock_` must both be instances of `Blockly.Block`).

* Fix error conditions for setParent #4989

* Error now thrown when calling `a.setParent(b)` on non-null b if the output/previous connection of a is not connected to an input/next connection of b without removing block from old parent's child list.
* Commented out error for when calling `a.setParent(null)` if a is connected to superior block.
* Adjusted comment to reflect that blocks were no longer being disconnected in this method.
* Also changed == to === per google#4924 (`newParent` and `this.parentBlock_` must both be instances of `Blockly.Block`).
* Fixed lint errors.

* Fix error conditions for setParent google#4989

* Error now thrown when calling `a.setParent(b)` on non-null b if the output/previous connection of a is not connected to an input/next connection of b without removing block from old parent's child list.
* Commented out error for when calling `a.setParent(null)` if a is connected to superior block.
* Adjusted comment to reflect that blocks were no longer being disconnected in this method.
* Also changed == to === per google#4924 (`newParent` and `this.parentBlock_` must both be instances of `Blockly.Block`).
* Fixed lint errors.
* Adjusted comment.

* Removed unnecessary set to null/added tests

* One is failing (commented out), will investigate later

* Lint fix

* Removed failing test that correctly fails

* Update comments to conform to style guide

Capitalize first letter, period at end
2021-07-13 13:56:42 -07:00
alschmiedt
2b6b89dc54 Remove themes that were moved to blockly samples (#5041) 2021-07-13 13:31:27 -07:00
Christopher Allen
948fade7c5 Only disable eslint indent check on one line
For whatever reason eslint was rejecting the (styleguide-correct)
indentation of the line beginning with "/** @type ...", and in my
naïvete I got a little more zealous than I intended in suppressing
the error.
2021-07-13 12:08:35 +01:00
Neil Fraser
b3c94db951 Revert "Revert "Group field edits together for undo/redo""
This reverts commit 344ebcfd02.
2021-07-12 09:38:04 -07:00
Aaron Dodson
0b66af2e84 Merge pull request #5020 from hpnrep6/flyout-button
Fix vertical button padding in horizontal flyout
2021-07-12 08:28:28 -07:00
Neil Fraser
8a3c701026 Enable static method inheritance. 2021-07-11 23:20:20 -07:00
Neil Fraser
2c6d044c40 Review updates 2021-07-11 23:19:01 -07:00
Neil Fraser
02fd8cf7a4 Linting 2021-07-11 23:19:01 -07:00
Neil Fraser
cba7a68207 Allow inheriting of fromJson in fields 2021-07-11 23:19:01 -07:00
hpnrep6
048e77dc9a Include button heights in flyout height calculation 2021-07-12 01:26:03 -04:00
Christopher Allen
603755f250 Suppress spurious eslint error
eslint appears to be confused by the leading JSDoc comment on the
continuation line and suggests it should be indented only 4 rather
than 8 spaces.
2021-07-12 03:51:17 +01:00
Christopher Allen
1197afcee7 Fix JSDoc type annotations causing closure-make-deps warnings
Some type annotations were missing curly brackets, which makes
closure-make-deps emit uninteresting warnings.  Now any output
from the command will be informative and related to whatever
one is presently working on.
2021-07-12 03:17:14 +01:00
Rachel Fenichel
89cf049e74 Merge pull request #4995 from BeksOmega/fix/jsdoc
Updates JSDoc in Block and BlockSvg
2021-07-09 15:57:38 -07:00
Rachel Fenichel
61e2d4caee Merge pull request #4985 from maribethb/typo
fix doc typo
2021-07-09 15:31:15 -07:00
Aaron Dodson
3f55ca59ad Merge pull request #4969 from gonfunko/scrollin-safari
Work around WebKit bug that prevents scrolling/zooming the workspace.
2021-07-08 08:25:29 -07:00
Aaron Dodson
49a4fa7898 Merge pull request #4938 from gonfunko/flyout-zoom
Reflow flyouts when zoom level changes to keep block zoom level in sync.
2021-07-07 10:29:44 -07:00
Beka Westberg
a589cd6923 Update jsdoc 2021-07-07 14:42:18 +00:00
Maribeth Bottorff
74f1926b6a fix doc typo 2021-07-01 19:11:06 -07:00
Maribeth Bottorff
d102cbfab4 Fix Jsdoc by removing trailing comma (#4974) 2021-06-30 16:45:02 -07:00
Aaron Dodson
c163a76807 Removed unused event argument. 2021-06-30 17:52:17 +00:00
Aaron Dodson
5aa8bab22f Work around WebKit bug that prevents scrolling/zooming the workspace. 2021-06-30 17:40:00 +00:00
Neil Fraser
344ebcfd02 Revert "Group field edits together for undo/redo"
This reverts commit 33ad2448b8.
2021-06-29 11:35:21 -07:00
Neil Fraser
33ad2448b8 Group field edits together for undo/redo
Fixes #4189.
Also use 0 instead of 0px, in accordance with the rest of Blockly and Google’s CSS style guide.
2021-06-29 09:57:25 -07:00
Rachel Fenichel
5412adf7e5 Merge pull request #4951 from rachel-fenichel/remove_build_py
Remove deprecated build.py script
2021-06-28 11:13:05 -07:00
Rachel Fenichel
5c48bfc188 Tweak comment 2021-06-28 11:09:01 -07:00
Aaron Dodson
627647c7f2 Reflow workspace- and toolbox-owned flyouts when workspace zoom changes. 2021-06-28 11:08:03 -07:00
Aaron Dodson
0d44d22629 Revert "Reflow flyouts when zoom level changes to keep block zoom level in sync."
This reverts commit 1f6c8f0206.
2021-06-28 10:48:36 -07:00
Neil Fraser
9ad50ea98a Fix escape key on all fields. (#4934)
Currently the escape key fails to revert the value.  This is the inherited root of all type-in fields, including number, angle, and note.

Fixes #4910
2021-06-27 23:51:46 -07:00
Rachel Fenichel
2fcdd846be Remove deprecated build.py script 2021-06-24 16:58:28 -07:00
Aaron Dodson
1f6c8f0206 Reflow flyouts when zoom level changes to keep block zoom level in sync. 2021-06-18 20:26:17 +00:00
Beka Westberg
13bb9f5bf6 Refactor connect logic (#4880)
* Refactor connect logic.

* Fixup from rebase

* Fix build

* PR Comments
2021-06-18 09:53:43 -07:00