Commit Graph

3871 Commits

Author SHA1 Message Date
Rachel Fenichel
a84e86f097 Merge pull request #2366 from alschmiedt/Documentation_Update
Documentation update
2019-04-22 14:45:38 -07:00
alschmiedt
1ca7d6a28b Clarifies what statementToCode does 2019-04-22 14:20:05 -07:00
Beka Westberg
9a9c6612f8 Changed buttons and labels to respect <sep> elements in toolbox. (#2395) 2019-04-22 12:23:04 -07:00
Beka Westberg
e8573bc0db Added isSerializable function and SERIALIZABLE property to fields. 2019-04-21 08:28:37 -07:00
ahigerd
bc77024670 Reorganize conditionals for block context menu (#2390)
* Reorganize conditionals for block context menu

* Disable comments and disabling in block factory
2019-04-18 08:49:07 -07:00
Beka Westberg
0617cc7fea Added isDirty_ property to fields. 2019-04-15 16:37:11 -07:00
RoboErikG
ec78eeb39b Propagate the visible state when blocks connect (#2003)
* Propagate the visible state when blocks connect

This fixes #1967.

In rendered connections when connecting:
- If the superior connection is hidden this hides the newly connected block.
- If the superior connection isn't hidden it makes sure the block is visible.

In rendered connections when disconnecting:
- If the superior connection is hidden, make the disconnected block stack visible.

TODO before review:
 - write tests.
 - update collapsed message

* Add missing overrides

* Add tests for hidden connections and fix a bug while disposing
2019-04-15 16:23:19 -07:00
Beka Westberg
f88c704d69 Fixed visible floating point errors in number fields. (#2384) 2019-04-15 13:26:20 -07:00
Rachel Fenichel
6bb27052ee Merge pull request #2383 from google/fraser-angle
Angle picker's degree symbol left of number in both LTR and RTL.
2019-04-15 12:33:38 -07:00
Beka Westberg
b93253c69c Fixed Mutator Flyout Being Positioned Incorrectly RTL (#2378)
* Fixed mutator flyout being positioned incorrectly.

* Changed flyout_horizonal and flyout_vertical to check this.targetWorkspace_.toolboxPosition instead of targetWorkspaceMetrics.toolboxPosition.
2019-04-15 10:02:07 -07:00
Neil Fraser
8c99cccbc3 Degree symbol left of number in both LTR and RTL.
Resolves issue #2380.
2019-04-13 20:30:56 -07:00
Rachel Fenichel
1bd7c7bffd Merge pull request #2376 from alschmiedt/rever_hideChaff_fix
Reverts hideChaff fix
2019-04-11 14:25:24 -07:00
alschmiedt
be4da5feeb Reverts hideChaff fix 2019-04-11 11:43:37 -07:00
Rachel Fenichel
9c0e138e22 Merge pull request #2367 from alschmiedt/mutator_fix
Updates function call
2019-04-08 17:30:33 -07:00
asunwoo98
ef1c6d08d4 typo fix in line 134 of field.js for documentation 2019-04-08 18:00:38 -04:00
alschmiedt
c4f8313792 Updates function call 2019-04-08 14:14:56 -07:00
alschmiedt
98a1c06e7a Changed jsdoc 2019-04-08 10:48:22 -07:00
RoboErikG
5056e23389 Fix margins/checkbox in RTL dropdown menus (#2356)
Fixes #2337 by adding in correct positioning for RTL selected states
and fixing an incorrect margin value.
2019-04-05 15:55:00 -07:00
alschmiedt
97d670c0ea Updates documentation 2019-04-05 12:00:04 -07:00
alschmiedt
4fca16730c core/generator.js 2019-04-05 11:59:05 -07:00
alschmiedt
dcbac91ba3 Merge pull request #2360 from alschmiedt/Bump_RTL
Fixes bumping too much when in RTL
2019-04-04 16:26:14 -07:00
alschmiedt
a759fffcc1 Fixes bumping too much when in RTL 2019-04-04 15:54:17 -07:00
alschmiedt
124a8f1e40 Merge pull request #2359 from alschmiedt/Hide_chaff_bug
Hides chaff on document mouseup
2019-04-04 14:08:55 -07:00
alschmiedt
db7a87555f Hides chaff on document mouseup 2019-04-04 11:24:22 -07:00
Tiara Tan
e79dcecb22 Rename WorkspaceSvg.getFlyout_ (#2357) 2019-04-03 14:22:42 -07:00
alschmiedt
380d05dd08 Merge pull request #2355 from alschmiedt/unplug_fix
Adds check for a targetConnection
2019-04-02 17:18:07 -07:00
alschmiedt
1034ba835c Adds check for a targetConnection 2019-04-02 14:42:41 -07:00
RoboErikG
1a2cf96a5a Update selected menu sizing to fix #2351 (#2353) 2019-04-01 12:43:19 -07:00
Neil Fraser
767495cf76 Don’t drop newValue from bubble open events. 2019-04-01 11:15:46 -07:00
Neil Fraser
f118d33855 Corrections to JSDoc comments 2019-03-29 15:24:37 -07:00
Neil Fraser
51bfa9455d More comprehensive approach to gesture detection.
Search all workspaces.  The flaw with looking at the workspace of the selected block is that dragging a workspace is a gesture but has no selected block.
2019-03-29 15:24:37 -07:00
Neil Fraser
e9de083361 Fix @return JSDocs. 2019-03-29 15:24:37 -07:00
Neil Fraser
68e134b073 No keyboard access to quarks during drag.
Same issue as zooming with the mouse wheel.
2019-03-29 15:24:37 -07:00
Neil Fraser
6862a7fe70 Use hashes instead of objects. 2019-03-29 15:24:37 -07:00
Neil Fraser
45e24c2b98 No need to check non-null before nullifying 2019-03-29 15:24:37 -07:00
Neil Fraser
6fb95f9038 Consistent speling. 2019-03-29 15:24:37 -07:00
Neil Fraser
87385b0721 Make drag detection more robust.
Previously, one could drag (and hold) a quark outside the bounds of a mutator bubble, then scroll, and the old code wouldn’t query the mutator for gestures.
2019-03-29 15:24:37 -07:00
Neil Fraser
46a4f33e4e Fix JSDoc 2019-03-29 15:24:37 -07:00
Neil Fraser
d6096accca Remove Blockly.WidgetDiv.position
Nobody appears to call it.
2019-03-29 15:24:37 -07:00
Neil Fraser
2fd931cab9 Add comment regarding async nature of listening. 2019-03-29 15:24:37 -07:00
Neil Fraser
50519413d0 Line length 2019-03-29 15:24:37 -07:00
Beka Westberg
5b25843b98 Fixed trashcan flyout positioning. 2019-03-29 08:19:24 -07:00
Neil Fraser
405b1e4e78 Lint issues found while debugging. 2019-03-27 15:47:29 -07:00
Neil Fraser
dbafdcf1ff Prevent gestures from being broken by zoom/scroll. 2019-03-27 15:47:29 -07:00
alschmiedt
bf45c85bf1 Add private annotation 2019-03-22 10:14:43 -07:00
alschmiedt
b6b7ab0091 Refactor setTheme 2019-03-22 09:54:52 -07:00
alschmiedt
5c18e102ca Fixed setTheme so it doesn't error when no workspace is created 2019-03-21 15:32:18 -07:00
Beka Westberg
e947471215 Fixed updateToolbox not properly updating flyouts. (#2332) 2019-03-19 15:48:52 -07:00
alschmiedt
715fdde945 Reverts changes to fix bug with selecting dropdown 2019-03-12 10:39:09 -07:00
amber-cd
c2f30d4ca6 Update toolbox.js
Changed style attribute to categorystyle.
2019-03-05 08:39:20 -05:00