Commit Graph

112 Commits

Author SHA1 Message Date
Rachel Fenichel 73ecde2497 Lint 2019-08-21 15:38:59 -07:00
Rachel Fenichel dd9fdf908f Slightly less fragile 2019-08-21 15:24:37 -07:00
Rachel Fenichel d19614439f Fix icons in geras 2019-08-21 14:35:36 -07:00
Rachel Fenichel e86c852936 Split render_info 2019-08-21 14:33:43 -07:00
Rachel Fenichel 611b9884ca Move input measurables into a separate file, and make them extend connection measurables. 2019-08-20 15:51:31 -07:00
Rachel Fenichel d790ad98ee Merge pull request #2882 from rachel-fenichel/measurables_connections_file
Move Connection measurables to their own file
2019-08-20 15:48:33 -07:00
Rachel Fenichel c2e772f864 Fix provides and requires 2019-08-20 15:41:52 -07:00
kozbial ffbd483442 Storing notch_left_offset on rows and measurables. 2019-08-20 14:09:16 -07:00
Rachel Fenichel 8d32f6bef3 Move Connection measurables to their own file 2019-08-20 11:41:04 -07:00
kozbial c50257619f Updating for loops in renderers to use constent pattern. 2019-08-20 11:40:01 -07:00
Rachel Fenichel 2102af9c7b Merge pull request #2869 from rachel-fenichel/populate_top_bottom_rows
Make top and bottom rows populate themselves
2019-08-20 10:50:38 -07:00
Rachel Fenichel 9dcd38abb8 Remove dead TODO 2019-08-20 10:45:53 -07:00
Monica Kozbial 124f7a38b4 Merge pull request #2830 from moniika/moniika-use-field-notch-and-connection
Minor refactor in drawing statement and value inputs
2019-08-19 16:26:28 -07:00
Rachel Fenichel d25c08e209 Merge branch 'develop' into populate_top_bottom_rows 2019-08-19 15:16:06 -07:00
Rachel Fenichel 9b8636661f Make rows populate themselves 2019-08-19 15:08:23 -07:00
Rachel Fenichel 54ef08ea04 Fix some annotations 2019-08-19 14:57:13 -07:00
kozbial 4debe8f967 Fixing eslint issue and missing getLastInput call. 2019-08-19 14:51:12 -07:00
kozbial 2d314cbd4a Reverting highlight methods restructure. 2019-08-19 14:51:12 -07:00
kozbial 17c1537a4f Updating draw for statement input and value input to use element xPos and more approriate constants. 2019-08-19 14:51:12 -07:00
Sam El-Husseini 4b4b50d76f Fix drawInternals crash (#2867) 2019-08-19 14:50:46 -07:00
Neil Fraser 096959fde9 Cleanup of last fortnight’s commits. (#2865)
No functional changes.
2019-08-19 14:07:48 -07:00
Rachel Fenichel 981761f7da Move the base Measurable class to its own file 2019-08-19 13:54:07 -07:00
Rachel Fenichel 450ac4ba15 Consider min height and min width in row measure 2019-08-19 13:30:41 -07:00
Rachel Fenichel efdf80c49c Reset height and width at the beginning of a measure 2019-08-19 11:28:39 -07:00
Rachel Fenichel b2ebe89493 Cleanup 2019-08-19 11:28:39 -07:00
Rachel Fenichel 88a9307cdb Move all rows into rows.js 2019-08-19 11:28:12 -07:00
Rachel Fenichel 4a3fdb83db Move rows to a new file and annotate 2019-08-19 11:28:12 -07:00
Monica Kozbial a1ab4b92bd Merge pull request #2845 from moniika/moniika-render-draw-simple-warnings
Fixing basic warnings in block_render_draw_debug.
2019-08-19 10:40:25 -07:00
Rachel Fenichel b42214abd1 Guarantee that the top and bottom rows exist 2019-08-16 17:36:02 -07:00
Rachel Fenichel ca6e591047 Turn off debug rendering 2019-08-16 17:10:06 -07:00
Rachel Fenichel 04a77f0ef2 Fix some compiler warnings 2019-08-16 17:05:24 -07:00
kozbial 41e6167334 Fixing basic warnings in block_render_draw_debug. 2019-08-16 11:51:24 -07:00
kozbial ca357aa71f Cleaning up some warnings in block_render_draw.js. 2019-08-15 16:16:26 -07:00
Rachel Fenichel a01d1eb5bc Merge pull request #2825 from rachel-fenichel/block_widths
Correctly calculate widths of blocks with children on external inputs.
2019-08-15 14:35:15 -07:00
Rachel Fenichel 26e9348b07 Center some fields and inputs vertically 2019-08-15 11:06:05 -07:00
kozbial c4165e92b8 Prevent incorrectly drawing vertical line for zero height spacer rows. 2019-08-14 16:16:48 -07:00
Rachel Fenichel 7b5e6eee63 Correctly calculate widths of blocks with children on external inputs. 2019-08-14 14:09:20 -07:00
kozbial a476564fa2 Fixing width computation and start x for statement input draw. 2019-08-14 11:34:32 -07:00
kozbial d921c4ff47 Using statement input xPos instead of statementEdge. 2019-08-13 18:01:24 -07:00
kozbial 2d30ed2e9c Update statementInput width to reflect what is actually being rendered. 2019-08-13 17:35:04 -07:00
Monica Kozbial b0098f7817 Merge pull request #2810 from moniika/moniika-debug-rect
Adding missing padding to statement input rows.
2019-08-13 17:32:04 -07:00
kozbial 95163f30de Minor refactor in alignRowElements currentWidth and desiredWidth computation. 2019-08-13 17:15:50 -07:00
Rachel Fenichel 39b3717b2c Include next connection in block's bounding box 2019-08-13 15:23:27 -07:00
Rachel Fenichel f449c8bb3c Remove commented out code 2019-08-13 14:32:03 -07:00
Rachel Fenichel 4f487c65f0 Fix hat 2019-08-13 14:26:22 -07:00
Rachel Fenichel 6b440cc5e0 Replace path array with path string 2019-08-13 14:17:51 -07:00
kozbial 99c970bcf5 Adding missing padding to statement input rows. 2019-08-13 13:32:03 -07:00
Rachel Fenichel 71e720444f Use connection width to find empty input width 2019-08-13 10:16:29 -07:00
Rachel Fenichel d954182c41 Fix width with children for external inputs 2019-08-13 10:16:29 -07:00
Rachel Fenichel ede7c7e125 Include tab width in block width 2019-08-13 10:16:29 -07:00