Commit Graph

140 Commits

Author SHA1 Message Date
Neil Fraser
76b5517008 Use null-prototype objects for maps
A {} has a bunch of names already defined on it (like ‘toString’).  When using an object as a map with arbitrary keys, it should not inherit from Object.prototype.
2021-06-09 11:41:42 -07:00
Neil Fraser
d919b0af21 Update JSDoc from Array.<> to Array<>
Same with Object.
2021-05-27 21:30:26 -07:00
Neil Fraser
2f2252f588 Rename variableDB_ to nameDB_
There is significant confusion in names and comments with regards to variables and procedures.  `Blockly.Generator.prototype.variableDB_` is a Blockly.Names database, not a variable map.  This rename introduces a getter and setter so deprecated references still work.  This commit also fixes some comments which are either outright wrong or misleading regarding variable and procedure names.
2021-05-27 21:30:26 -07:00
Neil Fraser
dd0314bc0b Normalize comments 2021-05-19 09:57:14 -07:00
Maribeth Bottorff
ae33b64f4d update event type in blockly developer tools (#4731) 2021-03-24 17:47:49 -07:00
Monica Kozbial
29b96d8d35 Fix ui event checks (#4512) 2020-12-08 16:21:52 -08:00
Monica Kozbial
40ef586260 Refactoring Ui events in core (#4418)
* Ui events base (#4370)

* Add constants for new ui event types

* Add property to indicate an event as UI event

* Click events (#4372)

* Creating new ui base class.

* Refactor theme event (#4391)

* Add themeName property to theme event

* Refactor marker move events. (#4389)

* Refactor trashcan open event (#4392)

* Refactor selected event (#4387)

* Refactor toolbox item change event (#4394)

* Refactor bubble open events (#4390)

* Refactor block drag event (#4388)

* Viewport events (#4395)

* Fix event filtering for ui events (#4401)

* Move events to new directory and rename Ui events base (#4400)

* Move events to new directory and rename Ui events base

* Add missing fromJson implementation for click event (#4410)

* Adding serialization tests for events

* Zoom controls event (#4407)

* Refactor zoom event

* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
Halit Anil Donmez
b48d3a6dd3 add new typed variable (#4352)
* add new typed variable

* add typed variables to the prompt message
2020-10-07 11:07:35 -07:00
Monica Kozbial
311167bdc5 Fix render issue with block factory connection dropdown (#4334) 2020-09-29 15:58:19 -07:00
alschmiedt
3d698f4bcc Block factory fix (#4327) 2020-09-28 10:42:45 -07:00
Monica Kozbial
0b97445351 Fix line escape (#4310) 2020-09-23 13:07:12 -07:00
mmathrani
74b179bfd6 Update link alert description in demos (#4160)
* Alert update on save blocks

* Add a missing \ in the alert message

* added missing words in storage message
2020-08-12 12:28:36 -07:00
Rachel Fenichel
1fd7622cf0 Add privacy policy to demos that use storage 2020-08-05 19:43:28 -07:00
Sam El-Husseini
888e348c69 Clean out the date field (#3876) 2020-05-06 09:42:24 -07:00
Monica Kozbial
a9223b0b22 Typo fixes. (#3769) 2020-03-25 15:47:27 -07:00
Neil Fraser
4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini
4a94dc8a85 Unpack self-closing tags when converting domToText (#3665)
* Unpack self-closing tags when converting domToText
2020-01-27 15:32:12 -08:00
Sam El-Husseini
986e965be8 Private/protected visibility cleanup (#3263)
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
Noah Glaser
8eb003f01f Fix capitolization error 2019-10-14 23:25:34 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Beka Westberg
b149aabd16 Image Field Config (#2983)
* Added image field configuration.
2019-09-16 11:05:32 -07:00
Neil Fraser
5650fe51a2 Typos. 2019-09-12 18:24:48 -07:00
Neil Fraser
23caa12571 Error is a constructor, ‘new’ is not required. 2019-09-12 18:02:59 -07:00
Beka Westberg
33e6fa6ed9 Fixed Block Factory XML not Getting Properly Cleaned (#2801)
* Fixed factory XML not getting properly cleaned.

* Added jsdoc.
2019-08-21 15:59:21 -07:00
Neil Fraser
b52de5cac2 Remove self-closing XML tags in workspace factory (#2769) 2019-08-15 10:20:49 -07:00
Neil Fraser
939bbd072b Lint 2019-08-02 11:00:40 -07:00
Neil Fraser
ae24b544f3 Fix injection vulnerability in Block Factories.
Fixes issue #756.
2019-08-02 11:00:40 -07:00
Neil Fraser
e77a9b7e81 Change parseFloat() to Number()
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number.  An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
6aedfab4d1 Misc JSDoc fixes. (#2747) 2019-07-30 16:28:48 -07:00
Neil Fraser
d1fb3f0480 Fix typo in Blockly Factory. 2019-07-08 13:29:43 -07:00
Neil Fraser
52b6ce18a5 Fix unit tests 2019-07-08 13:29:43 -07:00
Neil Fraser
cbd944106c Strip silly code
Sigh.
2019-06-26 13:55:55 -07:00
Neil Fraser
3a77a3d7ce Define colours of standard categories by hue.
Previously they were defined in hex.
This meant that saturation and value were hardcoded.
This also resulted in off-by-one errors (Math was hardcoded as #5C68A6, but is calculated as #5B67A5) which in turn resulted in the colour not being highlighted in the picker.
2019-06-26 13:55:55 -07:00
Neil Fraser
ef28773a52 Enable selection of “no colour” on categories.
Near complete rewrite of colour picker for Blockly Factory.
* Drop IE6 support.
* Flip picker as needed so it doesn’t go offscreen.
* Add support for no colour.
* Factor CSS out of JS.
* Provide palette of our standard colours.
2019-06-26 13:55:55 -07:00
Neil Fraser
7e048f2e09 Remove last Closure from Block Factory.
Improves UI, but is still pretty clunky.  For example there’s still not way to choose “no colour”.
Closes #668.
2019-06-26 13:55:55 -07:00
Beka Westberg
73ff710a4d Added getSourceBlock function to field. (#2508) 2019-05-29 12:50:00 -07:00
Beka Westberg
ce816b93bf Added field_label_serializable. (#2399) 2019-04-24 10:43:09 -07:00
ahigerd
bc77024670 Reorganize conditionals for block context menu (#2390)
* Reorganize conditionals for block context menu

* Disable comments and disabling in block factory
2019-04-18 08:49:07 -07:00
Beka Westberg
969687ec34 Added flipRtl Support for FieldImages (#2203)
* Added flipRtl support for FieldImages. Added a flipRtl test block.

* Added blockfactory support.

* Fixed JSDoc.
2019-01-10 08:59:35 -08:00
Rachel Fenichel
6092e4c517 Calls to getAllBlocks should pass a value for _ordered_ 2018-09-13 16:06:19 -07:00
Andrew n marshall
2747396cd3 Fixes to handling <pre> text content. 2018-06-25 13:20:10 -07:00
Andrew n marshall
b4cfe263fa Removing (most) Closure from BlockFactory (#1925)
Replacing all Closure goog. library calls from BlockFactory, with the exception of the ColorPicker and the test for the warning about running without Closure. This includes (almost) all goog.provide and goog.require statements.
2018-06-15 15:29:41 -07:00
Andrew n marshall
2aadfa6ac2 BlockFactory: Fixing incorrect <button> html (#1622)
Applies changes suggested in #1176, based off of develop.
2018-02-20 13:00:44 -08:00
Andrew n marshall
03538c19a7 Fix #1601
Correct deprecated argument order in domToWorksapce call in WorkspaceFactory.
2018-02-12 12:52:34 -08:00
Ziya ERKOC
97daddb01e Update block_exporter_controller.js
Generator stub file type is set to javascript; unnecesarry conditions removed.
2018-01-22 11:26:35 -08:00
Ziya ERKOC
4bbd83820c Update block_exporter_controller.js
Default export type of Generator Stub section is set to '.js' while downloading it in Block Export (in Block Factory)
2018-01-22 11:26:35 -08:00
Neil Fraser
8779a8c3d9 Introduce minimap to style guide. 2017-10-24 14:06:29 -07:00
Andrew n marshall
1956baa963 BlockFactory: Adding JSON/JavaScript import support (#1235)
Updates the BlockFactory main workspace based on the preview block generated from manual construction.

This is a continuation of PR #1216 by @JC-Orozco, rebased on latest develop branch. Bring it latest code up to Google styling and standards.
2017-08-17 12:40:58 -07:00
marisaleung
103c10eddb Change workspace name to playgroundWorkspace. 2017-08-02 17:03:22 -07:00
Andrew n marshall
abcc9b82a1 Adding BlocklyDevTools.Analytics (#1217)
Adding BlocklyDevTools.Analytics, an interface for integrating an analytics
library to track basic usage, including:
 * navigation.
 * saving, importing, and exporting.
 * warnings and errors.
2017-07-11 15:39:35 -07:00