Sam El-Husseini
f3f3329355
Fix configure method ( #2915 )
...
* Fix configure method.
2019-09-12 17:01:03 -07:00
Sam El-Husseini
8ab51c8639
Remove closure base file dependency ( #2976 )
...
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini
f23b659898
Remove this.text_ ( #2910 )
...
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
Sam El-Husseini
ff76ee5b0d
Dropdown field with Blockly.Menu ( #2832 )
...
* Switch dropdown field from using goog.ui.Menu to Blockly.Menu
2019-08-16 18:22:05 -07:00
Beka Westberg
0872d022e1
Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires.
2019-08-16 09:57:28 -07:00
Beka Westberg
cdc90f4059
Refactored field utilities.
2019-08-16 09:57:27 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Rachel Fenichel
b4109d7c43
Add no-multi-spaces rule
2019-07-31 09:33:54 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Sam El-Husseini
57868e7e83
Remove all calls to goog.math ( #2739 )
...
* Replace calls to goog.math.Size and goog.math.Coordinate with Blockly equivelants
2019-07-30 11:22:08 -07:00
Beka Westberg
3d813803ca
updateVariableName -> refreshVariableName
2019-07-26 12:55:43 -07:00
Beka Westberg
20837da54f
Deprecated field setText function.
2019-07-19 08:57:34 -07:00
Neil Fraser
829dcc207c
Make type and variabletype attributes optional
...
If a variable doesn’t have a type, then don’t add these empty attributes in the XML.
2019-07-15 14:37:27 -07:00
Neil Fraser
dd6cb19f5d
Backward compatibility check for ‘variableType’
2019-07-08 13:29:43 -07:00
Neil Fraser
52b6ce18a5
Fix unit tests
2019-07-08 13:29:43 -07:00
Beka Westberg
303115953e
Moved to #2125 disposal. Cleaned up some doc.
2019-06-11 13:32:09 -07:00
Beka Westberg
2f0b02525a
Moved serializing the field's name up to xml.js
2019-05-31 10:12:57 -07:00
Neil Fraser
9f528922a7
Fix some dependencies
2019-05-24 15:45:05 -07:00
Beka Westberg
f16c9c0beb
Refactored field validation.
2019-05-24 14:23:42 -07:00
Beka Westberg
354d402c49
Refactored field.init into field.initView and field.initModel
2019-05-03 07:12:46 -07:00
Beka Westberg
123b5dc91e
Added fromXml and toXml to fields.
2019-04-25 16:00:09 -07:00
Beka Westberg
e8573bc0db
Added isSerializable function and SERIALIZABLE property to fields.
2019-04-21 08:28:37 -07:00
Neil Fraser
f118d33855
Corrections to JSDoc comments
2019-03-29 15:24:37 -07:00
Neil Fraser
e9de083361
Fix @return JSDocs.
2019-03-29 15:24:37 -07:00
Neil Fraser
db0dbc69ee
Update todos and requires.
2018-10-16 11:34:10 -07:00
Neil Fraser
aa09ad9175
Line wrap at 80.
2018-10-16 11:34:10 -07:00
Neil Fraser
51e86263c7
Correct requires for goog.math.*
2018-07-11 12:20:02 -07:00
Neil Fraser
284b79407e
Require Blockly.utils where needed.
2018-07-11 12:20:02 -07:00
Neil Fraser
03bf9f5e71
Remove goog.string
2018-07-11 12:20:02 -07:00
Neil Fraser
3909bd420a
Remove all goog.asserts and goog.isXxx
...
First step to reducing Closure’s footprint.
2018-07-11 12:20:02 -07:00
Rachel Fenichel
a572a15874
Merge pull request #1827 from rachel-fenichel/feature/references_variables
...
Add a referencesVariables function to field
2018-04-27 15:34:53 -07:00
Rachel Fenichel
66fde72ab6
Change comment on function
2018-04-27 13:25:06 -07:00
Neil Fraser
4cb4b42f8d
Use named properties on Msg.
2018-04-27 11:50:51 -07:00
Rachel Fenichel
a8767ee6c9
Add a referencesVariables function to field
2018-04-25 15:15:05 -07:00
Rachel Fenichel
8de5b3ee9f
Get rid of variable redeclaration
2018-03-15 13:04:09 -07:00
Rachel Fenichel
615c403b44
Use @nocompress annotation to fix advanced compilation.
2018-03-01 12:35:55 -08:00
Mark Gibson
54f0e06e21
Customising field types using a register of fields #1584 ( #1594 )
...
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Mark Gibson
2308ae8c22
Remove underscore from fromJson_
2018-02-07 18:18:35 +00:00
Mark Gibson
d40ef474ae
See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers
2018-02-07 12:22:26 +00:00
Rachel Fenichel
fb897d7786
Even more lint. 90 errors remaining.
2018-01-23 18:33:30 -08:00
Rachel Fenichel
06ae9ade8e
Don't update the field until all checks pass
2018-01-19 15:49:39 -08:00
Rachel Fenichel
7314bdfb3a
Fix #1499 and add some validation
2018-01-17 16:54:12 -08:00
Rachel Fenichel
b593d44379
Make the potential variable map null when not needed
2018-01-12 14:51:02 -08:00
Rachel Fenichel
80b397f532
Respond to more review comments
2018-01-10 17:27:43 -08:00
Rachel Fenichel
a43b0e7010
Respond to commit comments and make compressed blockly work again
2018-01-10 17:02:02 -08:00
Rachel Fenichel
5d6d7519cd
Remove some TODOs; add a variable-referencing block to the simple playground flyout
2018-01-08 14:14:26 -08:00
Rachel Fenichel
b342fb2121
Fix problem with clearing flyout after a variable was deleted.
2018-01-02 16:42:28 -08:00
Rachel Fenichel
6218750207
Fix events for variable fields on new blocks; fix tests
2017-12-19 11:28:23 -08:00
Rachel Fenichel
e77b498504
Respond to review comments in variable_map
2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603
Clean up TODOs and move potential variable map to the flyout workspace
2017-12-13 11:50:08 -08:00
