Commit Graph

154 Commits

Author SHA1 Message Date
Rachel Fenichel
f3c10d4eaa Merge develop into master (#1064)
* Adding new minimap demo

* Basic code style changes. Adding a few more comments. Return early if disableScrollChange in onScrollChange listener.

* Adding horizontal scrolling. Changed scroll change callbacks from onScroll_ to setHandlePosition. onScroll_ is not challed when workspace is dragged.

* Registering mousemove and mouseup listener in mousedown event. Mousemove and Mouseup events are now listening over document.

* Adding the remove variable modal and functionality to accessible Blockly. (#1011)

* Minimap position bug fix for browsers other than chrome. Added touch support.

* Adding an add variable modal to accessible Blockly. (#1015)

* Adding the remove variable modal and functionality to accessible Blockly.

* Adding the add variable modal for accessible Blockly.

* Block browser context menu in the toolbox and flyout

* Add links to the dev registration form and contributor guidelines

* Miscellaneous comment cleanup

* Adding the common modal class. (#1017)

Centralizes accessible modal behavior.

* - Changed error message referencing 'procedure' instead of 'function' (#1019)

- Added iOS specific UI messages
- Fixed bug with js_to_json.py script where it didn't recognize ' character

* - Allows use of Blockly's messaging format for category name, colour,… (#1028)

...in toolbox XML.
- Updated code editor demo to use this message format
- Re-built blockly_compressed.js

* Making text_count use a text color (like text_length, which also returns a number). (#1027)

* Enable google/blockly with continuous build on travis ci (#1023) (#1035)

* create .travis for ci job

* initial checkin for blocky-web travis ci job

* rename file to .travis.yaml for typo

* remove after_script

* added cache

* rename .travis.yaml to .travis.yml

* Update .travis.yml

* include build script

* fix yaml file format issue

* debug install part

* debug build issue

* Update .travis.yml

* remove cache for now

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* more debug info

* Update .travis.yml

* Update .travis.yml

* fix typo

* installing chrome browser

* remove chrome setting config

* run build.py as part of npm install

* Update .travis.yml

* update karma dependency

* use karma as test runner

* fix typo

* remove karma test for now

* Update .travis.yml

* Update package.json

* add npm test target

* add browserstack-runner depdendency

* update browser support

* fix typo for test target

* fix chrome typo

* added closure dependency

* add google-closure-library

* include blockly_uncompressed.js and core.js dependency

* uncomment out core/*.js files

* add kama job as part of install

* remove browserstack add on for now

* fix karma config typo

* add karma-closure

* add os support

* remove typo config

* include more closure files

* change os back to linux

* use closure-library from node_modules

* change log level back to INFO

* change npm test target to use open browser command instead of karma

* change travis test target to use open command instead of karma

* list current directory

* find what's in current dir

* typo command

* Update .travis.yml

* typo again

* open right index.html

* use right path for index.html

* xdg-open to open default browser on travis

* exit browser after 5s wait

* change timeout to 1 min

* exit after opening up browser

* use browser only

* use karma

* remove un-needed dependency

* clean up script section

* fix typo

* update build status on readme

* initial commit for selenium integration tests

* update selenium jar path

* fix test_runner.js typo

* add more debug info

* check java version

* add && instead of 9288

* fix java path

* add logic to check if selenium is running or not

* add some deugging info

* initial commit to get chromedriver

* add chromedriver flag

* add get_chromedriver.sh to package.json and .travel

* change browser to chrome for now

* fix path issue

* update chromdriver path

* fix path issue again

* more debugging

* add debug msg

* fix typo

* minor fix for getting chromedriver

* install latest chrome browser

* clean up pakcage.json

* use npm target for test run

* remove removing trailing comma

* fix another trailing comma

* updated travis test target

* clean up scripts

* not sure nmp run preinstall

* redirect selenium log to tmp file

* revert writing console log to file

* update test summary

* more clean up

* minor clean up before pull request

* resolved closure-library conflict

1. add closure-library to dependencies instead of devDependencies.
2. add lint back in scripts block

* fix typo (adding comma) in script section

* Renames Blockly.workspaceDragSurface to Blockly.WorkspaceDragSurface.

Fixes #880.

* Ensure useDragSurface is a boolean.

Fixed #988

* use pretest instead of preinstall in package.json (#1043)

* cherry pick for pretest fix

* put pretest target to test_setup.sh

* fix conflict

* cherry pick for get_chromedriver.sh

* add some sleep to wait download to finish

* use node.js stable

* use npm test target

* field_angle renders degree symbol consistently.

Fixes #973

* bumpNeighbours_ function moved to block_svg.

Fixed #1009

* Update RegEx in js-to-json to match windowi eol (#1050)

The current regex only works with the "\n" line endings as it expects no characters after the optional ";" at the end of the line. In windows, if it adds the "\r" it counts as a characters and is not part of the line terminator so it doesn't match.

* Fix French translation of "colour with rgb" block (#1053)

"colorier", which is currently used, is a verb and proposed "couleur" is
a noun: the block in question does not change colour of anything, it
creates new colour instead, thus noun is more applicable.

Also, noun is used in French translation of "random colour" block:
"couleur aléatoire".

* Enforcing non-empty names on value inputs and statement inputs. (#1054)

* Correcting #1054 (#1056)

single quotes. better logic.

* Created a variable model with name, id, and type.

Created a jsunit test file for variable model.

* Change how blockly handles cursors.  The old way was quite slow becau… (#1057)

* Change how blockly handles cursors.  The old way was quite slow because it changed the stylesheet directly.  See issue #981 for more details on implementation and tradeoffs.  This changes makes the following high level changes: deprecate Blockly.Css.setCursor, use built in open and closed hand cursor instead of custom .cur files, add css to draggable objects to set the open and closed hand cursors.

* Rebuild blockly_uncompressed to pick up a testing change to make travis happy.  Fix a build warning from a multi-line string in the process. (#1059)

* Merge master into develop (#1063)

- pick up translation changes
- clean up trailing spaces

* Rebuild for translations
2017-04-25 10:48:40 -07:00
CoryDCode
b0856b879d Fixing commenting from the last commit. (#1000) 2017-03-23 14:49:05 -07:00
CoryDCode
6cc6848961 Added the variable modal and component and implemented basic renaming functionality. (#991) 2017-03-23 13:47:26 -07:00
CoryDCode
c3c1f83105 Fixing Enter so it properly propogates to dropdown selection. (#934)
Fixing FieldSegment so it updates dropdowns when the underlying dropdown changes.
2017-02-15 11:13:32 -08:00
CoryDCode
1a1646a5c4 Pinning the angular2 dependency, and including licenses. (#893) 2017-02-02 13:29:02 -08:00
Sean Lip
ff578359a6 Deleting a top-level block does not cause blocks after it to be deleted. Properly handle the active desc for this case. 2017-01-27 20:27:58 -08:00
Sean Lip
bf3b5f9d0d Fix a bug where splicing a block between two linked blocks disconnects the group and messes up the focus. 2017-01-27 18:33:39 -08:00
Sean Lip
42ce2f6856 Clear all active desc ids when the 'Erase Workspace' button is pressed. 2017-01-27 15:38:49 -08:00
CoryDCode
ed0bec07a2 Fixing combo boxes getting out-of-sync with NVDA.
Combo boxes need to be special cased like text input. Also, Escape is
a reserved button in NVDA, so I added Enter as a way to "submit and
move up a level" in addition to escape, so these boxes can be edited
while NVDA is on.
2017-01-20 16:16:51 -08:00
Sean Lip
fceba91c6c Clean up workspace.component.js. When moving a block from one place to another, move all blocks after it too, and adjust the active descs accordingly. 2017-01-19 17:12:15 -08:00
Sean Lip
59b074d19f Further cleanup and removal of unnecessary functions. Pull some strings out for i18n. 2017-01-18 17:45:15 -08:00
Sean Lip
d2bfd134b6 Rewrite tree.service.js.
- Remove unnecessary code and functions.
- Add documentation where needed.
- Fix a bug arising when a block on the workspace is attached to an existing link.
2017-01-18 16:56:16 -08:00
Sean Lip
767ce2ab8e Refactor and simplify field-segment.component.js. 2017-01-17 17:21:32 -08:00
Sean Lip
9d8adaba91 Remove debug info. 2017-01-17 15:53:13 -08:00
Sean Lip
5ed6b7a48d Remove unnecessary check when attaching a new block to a marked connection. 2017-01-17 15:52:04 -08:00
Sean Lip
08a141aa21 Minor refactoring of the modal code (add comments, guard against invalid keystrokes, etc.). 2017-01-17 15:19:12 -08:00
Sean Lip
4bef8cc329 Rename workspace-tree to workspace-block. 2017-01-17 13:32:33 -08:00
Sean Lip
ed0c9868c6 Fix bug in audioService where attached event callbacks were not being cleared properly. 2017-01-17 11:48:01 -08:00
Sean Lip
30a4a1930f Fix issue with aria-liveregion not speaking. Allow sufficient time for alert noise to play before speaking the notification. 2016-12-08 19:55:42 -08:00
Sean Lip
521909b2dd Add an aria-describedby to the 'create new block group...' button in the workspace to give more context. 2016-12-08 19:23:40 -08:00
Sean Lip
5960aa8461 Use Tab keys instead of arrow keys for dialog boxes. Set role=alertdialog and read out the header/text automatically. Ensure that Esc key actually closes dialogs and that all keystrokes are captured. 2016-12-08 18:27:17 -08:00
Sean Lip
09980308ec Remove premature focus on buttons in modal dialogs, since this prevents readout of the dialog text. 2016-12-05 18:12:48 -08:00
Sean Lip
2a172c761c Standardize indentation. 2016-12-05 17:54:12 -08:00
Sean Lip
51f42ef5a3 Remove some functions from utilsService and consolidate code in workspace-tree.component.js. 2016-12-05 17:52:45 -08:00
Sean Lip
04785a2222 Clean up the sidebar file and remove unneeded code. 2016-12-05 17:39:03 -08:00
Sean Lip
7b7e62e3e2 When adding a new block group from the toolbox modal, only show blocks with no output connections. 2016-12-05 16:39:12 -08:00
Sean Lip
e13ce31282 Change dropdowns to select fields instead of lists of buttons. 2016-12-01 14:56:09 -08:00
Sean Lip
10efda6d9c Refactor and simplify marked spot logic. 2016-11-30 16:45:06 -08:00
Sean Lip
4c30b91bc6 Remove clipboard functionality. 2016-11-30 15:31:19 -08:00
Sean Lip
69d4ebb6dd Improve styling of sidebar buttons. 2016-11-29 19:01:34 -08:00
Sean Lip
65bad28f61 Minor refactoring. Remove unused dependencies. 2016-11-29 18:50:31 -08:00
Sean Lip
4e623631dd Update config options for sidebar buttons. 2016-11-29 18:24:50 -08:00
Sean Lip
b75925004c Do some refactoring and tidy-up. Pull some hardcoded strings out for i18n purposes; remove unused strings. 2016-11-28 18:57:44 -08:00
Sean Lip
aa49539059 Remove unavailable blocks from toolbox modal. Hide unnecessary category name in a toolbox without categories. 2016-11-28 18:24:31 -08:00
Sean Lip
89e9f370b7 Add information regarding target screen reader and browser. 2016-11-28 16:37:12 -08:00
Sean Lip
664e6dcf7e Set focus correctly when toolbox modal is dismissed. 2016-11-28 16:34:52 -08:00
Sean Lip
3b24391768 Do not show disabled actions in the block options modal. 2016-11-28 16:01:15 -08:00
Sean Lip
36b0213533 Streamline the logic for block selection callbacks in the toolbox modal. 2016-11-28 14:26:38 -08:00
Sean Lip
e8e8de93bb Handle the finer points for setting focus correctly after deleting blocks from the workspace. 2016-11-22 17:58:37 -08:00
Sean Lip
5c79d2f36f When the workspace is empty, make it easy for the user to add a new group of blocks to it. 2016-11-22 15:53:45 -08:00
Sean Lip
10a8844980 Add warning sounds when the user reaches a boundary of the workspace. 2016-11-17 17:45:42 -08:00
Sean Lip
602c1ba56e Delete the on-screen toolbox. 2016-11-17 17:45:12 -08:00
Sean Lip
cf9a4fbdf4 Allow attaching blocks to a marked spot from the toolbox modal. This is the last prerequisite for removal of the existing on-screen toolbox. 2016-11-17 17:12:27 -08:00
Sean Lip
df56c64f4f Fix some bugs arising in the toolbox modal for the no-categories case. 2016-11-17 16:13:43 -08:00
Sean Lip
6ab1244560 Add a contextual modal for the toolbox. 2016-11-17 15:58:23 -08:00
Sean Lip
a027ec8573 Move away from using a common modal service, since the block options and the toolbox modals are going to end up behaving fairly differently. 2016-11-16 16:47:26 -08:00
Sean Lip
471e09662e Hide notification messages after a short time interval. 2016-11-15 17:37:38 -08:00
Sean Lip
25588fc7bd Break the sidebar out into its own individual component. 2016-11-15 17:19:01 -08:00
Neil Fraser
f6aef459fc API-breaking cleanup. But doubtful anyone will be affected. (#748)
* Make add/removeClass return whether they did anything.
* Move more functions onto utils.
* Move bind functions to Blockly.
* Routine recompile.
2016-11-15 13:54:33 -08:00
Sean Lip
bed33a9b61 Disallow clicks on disabled buttons. 2016-11-14 18:48:29 -08:00