Commit Graph

1945 Commits

Author SHA1 Message Date
Rachel Fenichel
33cce3c869 Merge pull request #2877 from BeksOmega/feature/ColourFieldConfig
Changed Colour field to New Configuration Paradigm
2019-08-20 11:19:17 -07:00
Rachel Fenichel
89a1aec335 Merge pull request #2791 from BeksOmega/fixes/RemoveCallValidator
Removed Deprecated callValidator Call
2019-08-20 11:15:19 -07:00
Rachel Fenichel
2102af9c7b Merge pull request #2869 from rachel-fenichel/populate_top_bottom_rows
Make top and bottom rows populate themselves
2019-08-20 10:50:38 -07:00
Rachel Fenichel
9dcd38abb8 Remove dead TODO 2019-08-20 10:45:53 -07:00
Beka Westberg
0d482c6488 Changed colour field to new configuration paradigm. 2019-08-20 09:44:14 -07:00
Monica Kozbial
124f7a38b4 Merge pull request #2830 from moniika/moniika-use-field-notch-and-connection
Minor refactor in drawing statement and value inputs
2019-08-19 16:26:28 -07:00
Sam El-Husseini
8a04d5d71b Field colour + Blockly actions (#2855)
* Update field colour to support blockly actions
2019-08-19 16:09:38 -07:00
Rachel Fenichel
d25c08e209 Merge branch 'develop' into populate_top_bottom_rows 2019-08-19 15:16:06 -07:00
Rachel Fenichel
9b8636661f Make rows populate themselves 2019-08-19 15:08:23 -07:00
Rachel Fenichel
54ef08ea04 Fix some annotations 2019-08-19 14:57:13 -07:00
kozbial
4debe8f967 Fixing eslint issue and missing getLastInput call. 2019-08-19 14:51:12 -07:00
kozbial
2d314cbd4a Reverting highlight methods restructure. 2019-08-19 14:51:12 -07:00
kozbial
17c1537a4f Updating draw for statement input and value input to use element xPos and more approriate constants. 2019-08-19 14:51:12 -07:00
Sam El-Husseini
4b4b50d76f Fix drawInternals crash (#2867) 2019-08-19 14:50:46 -07:00
Neil Fraser
096959fde9 Cleanup of last fortnight’s commits. (#2865)
No functional changes.
2019-08-19 14:07:48 -07:00
Rachel Fenichel
981761f7da Move the base Measurable class to its own file 2019-08-19 13:54:07 -07:00
Rachel Fenichel
450ac4ba15 Consider min height and min width in row measure 2019-08-19 13:30:41 -07:00
Rachel Fenichel
efdf80c49c Reset height and width at the beginning of a measure 2019-08-19 11:28:39 -07:00
Rachel Fenichel
b2ebe89493 Cleanup 2019-08-19 11:28:39 -07:00
Rachel Fenichel
88a9307cdb Move all rows into rows.js 2019-08-19 11:28:12 -07:00
Rachel Fenichel
4a3fdb83db Move rows to a new file and annotate 2019-08-19 11:28:12 -07:00
Sam El-Husseini
445419e8f8 Update css to show visual indicator of focus on dropdowndivs and widget dropdowns (#2860) 2019-08-19 10:51:17 -07:00
Monica Kozbial
a1ab4b92bd Merge pull request #2845 from moniika/moniika-render-draw-simple-warnings
Fixing basic warnings in block_render_draw_debug.
2019-08-19 10:40:25 -07:00
alschmiedt
a72950cc83 Fix cursor svg to work with new rendering (#2856) 2019-08-16 18:52:29 -07:00
Sam El-Husseini
c99734b8f9 Add valuemin and valuemax aria properties for number fields (#2850) 2019-08-16 18:41:05 -07:00
Sam El-Husseini
63f55da379 Remove last bit of closure! (#2858) 2019-08-16 18:39:25 -07:00
Sam El-Husseini
ff76ee5b0d Dropdown field with Blockly.Menu (#2832)
* Switch dropdown field from using goog.ui.Menu to Blockly.Menu
2019-08-16 18:22:05 -07:00
Rachel Fenichel
b42214abd1 Guarantee that the top and bottom rows exist 2019-08-16 17:36:02 -07:00
Rachel Fenichel
40b3f18766 Merge pull request #2851 from rachel-fenichel/annotations
Fix some compiler warnings
2019-08-16 17:30:17 -07:00
Sam El-Husseini
8cfb67187f Contextmenu with Blockly.Menu (#2834)
* Switch contextmenu  from using goog.ui.Menu to Blockly.Menu
2019-08-16 17:25:56 -07:00
Sam El-Husseini
2b26787185 Blockly menus without closure (#2831)
* Blockly Menu and MenuItem that don't rely on the closure library.
2019-08-16 17:23:14 -07:00
Rachel Fenichel
ca6e591047 Turn off debug rendering 2019-08-16 17:10:06 -07:00
Rachel Fenichel
04a77f0ef2 Fix some compiler warnings 2019-08-16 17:05:24 -07:00
Sam El-Husseini
8e4d904095 Listen to focus events on children and add a focused class in the dropdown (#2848) 2019-08-16 16:29:34 -07:00
Sam El-Husseini
ca83f97074 Colour field accessibility (#2836)
* Implement key board navigation and aria accessibility for the colour field.
2019-08-16 13:49:05 -07:00
Rachel Fenichel
803a20b6bc Merge pull request #2789 from BeksOmega/feature/FieldUtils
Extracted Common Field Support Methods Into Utils Files
2019-08-16 13:38:33 -07:00
Beka Westberg
0516122dff Added case-insensativity & safety rebuild. 2019-08-16 12:49:18 -07:00
kozbial
41e6167334 Fixing basic warnings in block_render_draw_debug. 2019-08-16 11:51:24 -07:00
Monica Kozbial
5f9e54a309 Merge pull request #2841 from moniika/moniika-misc-cleanup
Cleaning up some warnings in block_render_draw.js.
2019-08-16 11:23:15 -07:00
Beka Westberg
f1afb61694 Maybe fix mocha? 2019-08-16 10:26:01 -07:00
Beka Westberg
ae3e8895b7 Maybe fix Mocha? 2019-08-16 10:00:46 -07:00
Beka Westberg
891d23795e Corrected some language. 2019-08-16 09:57:28 -07:00
Beka Westberg
0872d022e1 Changed utils.fields -> fieldRegistry. Also removed useless tooltip requires. 2019-08-16 09:57:28 -07:00
Beka Westberg
84937a0ff6 Fixed lint error. 2019-08-16 09:57:27 -07:00
Beka Westberg
16c59d2ffc Added tests and remove jsunit fields test file. 2019-08-16 09:57:27 -07:00
Beka Westberg
cdc90f4059 Refactored field utilities. 2019-08-16 09:57:27 -07:00
Sam El-Husseini
f539dbe6f6 Add aria invalid for when a text input field is invalid (#2839) 2019-08-15 17:13:06 -07:00
Sam El-Husseini
f174f422ff Set the border size on a text input to take into account scaling. (#2837) 2019-08-15 16:23:17 -07:00
kozbial
ca357aa71f Cleaning up some warnings in block_render_draw.js. 2019-08-15 16:16:26 -07:00
alschmiedt
9b3e05e3d9 Field accessibility (#2823)
* Gives fields a chance to handle keyboard events
2019-08-15 15:44:54 -07:00