Commit Graph

2667 Commits

Author SHA1 Message Date
Monica Kozbial
40ef586260 Refactoring Ui events in core (#4418)
* Ui events base (#4370)

* Add constants for new ui event types

* Add property to indicate an event as UI event

* Click events (#4372)

* Creating new ui base class.

* Refactor theme event (#4391)

* Add themeName property to theme event

* Refactor marker move events. (#4389)

* Refactor trashcan open event (#4392)

* Refactor selected event (#4387)

* Refactor toolbox item change event (#4394)

* Refactor bubble open events (#4390)

* Refactor block drag event (#4388)

* Viewport events (#4395)

* Fix event filtering for ui events (#4401)

* Move events to new directory and rename Ui events base (#4400)

* Move events to new directory and rename Ui events base

* Add missing fromJson implementation for click event (#4410)

* Adding serialization tests for events

* Zoom controls event (#4407)

* Refactor zoom event

* Rename IS_UI_EVENT to isUiEvent
2020-11-04 14:43:54 -08:00
Sam El-Husseini
d782e2f4af Fix conflict in background CSS for dropdown div (#4431)
* Fix conflict in background CSS for dropdown div

* Fix comment
2020-11-04 14:05:36 -08:00
Anjali Pal
eff3fcc289 set data-id on block svgs for IE11 (#4425) 2020-11-02 14:08:12 -08:00
alschmiedt
f1498e7f07 Keyboard shortcuts (#4421)
* Adds shortcut registry and removes action and key map (#4398)

* Adds Shortcut tests and refactored navigation tests (#4412)

* Adds shortcut items (#4408)

* Add shortcuts for navigation (#4409)

* Add final keyboard shortcut cleanup (#4413)
2020-11-02 13:30:05 -08:00
alschmiedt
8eb794f30e Uses the ws scroll value when updating flyout (#4415) 2020-10-30 13:30:53 -07:00
Sam El-Husseini
363095a7e5 Fix graph demo (#4406)
* Fix graph demo by resetting a couple of CSS fields
2020-10-26 14:55:10 -07:00
alschmiedt
edbd6991b4 Small fixes to the toolbox (#4380) 2020-10-19 09:43:41 -07:00
alschmiedt
624e126121 Remove component file (#4379) 2020-10-16 16:47:44 -07:00
alschmiedt
a8196cbbb3 Changes flag name in registry to be more descriptive (#4375) 2020-10-16 10:01:20 -07:00
Monica Kozbial
981dc09d85 Update access level of methods in FieldTextInput (#4359) 2020-10-13 10:55:56 -07:00
Sam El-Husseini
fba35d342c Add missing require Blockly.constants (#4366) 2020-10-12 17:56:42 -04:00
michellammertink
b27231c0e3 Add Blockly.constants dependency to utils/toolbox.js (#4360) 2020-10-12 11:53:49 -07:00
alschmiedt
ae4f894233 Make private methods protected (#4365) 2020-10-12 11:20:28 -07:00
Halit Anil Donmez
c913c027c5 select text on comment open (#4349) 2020-10-12 11:15:45 -07:00
Halit Anil Donmez
a131794ef0 add deprecation warning (#4356)
* add deprecation warning

* fix indent and update deprecation date
2020-10-07 13:16:27 -07:00
Halit Anil Donmez
9bafa7e40d do value update if the value is valid again (#4351)
* do value update if the value is valid again

* update the logic at set value

* fix tests

* update logging
2020-10-07 11:05:02 -07:00
alschmiedt
a0c0b86679 Fix toolbox types (#4355) 2020-10-07 11:04:10 -07:00
Maribeth Bottorff
ba9ea757b6 Change weights of default context menu items to support easier sorting (#4344) 2020-10-02 10:34:20 -07:00
alschmiedt
64fe425944 Fix toolbox resize problem (#4340) 2020-09-30 12:55:27 -07:00
alschmiedt
e9f46aea28 Fix adding an icon in xml definition (#4336) 2020-09-29 18:04:41 -07:00
Rachel Fenichel
3bf8a38020 Delete some deprecated functions 2020-09-28 13:09:19 -07:00
alschmiedt
3d698f4bcc Block factory fix (#4327) 2020-09-28 10:42:45 -07:00
alschmiedt
b01faa09e0 Fix typo (#4324) 2020-09-25 13:52:35 -07:00
Maribeth Bottorff
4ea112fcd3 Don't undo the change events from disableOrphans (#4304) 2020-09-25 11:46:29 -07:00
alschmiedt
bdfdb2ece5 Fix jsdoc errors and warnings (#4309) 2020-09-23 13:26:58 -07:00
alschmiedt
3969f3129f Fix bug in trashcan (#4306) 2020-09-22 16:35:22 -07:00
Monica Kozbial
395a2b3fcc Don't update disabled on children of collapsed blocks. (#4302) 2020-09-21 14:33:16 -07:00
Rachel Fenichel
f76560e883 Don't update disabled on unrendered children 2020-09-21 10:44:03 -07:00
Monica Kozbial
ab5a51e2a4 Revert "Don't render children of collapsed blocks (#4264)" (#4300)
This reverts commit 96e8fc794e.
2020-09-21 10:40:01 -07:00
Monica Kozbial
c6bea7c51b Call initsvg after loading field. (#4296) 2020-09-21 10:06:43 -07:00
Monica Kozbial
96e8fc794e Don't render children of collapsed blocks (#4264)
* Partially revert collapsed block changes and add additional handling for setting children of collapsed blocks to not rendered

* Improve performance by checking if child is rendered in updateDisabled
2020-09-18 16:08:39 -07:00
alschmiedt
2523da5332 Fixes blocks flying when mutator is open (#4289) 2020-09-17 16:45:24 -07:00
alschmiedt
16980cd303 Fixes problem with dropdown scroll (#4287) 2020-09-17 11:57:24 -07:00
Sam El-Husseini
db40e44b7c Move Blockly.utils.dom.SvgElementType to Blockly.utils.Svg (#4285)
* Move SVGElementType to its own file shaving off 2.7KB
2020-09-16 14:42:58 -07:00
Maribeth Bottorff
f6688d0339 Convert toolbox position to enum (#4284)
Convert toolbox position to enum
2020-09-16 10:54:17 -07:00
alschmiedt
22d598484f Update blockToDom types to include document fragments (#4280) 2020-09-16 10:51:09 -07:00
Sam El-Husseini
d70d896a9f Fix field registry typings (#4281)
* Fix field registry types
2020-09-16 09:10:41 -07:00
Maribeth Bottorff
6017a953d1 Fix bugs related to events firing during block create (#4278)
Fix bugs related to events firing during block create and add test for expected block init behavior
2020-09-15 20:02:07 -07:00
Beka Westberg
315f135109 Fix mutators without flyouts (#4272) 2020-09-11 09:28:49 -07:00
alschmiedt
897296dce8 Adds check for isTextInput (#4262)
Necessary for developers using custom elements
2020-09-10 09:07:46 -07:00
Beka Westberg
47cc3b97b0 Add getTooltip (#4254)
* Add getTooltip

* Add tests

* Fix typings?

* Fix typings?

* PR Comments
2020-09-10 08:57:05 -07:00
Beka Westberg
c732484180 Add programmatically setting shadows Take 2 (#4215)
* Add programmatically setting shadows
2020-09-08 08:50:01 -07:00
alschmiedt
d01169fa79 Toolbox Rewrite (#4223)
Rewrite the toolbox in order to get rid of old closure code and make it easier to extend.

Co-authored-by: Maribeth Bottorff <maribethb@google.com>
2020-09-02 08:13:07 -07:00
Beka Westberg
af9be6d9c3 Update some inline docs in block.js (#4241)
* Update some inline docs in block.js

* Fix build error
2020-09-01 10:27:17 -07:00
Monica Kozbial
739b8b3adc Viewport change event (#4180)
* Adding viewport ui event emitting and tests

* comment out viewport ui event logic and add TODO for reference
2020-08-31 18:41:20 -07:00
Maribeth Bottorff
c13880d4d0 Use camel case for registry types (#4199) 2020-08-20 09:21:45 -07:00
Beka Westberg
2e2a5c230e Fix lastMarker_ disposal (#4184) 2020-08-19 13:21:44 -07:00
Sam El-Husseini
af571e27df Call apply colour when inserting a field to a block that has already been renderered (#4183) 2020-08-17 14:08:03 -07:00
Monica Kozbial
a89ff37bd8 Add checks to WorkspaceSvg dispose and fix shared Workspace tests (#4170)
* Fix workspace tests and add add checks for WorkspaceSvg dispose

* Move flyout test to WorkspaceSvg
2020-08-17 10:32:55 -07:00
Monica Kozbial
0a36117885 Replace console "WARNING" log calls with warn call (#4171) 2020-08-13 10:53:04 -07:00