Commit Graph

127 Commits

Author SHA1 Message Date
alschmiedt
468b673b73 Fix bugs (#3108)
* Fix various bugs around keyboard nav
2019-09-27 14:34:28 -07:00
Monica Kozbial
f4136fdc2a Adding test and updating TODO. (#3102)
* Adding test and updating TODO.

* changing bug number referenced in TODO
2019-09-27 11:12:37 -07:00
Sam El-Husseini
870824bc3e Workspace theme (#3093)
* Move the theme object so it's on the workspace.

* Add support for subscribing UI elements to theme component styles and changes.
2019-09-26 16:52:17 -07:00
Monica Kozbial
22e79ae496 Updating behavior of register functions and adding unregister. (#3085)
* Updating behavior of register functions and adding unregister.

* Updates jsdoc comments.
2019-09-26 13:23:45 -07:00
Neil Fraser
ddb04a3bc2 Partial code review of nav (#3091)
* Partial code review of nav

Had a few minutes free.

* Move getTopStackBlock to block

This is a generally useful function.
2019-09-26 10:19:40 -07:00
Rachel Fenichel
269f0dc381 Enable eslint rule spaced-comment
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
Monica Kozbial
e1e9513e86 Disconnect child block always for block.dispose(/* healStack */ true) (#3073)
* Disconnecting child block even if it cannot be connected to parent block.

* Bump disconnected child block.

* Added method for behavior on failed connection and updated expected behavior of unplug in unit tests.

* Removing obsolete TODO and calling new helper method in tests.
2019-09-25 10:47:29 -07:00
Beka Westberg
593383e18a Changed variable field to use configuration (#3065)
* Changed variable field to use new configuration.
2019-09-23 11:14:03 -07:00
Beka Westberg
9e5df6216a Fixed comment ownership. (#2923)
* Moved comment icons to use a model-based system. The block holds the model of the comment, and the comment icon holds a reference to it.
* Reorganized the setVisible function.
* Changed how xml.js serializes and deserializes comments.
2019-09-20 13:16:07 -07:00
Sam El-Husseini
cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
Beka Westberg
1c3db256fa Added angle field config (#3038)
* Added angle field configuration.
2019-09-19 16:15:20 -07:00
alschmiedt
6516363469 Change setLocation to setCurNode (#3051)
* Change setLocation to setCurNode
2019-09-19 15:15:14 -07:00
Beka Westberg
093467aed1 Added More Procedure Unit Tests (#2630)
* Added more procedure unit tests.

* Cleanup from rebase.

* Cleanup.
2019-09-18 16:14:06 -07:00
alschmiedt
8b3d48b148 Update demo (#3033)
* Update the cursor demo to use the basic cursor

* Change <br> to <br />
2019-09-18 12:01:50 -07:00
alschmiedt
9004346f7d Remove moving on the workspace (#3029)
* Remove moving on the workspace
2019-09-17 10:58:34 -07:00
Beka Westberg
92eea22628 Label Field Config (#2984)
* Added label field configuration.
2019-09-16 16:53:06 -07:00
alschmiedt
2c98ecaed6 Update APIs and Add New Cursor Look (#3009)
* Updates methods to be private in navigation.js

* Update cursor with new look
2019-09-16 12:33:43 -07:00
Beka Westberg
e05e26ab45 Fixed insertFieldAt (#2939)
* Fixed insertFieldAt.
* Updated tests to reflect upcomming config changes.
2019-09-16 11:11:18 -07:00
Beka Westberg
b149aabd16 Image Field Config (#2983)
* Added image field configuration.
2019-09-16 11:05:32 -07:00
Beka Westberg
8b9816abcb Text Field Config (#2986)
* Added text input field configuration.
2019-09-16 10:08:46 -07:00
Beka Westberg
af81239c42 Number Field Configuration (#2985)
* Added number field configuration.
2019-09-16 09:52:08 -07:00
Neil Fraser
23caa12571 Error is a constructor, ‘new’ is not required. 2019-09-12 18:02:59 -07:00
Sam El-Husseini
f3f3329355 Fix configure method (#2915)
* Fix configure method.
2019-09-12 17:01:03 -07:00
alschmiedt
ec07a36e44 Update cursor api (#3002)
* Move over to new implementation for cursor
2019-09-11 18:16:05 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
Sam El-Husseini
09d2a167f9 Fix travis by running browser tests in headless mode (#3001)
* Fix travis by running browser tests in headless mode
2019-09-11 17:25:22 -07:00
alschmiedt
4a80889ef1 Enter accessibility (#2982)
* Fix shift clicking on a block

* Add tests for toggle keyboar nav
2019-09-09 16:41:06 -07:00
alschmiedt
e8f328aa28 Fix enable accessibility (#2968)
* Enables accessibility mode should make the cursor visible
2019-09-05 14:05:52 -07:00
alschmiedt
6e8d200857 Refactors modify and add tests (#2955)
* Refactors modify and add tests
2019-09-04 10:58:47 -07:00
alschmiedt
e620b1fde6 Action list (#2959)
* Support keyboard navigation in read only mode
2019-09-03 16:11:06 -07:00
alschmiedt
cc16bd46b4 Disconnect child block before trying to connect (#2928)
* Disconnect child block before trying to connect

* Check original connections for errors before trying to connect
2019-08-29 14:02:15 -07:00
alschmiedt
d8b431ae61 Fixes not being able to move block with parent (#2920)
* Fixes not being able to move block with parent
2019-08-27 10:12:49 -07:00
Sam El-Husseini
f23b659898 Remove this.text_ (#2910)
* Remove this.text_ and have every field handle its own properties.
2019-08-26 10:56:36 -07:00
alschmiedt
a14275c04b Update connect to work with multiple connecting blocks (#2905)
* Update connect to work with multiple connecting blocks

* Make logic for connect more readable
2019-08-26 10:14:18 -07:00
Beka Westberg
821edb7e22 Changed Checkbox Field to New Configuration Paradigm (#2876)
* Moved checkbox field to new configuration paradigm.
2019-08-22 13:55:41 -07:00
Sam El-Husseini
6d2a0ac31b Remove closure dependency from tests (#2889)
* Remove goog.testing dependency and use mocha as a test runner instead of goog.testing.jsunit
2019-08-22 11:10:53 -07:00
alschmiedt
7bba4fa59c Moves the cursor to correct location when block is deleted (#2887)
* Moves the cursor to correct location when block is deleted

* Moves cursor on block mutation
2019-08-21 16:33:16 -07:00
Sam El-Husseini
705730df0c Convert connection_db jsunit tests to mocha (#2872)
* Convert connection_db jsunit tests to mocha
2019-08-21 13:35:20 -07:00
Sam El-Husseini
f15f9ebd13 Convert metrics jsunit test to mocha (#2871)
* Convert metrics jsunit test to mocha
2019-08-20 20:15:39 -07:00
Sam El-Husseini
eada00a692 Convert theme jsunit test to mocha (#2874) 2019-08-20 20:14:38 -07:00
Rachel Fenichel
3e6c0a07e3 Merge pull request #2849 from BeksOmega/feature/AbstractFieldConfig
Changed Abstract Field to New Configuration Paradigm
2019-08-20 13:31:24 -07:00
Sam El-Husseini
3d9b8267b5 Convert names_test from jsunit to mocha. (#2873) 2019-08-20 13:17:40 -07:00
Sam El-Husseini
419451932a Convert gesture junit tests to mocha (#2875) 2019-08-20 13:17:28 -07:00
Beka Westberg
0d482c6488 Changed colour field to new configuration paradigm. 2019-08-20 09:44:14 -07:00
Beka Westberg
4f411d2859 Added handling of dynamic functions passed to opt_config. 2019-08-18 07:54:54 -07:00
Beka Westberg
9fde484a87 Moved setTooltip tests into the customization suite. 2019-08-18 07:54:54 -07:00
Beka Westberg
1e73f69cea Changed abstract field to new configuration paradigm. 2019-08-18 07:54:54 -07:00
alschmiedt
50580febfa Add timeout for mocha tests (#2847) 2019-08-16 18:30:35 -07:00
Beka Westberg
0516122dff Added case-insensativity & safety rebuild. 2019-08-16 12:49:18 -07:00
Beka Westberg
680321fb1d Don't try to be fancy. 2019-08-16 12:25:22 -07:00