* refactor(tests): Move and rename prepare.js, blockly.mjs
Since prepare.js and blockly.mjs are going to be needed for running
all tests in uncompiled mode (not just the playgrounds), move them
tests/. Further, rename prepare.js to bootstrap.js to better reflect
its purpose.
* feat(tests): Introduce BLOCKLY_BOOTSTRAP_OPTIONS
Provide a mechanism for web pages that use bootstrap.js to control
what is loaded and how.
* fix(tests): Use the blockly repository path for all script src= URLs
Previously the (non-advanced) playground was only correctly loadging
on localhost because you can put an arbitrary number of "../"s in front
of a relative URL and it just takes you to the root directory.
* fix(tests): Don't use template literals in bootstrap.js
This is necessary (but not necessarily sufficient) to be able to
load the file in IE 11.
* fix(tests): Throw error if attempting to bootstrap in node.js
* feat(tests): Make bootstrap.js more configurable.
* Terminology change: use "compressed" and "uncompressed" to describe
what Closure Compiler calls "compiled" and "uncompiled", to reduce
confusion with the compilation that will be done by tsc.
* Get the list of modules to bootstrap (in compressed mode), or
scripts to load (in compressed mode) from BLOCKLY_BOOTSTRAP_OPTIONS,
to allow calling scripts to to specify exactly what to load.
* feat(tests): Use a proper quote function
We need to generate string literals. Best to use a quote function
instead of concatenating on quote marks withou escaping. Copy a
well-tested one from Code City.
* feat(tests): Support an additionalScripts option
This is a list of scripts to load (in order) once the required modules
have been bootstrapped.
We do this using goog.addDependency to make the first script depend
on the required modules, then each subsequent script depend on the
previous one, and then finally goog.bootstrapping the last such script.
* refactor(tests): Remove special handling of msg/messages.js
* refactor(tests): Use additionalScripts for all script loading
Use additionalScripts option for all script loading in
playground.html and advanced_playground.html.
* refactor(tests): Use bootstrap instead of uncompressed in Mocha tests
Use tests/bootstrap.js instead of blockly_uncompressed.js to load
blockly in uncompressed mode in the Mocha tests.
This entails adding a new item, despFiles, to BLOCKLY_BOOTSTRAP_OPTIONS,
to allow tests/deps.mocha.js to be loaded at the appropriate point.
Mention of blockly_uncompressed.js is removed from
tests/mocah/.mocharc.js; it's not clear to me what effect the "file:"
directive in this file might have previously had and I was not able to
find documentation for it on mochajs.org, but in any case removing it
appears to have had no ill effect.
* refactor(tests): Use bootstrap instead of uncompressed in generator tests
This entails adding an additional check in bootstrap so as to load
uncompressed when loading from a file: URL, since these are not
localhost URLs - though in fact the generator tests run equally well
in compressed mode, albeit against (for now) the previously-check-in
build products rather than the live code.
* refactor(test): Use bootstrap.js in multi_playground.html
This removes the last use of load_all.js, so remove it.
* chore(tests): Delete blockly_uncompressed.js
Its function has now been entirely subsumed by tests/bootstrap.js,
so remove it and update any remaining mentions of it.
Also fix formatting and positions of some comments in playground.html.
* fix(tests): Rewrite bootstrap sequencing code
An earlier commit modified the generated <script> to use
goog.addDependency to trick the debug module loader into loading
.additionalScripts (via goog.bootstrap), but it turns out there is
a small problem: scripts like msg/messages.js have undeclared
dependencies on the Blockly module, and without a call to
goog.require('Blockly') in them they can end up being run before
the Blockly module is fully loaded.
(This problem only occurs when there are ES Modules, rather than
merely goog.modules, in the mix.)
Fix this by adding a script, bootstrap_helper.js, to be loaded
options.requires and any options.additionalScripts that makes an
explicit call to goog.require for each of option.requires.
Also refactor the code so that instead of generating a loop which
calls goog.addDependency, we generate the addDependency calls
directly. This makes debugging a bit easer as we can use the browser's
dev tools to inspect the generated calls in the DOM tree.
* fix(tests): Prevent spurious transpilation warnings
For some reason when the debug module loader encounters ES modules
it starts to complain about being unable to transpile some ES202x
features in other (non-ESM) modules, even though it doesn't normally
try to transpile those.
Since uncompressed-mode testing is almost exclusively on modern
browsers we don't care about transpiling these features, so suppress
the warnings instead.
* refactor(tests): Rename blockly.mjs to bootstrap_done.mjs; simplify
Since blockly.mjs is no longer returning just the exports object
from core/blockly.js (see PR #5995), it might be better named after
its actual purpose: to wait for bootstrapping to be done.
Remove all the code that was used to pass the blockly.js exports
object along from the bootstrap callback to the blockly.mjs export,
since there's no reason to go to a lot of trouble to set a local
variable named Blockly to the same value as a global variable named
Blockly.
(Something like this may be needed again in future, but certainly in
a different form.)
* chore(tests): Use freshly-build files in compressed mode.
Use the freshly-built build/*_compresssed.js files when bootstrapping
in compressed mode, rather than using the checked-in files in the
repository root.
This helps ensure that compressed and uncompressed mode will be
testing (as closely as possible) the same code.
* chore(tests): Rename BlocklyLoader to blocklyLoader; record compressed
- Rename the BlocklyLoader global to blocklyLoader (since it is not
a class constructor).
- Create it regardless of whether we are bootstrapping in
uncompressed or loading compressed via <script> tags.
- Record which we are doing as .compressed, and use this property
to choose playground background colour.
* chore(tests): Resolve comments for PR #6214
Mostly documentation changes, but notably renaming blocklyLoader to
bootstrapInfo.
* Revert "chore(tests): Use freshly-build files in compressed mode."
This reverts commit de8d356838.
...and rename Blockly.blocks.all (blocks/all.js) to
Blockly.libraryBlocks (blocks/blocks.js
BREAKING CHANGE: (only) because the exports object from the
`blocks_compressed.js` chunk will be accessed as
`Blockly.libraryBlocks` instead of `Blockly.blocks.all` when the
chunk is loaded in a browser via a `<script>` tag. There will
be no changes visible when the chunk is loaded via ES module
`import` or CJS `require`.
* chore(build): Add "all" modules for blocks & generators
These modules (Blockly.blocks.all and Blockly.<Generator>.all) will
be the entry points for the corresponding chunks.
They also make it easier to pull in all the modules in each package
(e.g. for playground and tests).
It is necessary to set the Closure Compiler dependency_mode to
SORT_ONLY as otherwise it tries to compile the "all" modules before
their dependencies, which fails.
The only impact on the _compressed.js files is the addition of a short
string to the very end of each file, e.g.:
var module$exports$Blockly$JavaScript$all={};
* chore(deps): Add devDependency on closure-calculate-chunks
* feat(build): First pass at chunked complation
Add a new buildCompiled gulp target (npm run build:compiled) that
uses closure-calculate-chunks to do chunked compliation of core/,
blocks/ and generators/ all in a single pass.
This work is incomplete: the resulting *_compressed.js files don't
(yet) have UMD wrappers.
* chore(build): Generate chunk wrappers
A first pass; this does not have support for a namespace object yet.
* refactor(build): Use chunked compilation by default
Remove old "compressed" gulp tasks in favour of new "compiled" task.
* chore(build): Remove cruft from buildCompiled
Remove unneeded `done` parameter and commented-out options that had
been cargo-culted from the old build pipeline.
* fix(build): Fix test failures caused by new build pipeline
- Exclude closure/goog/base.js from compiler input; use
externs/goog-externs.js instead.
- Have the build:debug and build:strict targets only build the first
chunk (blockly_compressed.js).
- Fix namespace entries for blocks and generators.
* fix(build): Fix build failures on node v12
closure-calculate-chunks requires node.js v14 or later.
When running on node.js v14 or later have getChunkOptions save
the output of closure-calculate-chunks to
scripts/gulpfiles/chunks.json. When running on older versions of
node.js have it use this checked-in, cached output instead of
attempting to run closure-calculate-chunks.
* chore(build): enable --rename_prefix_namespace
This will allow modules in blocks/ and generators/ to use
goog.require to obtain the exports object of goog.modules from
core/.
* fix(build): Always build all chunks
The previous commit enabled --rename_prefix_namespace option to
Closure Compiler, and this causes the buildCompressed target to
work fine when run without --debug or --strict, but adding either
of those flags (as for example when `npm test` runs
`npm run build:debug`) causes an issue:
- Because of many compiler errors in blocks/ and generators/,
a previous commit added a hack to only build the first chunk
when doing debug/strict builds.
- When asked to build only one chunk, Closure Compiler ignores the
--rename_prefix_namespace flag, because it 'correctly' infers
that there are no later chunks that will need to access global
variables from the first chunk.
- This causes a test failure, because `npm test` first runs
`npm run build`, which generates a valid blockly_compressed.js,
but this is then overrwritten by an invalid one when it next runs
`npm run build:debug`.
(The invalid one is missing all `$.` prefixes on 'global' variables,
including on Blockly, so the wrapper's last two lines -
"$.Blockly.internal_ = $;" and "return $.Blockly" - fail.)
The fix is to add appropriate @suppress annotations to blocks/*.js and
generators/**/*.js and then remove the first-chunk-only hack.
* refactor(build): Just build once
Since the previous commit caused `npm run build:debug` to do
everything that `... build:compressed` does - and to produce
byte-for-byte identical output - it doesn't make sense to run
both when testing. To that end:
- Replace the build:debug and build:strict package scripts that
did `gulp buildCompressed --...` with new scripts build-debug
and build-strict that do `gulp build --...` instead.
(The target names are changed so as to extend our existing naming
convention as follows: a target named "foo:bar" does some sub-part
of the job done by target "foo", but a target named "foo-bar" does
all the work of the target "foo" with some extra options.)
- build:debug:log and build:strict:log are similarly replaced with
build-debug-log and build-strict-log.
- Modify run_all_tests.js to just do `npm run build-debug` instead of
doing both `npm run build` and `npm run build:debug`.
- Also remove the 'build:blocks' script that should have been removed
when the buildBlocks gulp task was deleted previously.
* refactor(build): Compile with base_minimal.js instead of base.js
Introduce a (very!) cut-down version of closure/goog/base.js named
base_minimal.js that is used as input to the compiler as an
alternative to using externs/goog-externs.js (which will be deleted
once the buildAdvancedCompilationTest target has been updated).
This will allow use of goog.setTestOnly since it will now exist in
compiled mode, and allows the changes made in 5b112db to filter
base.js out of the files for the first chunk to be reverted.
(It also obliges a change to the compiled-mode check in blockly.js.)
* fix(build): Fix buildAdvanceCompilationTest
- In build_tasks.js:
- Replace the old compile() function with a new one factored out of
buildCompiled().
- Update buildAdvancedCompilationTest to use the new compile()
and other helpers created in the meantime.
- Remove no-longer-used maybeAddClosureLibrary().
- Remove externs/{block,generator,goog}-externs.js, which are no longer
used by any compile pipeline.
- Update core/blockly.js to fix issue with detection of compiled mode
when using ADVANCED_OPTIMISATIONS.
- Update only other use of globalThis, in core/utils/xml.js, to
consistently treat it as a dictionary object.
- Update instructions in tests/compile/index.html.
This commit is sort-of-a-prerequisite to #5602; test:compile:advanced
was previously working but the generated `main_compresed.js` would
throw errors upon loading.
* chore: rename module Blockly.blocks.Lists to ....lists
All the other Blockly.blocks modules have lower-case names. This
one being named with an upper-case initial appears to have been a
typo on my part.
This module name is not mentioned anywhere else in the source code
(though it will be soon!) so no other files need to be edited.
Further, it does not appear anywhere in the last release (which
before PR #5696) so it is not necessary to add an entry in
renamings.js for this change.
* chore(build): Rationalise deps.js, deps.mocha.js
* Include blocks/*.js (Blockly.blocks.*) in tests/deps.js, since
these modules are used in the playground. (They are goog.provide
modules loaded via <script> tags, so their absence from deps.js
does not cause errors - but it will when they are migrated to
goog.module and must be loaded via goog.require.)
* Filter the entries in deps.mocha.js so that it includes only the
additional mocha test modules (i.e. those not mentioned in deps.js
already).
* refactor: Load blocks and generators using goog.require
* Add indexing setting for JavaScript Generation
Adding setting to allow for switching between zero and one based indexing for Blockly Blocks such that the generated code will use this flag to determine whether one based or zero based indexing should be used. One based indexing is enabled by default.
* Updating js lists to do zero and one based index
Updated generated JavaScript to change depending on whether one based indexing is enabled or not.
* Updating js text to do zero and one based index
Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.
* Start of python indexing
Start of work on allowing one and zero indexing for generated python for lists.
* Fixing bug and lint fixed
Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing
* Converting from if to switch statements
Comverting if statements to switch statements when appropriate and adding spacing.
* Modified sublist JavaScript generation
Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).
* Stripping unecessary ids
Removing ids from xml file.
* Localisation updates from https://translatewiki.net.
* Fix typo in flyout.js (#403)
* Fix typo in flyout.js (#402)
* Localisation updates from https://translatewiki.net.
* Add indexing setting for JavaScript Generation
Adding setting to allow for switching between zero and one based indexing for Blockly Blocks such that the generated code will use this flag to determine whether one based or zero based indexing should be used. One based indexing is enabled by default.
* Updating js lists to do zero and one based index
Updated generated JavaScript to change depending on whether one based indexing is enabled or not.
* Updating js text to do zero and one based index
Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.
* Fixing bug and lint fixed
Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing
* Converting from if to switch statements
Comverting if statements to switch statements when appropriate and adding spacing.
* Modified sublist JavaScript generation
Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).
* Stripping unecessary ids
Removing ids from xml file.
* Updating generator test
Modifying sublist test and re-formatting spacing between blocks.
* Updating js lists to do zero and one based index
Updated generated JavaScript to change depending on whether one based indexing is enabled or not.
* Updating js text to do zero and one based index
Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.
* Fixing bug and lint fixed
Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing
* Converting from if to switch statements
Comverting if statements to switch statements when appropriate and adding spacing.
* Modified sublist JavaScript generation
Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).
* Stripping unecessary ids
Removing ids from xml file.
* Localisation updates from https://translatewiki.net.
* Localisation updates from https://translatewiki.net.
* Updating js lists to do zero and one based index
Updated generated JavaScript to change depending on whether one based indexing is enabled or not.
* Fixing bug and lint fixed
Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing
* Modified sublist JavaScript generation
Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).
* Stripping unecessary ids
Removing ids from xml file.
* Updating generator test
Modifying sublist test and re-formatting spacing between blocks.
* Adding tests for indexing and extra cases
Adding tests for indexing with custom block to adjust number based on what indexing is being generated.
* Adding tests and renaming tests
Adding tests for sublist and renaming tests.
* Fixes for order for sublists
Fixes so that parenthesis are generated properly for index for sublist
* Cleaning up test generated code
Changing order returned for unit test adjust index function to generate less unecessary parenthesis.
* Adding tests for order
Adding tests for order, relevant for methods that use index from start (because 1 is added)
* Fixing JS order for getIndex and setIndex
Changing to the correct order type when calling valueToCode in JS generation for getIndex and setIndex.
* Fixed unittest adjustIndex
Fixed uninttest adjustindex to also check whether the ONE_BASED_INDEXING variable has been defined to ensure proper behaviour.
* Fixing lint and formatting for JS/lists
Making line fixes and changing an if/elseif to case statement.
* Tests added to include case for bug found
Added tests with sublist combinations of different where's for the two indices after bug for this found in python.
* Adding and renaming tests
Adding test case for creating a sublist that encompasses the whole list but uses # and #-end instead of first last (applicable for python). Also, renaming tests.
* Adding contant and fixing python lists bugs
Adding contant for ONE_BASED_INDEXING and fixing bugs in python for lists.
* Fixing test get random
Fixing test get random to take into account indexing for return value.
* Adding indexing checkbox to test page
Adding checkbos on test page so that code can be generated for one and zero based indexing. Languages that are generated with zero based indexing that do not have it implemented will fail tests as expected.
* Fixing unittest getremove random
Fixing unittest getremove random to take into account the return value based on indexing.
* Change comparison for getremove random test
Fixed comparison to equal for the return value for getremove random.
* Fixing bugs with lists zero-indexing
Fixing getIndex and getSublist methods to pass for zero-indexed tests.
* Adding test cases and formatting
Adding test cases to text tests, reordering a couple list test, and formatting block spacing.
* Fixing unittest expected value
Fixing expected value fore unit tests for sublist.
* Cleanup
Removing obvious comments, formatting fixes, and naming in generated code in JS.
* Helper function for Python lists
Adding helper function for casting to int for indices.
* Expanding helper to reduce duplicated code
Expanding helper method to also get the property with the correct order and check indexing to reduce duplicated code.
* Cleaning up JS indexing with helper function
Adding helper function for indexing and used it in lists and text.
* Moving helper function and formatting fixes
Moving helper function, formatting fixes, and changing some generated code variable names.
* Fixing python generation for text
Fixing all failinng tests for python and using new helper method.
* Lint fixes and order in indexOf
Making lint fixes and correcting returned order in indexOf.
* Python variable renaming
Renaming a few generated variables.
* Fixing comment and order
Fixing comment to list Blockly.Block type and fixing order because it could be higher.
* Switching back to if
Switching switch back to if statements because there weren't enough cases to warrant for a switch.
* Adding order and fixing lists for Dart
Adding if null operator to operator precedence for Dart. Also, fixing lists implementation to pass unit tests and adding zero-indexing functionality.
* Formatting and lint fixes
Formatting and lint fixes
* Dart text fixed
Fixing Dart text generation to pass unit tests.
* Changing back to variable
Changing switch condition back to variable.
* Fixing ORDER_OVERRIDES
Inner and outer order was switched .
* Adding bug with order caused by generator change
Flooring order before comparision because of how the order constants were modified.
* Adding list tests
Adding tests for additional cases for lists/
* Adding comment for dart order
Adding comment for Dart ORDER_IF_NULL operator.
* Formatting fixes
Formatting fixes for line indentation.
* Fixing PHP order and lists generation
Fixing PHP order constants and fixing lists so that they pass unit tests.
* Fixing tests
Removing duplicate unit test
* Adding text tests
Adding tests for text.
* Renaming variable and removing unused variable
Renaming variables from exceptionIndex to errorIndex and removing unused at variable.
* Adding missing function call to test
Adding missing funciton call to test that was causing tests to fail when they shouldn't.
* Fixing PHP text generation
Fixing PHP text code generation so it passes unit tests.
* Formatting fixes
Cleaning up code, renamiing a variable.
* Fixing failing subsequence tests
Fixing JS code that failed for sublist/substring tests.
* Fixing intentation
Fixing indentation.
* Fixing Dart sublist/substring
Fixing sublist/substring to include condiiton where FROM_START (and not throw error by mistake) when zero-indexed.
* Adding order subtraction test
Adding test for checking order for subtraction x- (y - z) x - (y + z).
* Updating to new PHP power operator
Updating from pow function to ** operator to clean up code.
* Updating to new removeWhere
Updating removeMatching to removeWhere because new version of Dart now use removeWhere.
* Fix for lua rounding assertequals
Adding check for number in equlity check for comparing number for floats.
* Adding test for copy of list
Adding test that checks the list is copied when a sublist is made first-last.
* Formatting and order fixes
Fixing formatting such as indentation and order fixes.
* Adding comment for clarity
Adding comment about how Lua code generation is not supporting zero indexing.
* Changed variable names in code
Changed variable names to follow style guide and changed for loop variable from n to i as is typical.
* Reducing unecessarily generated functions and renaming variables
Reducing number of generated functions using gensym_ by adding parameters to provided function. Renaming variables to make functions more readble.
* Fixing sublist order and sort variable
Fixing order used for valueToCode for sublist and renaming list variable in sort to match rest of code..
* Fixing order constant order
Removing operator () that was incorrect and addiung ~,
* Fixing order and indentation
Fixing order return fro create lists blocks and fixing indentationn for string array.
* Fixing order and renaming variables
Fixing order to be the correct strength and renaming variables to be more readable/
* Changing assert blocks for unit tests
Changing assert blocks to have a value input instead of a field so there is more flexibility in writing tests.
* Cleaning up and adding missing order tests
Adding tests for order for paramters for list blocks that weren't being tested to uncover bugs. Test were also cleaned up/reorganized/renamed to be more readable and shorter vertically (but lines wider horizontally).
* Compile error fix and order in Dart generation.
Fixing compile error in generated code and incorrect order in get sublist for Dart.
* Fixing typo in getIndex and invalid parameter name
Fixing type in getIndex where list code should have been appended but instead an undefined variable was added. The parameter in lists_sort was changed to my_list because list is a reserved word in python.
* Fixing order, parenthesis bug, and variable declaration in Lua
Fixing incorrect order in Lua. Fixing bug caused by missing parenthesis around ternary operator in code. Variable code was declared with JavaScript syntax, this was fixed to be valid in Lua.
* Adding tests and formatting tests
Adding missing test for order in text/lists. Changing spacing/order of tests and updating comments.
* Fixing error in code
Changing to correct function call in empy tests and changing test name that was duplicated to be more clear.
* Renamed test helper function
* Fixing order and renaming variable in JS generator
Fixing order for charAt and renaming variable in code list_sort from listCode to list to be consistent with rest of code.
* Fixing order for dart text
Fixing roder for dart charAt
* Cleaning up generated code for Dart getIndex
Cleaning up generated code for Dart getIndex so that helper functions aren't generated unecessarily and adding comments.
* Fixing Dart remove random error
Fixing error caused by remove random implementation in Dart. index should have been x but instead was length - x.
* Fixing unit test blocks
Fixing Lua unit test block that should have just returned the number and removing unecessary checks in other blocks because the constant was defined.
* Fixing Lua assert equals block
string.format was throwing an error if one of the values happened to be a boolean.
* Adding tests for create text with number
Adding test for create text with numbers as parameters
* Fixing lua unit test block
Lua unit test block should have added 1
* Removing indexing setting for Lua tests
Removing setting index setting for Lua generation because it is always one-indexed.
* Fixing order and create text
Fixing failing test caused by improper order and fixed create text to properly convert to string when there is one element.
* Running linter on generator code
Running linter on generator code and fixing spacing/indentation problems.
* Editing comments and removing uneeded parenthesis
Editing and adding comments and removing uneeded parenthesis around ternary operator condition.
* Fixing order and changing variable names
Fixing orders that were incorrect and changing variable names to be more descriptive and consistent across code.
* Adding comment about list support and fixes for PHP
Adding comment about how lists are not fully supported for PHP. Adding missing order to PHP and fixing order errors throughout. Fixing regex for variable matching in lists. Cleaning up variable names to be more readable and consistent with other parts of code.
* Reducing complexity for getremove/remove in JS
Reducing complexity in generated code for getremove/remove in JavaScript by replacing unecessary helper function.
* Fixing spacing before inline comments
Ensuring there are two spaces before inline comments.
* Changing JS list copy for clarity
Changing JavaScript list copy to use slice(0) instead of concat for clarity and to use the same pattern as the other sublist methods.
* Changing generated variable name tmp_x
Changing tmp_x to tmpX to follow closer to the correct style for JavaScript.
* Prefixing empy lines between comment text
Prior to this change, comments with an empty line between text did not have a comment prefix before it, resulting in comment blocks that seemed disjoined although they were for the same block. This change affects how the prefix line function works so that those lines will have the prefix (if applicable) while still taking into account the trailing newline character.
* Changing for loops variable names
Changing most for loops to use i as the variable name (or j if applicable) or changing name to be more readable.
* Simplifying provided subsequence function
Simplifying subsequence function to generate a simpler function depending on where combination instead of a larger complex function that works for all where combinations.
* Style fixes
Fixing indentation, comments, and other formatting-type changes based on pull request comments.
* Fixing indentation
Fixing indentation and removing an extra newline.
* Fixing PHP mode implementation
Fixing PHP mode implementation to properlyu return multiple modes if applicable.
* Fixing line too long
Wrapping lines in php/math.js with lines longer than 80 characters.
* Wrapping long lines
Wrapping lines that are too long.
* Changing boolean casing
Changing boolean casing to be lowercase.
This is based on the JS generator, with a lot of inspiration from Ellen
Spertus's blockly-lua: https://github.com/espertus/blockly-lua
All unit tests pass with Lua 5.3.2.
