Chang Min Bark
4cdca28fe5
fix: added id to rendered ws comments; made getCommentById public; added blocklyDraggable class to ws comments ( #8358 )
2024-07-15 18:39:39 -07:00
Aaron Dodson
21a73c463f
fix: correctly report the pre-resize-drag size to workspace comment size change listeners ( #8240 )
...
* fix: correctly report the pre-resize-drag size to workspace comment size change listeners
* chore: run formatter
* refactor: implicitly use the presence of preResizeSize to identify a drag.
2024-07-02 14:42:47 -07:00
John Nesky
9a0619aa2a
fix: Drag and Resize events for workspace comments ( #8217 )
...
* feat: Added a comment_drag event.
* Add workspace comment resize events.
* Addressing PR feedback.
* Fixed chai imports in new test files.
* Addressing more PR feedback.
2024-06-26 12:16:56 -07:00
Neil Fraser
fcdb8fc33d
fix: Normalize CSS between comment types ( #8161 )
...
Merge the CSS so that both comment types (block and workspace) are the same -- other than a border.
2024-05-20 18:59:24 +02:00
Neil Fraser
70ca676c24
fix: Properly size comments. ( #8158 )
...
* Properly size comments.
Fixes multiple rendering and sizing issues across different browsers.
Tip: `text-overflow: hidden;` is not legal CSS and did nothing.
Resolves #8142
2024-05-20 09:30:38 -07:00
Beka Westberg
36b75696a2
fix: comment text area bottom border hidden ( #8152 )
2024-05-20 09:03:59 -07:00
Beka Westberg
69db8a63d6
fix: comment size not respecting collapsed-ness ( #8136 )
...
* fix: comment size not respecting collapsed-ness
* chore: fix tests the only way I know how, by adding explicit clock ticks
2024-05-17 13:23:13 -07:00
Maribeth Moffatt
e4b734c0db
fix: change cursor to grab on ws comment bar
2024-05-16 17:54:28 -07:00
Beka Westberg
93c4d75fbd
fix: comment highlight being positioned incorrectly in RTL ( #8044 )
2024-04-19 11:33:25 -07:00
Beka Westberg
69c5557e4f
chore: fix comments being resizable when readonly ( #8043 )
2024-04-19 11:15:56 -07:00
Beka Westberg
7246bbc0d1
fix: comment text input size in samples ( #8042 )
2024-04-19 08:37:35 -07:00
Beka Westberg
70f3f52911
fix: CSS for selected collapsed comments ( #8039 )
2024-04-17 09:48:43 -07:00
Beka Westberg
e1cbddd860
feat: visual comment selection ( #7996 )
...
* feat: add visually highlighting selected comment
* chore: TSDoc
2024-04-05 13:39:20 -07:00
Beka Westberg
3988e13fbc
chore: fix comment colours disappearing when dragging ( #7978 )
2024-04-02 14:37:54 -07:00
Beka Westberg
3ea330b981
fix: comment view styling ( #7965 )
2024-03-27 11:19:00 -07:00
Beka Westberg
d01f9a73fe
fix: comment position in RTL ( #7934 )
...
* fix: how comments are laid out in RTL
* fix: comment positioning with JSON
* fix: comment positioning with XML
2024-03-22 10:46:42 -07:00
Beka Westberg
5462b21b15
fix: comment have XML save and load new workspace comments classes ( #7931 )
...
* fix: have XML save and load new comment classes
* chore: fix imports to resolve circular dependencies
* chore: add round-trip tests
* chore: skip failing test
* fixup: PR comments
2024-03-20 16:25:41 -07:00
Beka Westberg
30127db35f
fix: comment min size ( #7915 )
...
* feat: add min and max to size
* fix: properly calculate the minimum size of the comment
* fix: inline docs
2024-03-11 20:57:47 +00:00
Beka Westberg
fc4228ce03
feat: add comment view (for workspace comments, and block comments for partners) ( #7914 )
...
* feat: add basic comment view
* feat: add icons to comment
* chore: add text area to comment view
* feat: add getting size
* feat: add collapsing comment view
* feat: add setting editability
* feat: add location and text hooks.
* feat: add changing the size
* feat: resizing
* feat: add collapsing
* feat: add disposing
* feat: add cursors
* feat: add moving to the front
* chore: split construction into subprocedures
* chore: split resizing into subprocedures
* feat: handle RTL
* chore: add doc comments throughout file
* chore: reduce css specificity where possible
* chore: format
* feat: add remove change listener methods
* chore: add tests for listeners
* feat: add disposing accessors
* chore: add coordinate system notes
* chore: add issues to TODOs where possible
* chore: remove suite.only
2024-03-11 12:12:35 -07:00
