Commit Graph

2448 Commits

Author SHA1 Message Date
Sam El-Husseini
95aadbffb1 [zelos] Set a maximum width for dynamic connection shapes. (#3685)
* Set a maximum width for dynamic connection shapes.

* Only render the left side connection if a block has a statement input
2020-02-07 15:13:51 -08:00
alschmiedt
e1bb1d667e Add back setters for theme (#3674) 2020-02-07 09:20:21 -08:00
alschmiedt
88ad660c51 Remove check for same theme when refreshing (#3672)
* Remove check for same theme when refreshing
2020-01-30 16:05:24 -08:00
Sam El-Husseini
97d0001512 Unhighlight current item when hovering over disabled menu items (#3655) 2020-01-30 16:04:21 -08:00
alschmiedt
513e85bf4a Checks keyboardAccessibility flag before rendering (#3671) 2020-01-30 14:11:47 -08:00
Sam El-Husseini
4a94dc8a85 Unpack self-closing tags when converting domToText (#3665)
* Unpack self-closing tags when converting domToText
2020-01-27 15:32:12 -08:00
Monica Kozbial
6dbb023a1d Fixing path typo. (#3663) 2020-01-27 11:19:21 -08:00
Monica Kozbial
e2b510662c Fixing typo on "programmatically". (#3654) 2020-01-24 15:10:22 -08:00
Sam El-Husseini
8475976103 Fix start hats (#3651) 2020-01-24 13:02:27 -08:00
Beka Westberg
025d087e6a fix: Fixed insertion preview logic. And fixed markers not handling typed statements. (#3526)
* Added planned functions.

* Added default getConnectionPreviewMethod method.

* Moved show preview logic into their new functions.

* Fixed default getConnectinPreviewMethod logic.

* Reverted to lastConnectionInRow call (for output connections) for behavioral backwards-compat.

* Added zelos logic.

* Removed unused functions, and added docs.
2020-01-24 07:49:31 -08:00
Sam El-Husseini
f6b5e9ebb4 Add test block for field image with a click handler (#3642) 2020-01-23 16:19:24 -08:00
alschmiedt
ee9a55ec79 Fix flyouts (#3645)
* Set toolboxPosition after options have been parsed

* Final toolbox position update
2020-01-23 14:23:25 -08:00
Monica Kozbial
fdb1d71e88 Editable field spacing (#3635)
* Substituting checks for isEditable.

* Add isField checks.

* Add parentheses for casting.

* Update value of isEditable and use for spacing.

* Changing to double equals.
2020-01-23 13:10:33 -08:00
Monica Kozbial
26a11faf49 Update CSS rules for cursor. (#3627) 2020-01-22 11:41:59 -08:00
Sam El-Husseini
5727a62c62 Revert on blur for text input fields as it interferes with combo boxes (#3634) 2020-01-22 11:23:33 -08:00
Sam El-Husseini
58b690728d Fix rtl placement of arrow in non-borderbox dropdown fields (#3629) 2020-01-22 11:07:59 -08:00
Sam El-Husseini
af84e6a40c Zelos rename highlightfilter (#3630)
* Rename highlight filter to selected filter

* Update comment
2020-01-22 11:07:45 -08:00
alschmiedt
130297f795 Add colour methods back to blockSvg (#3626)
* Add colour methods back to blockSvg
2020-01-22 07:34:46 -08:00
Sam El-Husseini
70f42b3395 Fix parsing and passing of workspace options around Blockly (#3616) 2020-01-21 13:29:03 -08:00
Monica Kozbial
c84ee46a89 Setting default options in workspace constructor. (#3592)
* Setting default options in workspace constructor.

* Changing logic for parsing workspace options.

* Adding gridPattern declaration to options and updating options handling for workspace.

* Addressing PR comments.

* Moving objects to constructor.

* Using constructor instead of casting for Blockly.Options.

* fix eslint

* Adding types.

* Change in type.

* eslint fix.

* Fix typings.
2020-01-17 15:16:20 -08:00
alschmiedt
1a2fb6ddf0 Add new build scripts (#3608)
* Add new build scripts

* Fix pr comments
2020-01-16 16:52:20 -08:00
Monica Kozbial
1afff3c439 Use baseline for positioning rendered connection. (#3609) 2020-01-16 16:07:38 -08:00
Sam El-Husseini
671162b79a Fix RTL appendDomToWorkspace positioning. (#3601)
* Fix RTL appendDomToWorkspace positioning.
2020-01-16 13:43:41 -08:00
Sam El-Husseini
f8000e00dc Use selected option instead of selected index to cache current selected value in field. (#3602) 2020-01-16 13:33:45 -08:00
Sam El-Husseini
6c6296d74a Use setAttribute for setting the id instead of block.id as IE doesn't serialize the id otherwise. (#3604) 2020-01-16 13:33:24 -08:00
Sam El-Husseini
6a4251b11a Add constant for field dropdown arrow padding (#3581)
* Add constants for field dropdown arrow padding for more control over where the arrow shows up.
2020-01-14 13:27:47 -08:00
Sam El-Husseini
180926ee77 Fix duplicate variable model type (#3594)
* Resolve duplicate empty var type when returning list of variableModel's types.
2020-01-14 13:10:34 -08:00
Sam El-Husseini
6bd6bdefbc Upgrade closure + support for closure-library dependency (#3554)
* Upgrade closure and include hints on how to include the closure library in the build.

* Revert build-uncomprssed.

* Sort uncompressed.

* nit: comment.
2020-01-14 12:59:43 -08:00
alschmiedt
f6b9deab4d Moves setCollapsed to after mutation (#3591) 2020-01-14 09:45:02 -08:00
Sam El-Husseini
899162c420 Fix zelos top row spacer height when it precedes a statement input. (#3587) 2020-01-13 18:39:24 -08:00
Sam El-Husseini
4f80bd6cbf Simplify zelos tight nesting logic (#3583) 2020-01-13 15:47:54 -08:00
alschmiedt
7e34d94610 Fixes blockly games blocks being black (#3579)
* Fixes blockly games blocks being black
2020-01-13 13:34:29 -08:00
Sam El-Husseini
8013f80251 Start hat support in zelos. (#3580)
* Start hat support in zelos.
2020-01-13 13:22:49 -08:00
Sam El-Husseini
1661d640d6 Geras inline alignment of rows + max bottom row width (#3575)
* Add a desired width getter method for input rows. Override in geras to fix the width of the bottom row and statement input to a max width.
2020-01-13 10:40:52 -08:00
Sam El-Husseini
8b50df01c0 Fix zelos statement input alignment for spacers (#3578) 2020-01-13 10:32:49 -08:00
Monica Kozbial
8f787a3e41 Re-rendering block in setMutator. (#3574) 2020-01-13 10:32:22 -08:00
Sam El-Husseini
1924b2674a Treat a statement input as the end of the statement row. (#3577)
* Reduce spacing for editable fields when they appear right before a statement input.
2020-01-11 17:34:45 -08:00
Sam El-Husseini
e1472a3600 Detect undefined elements in the debugger and remove undefined elem if a row has no elements when adding spacers. (#3576) 2020-01-11 17:33:20 -08:00
Monica Kozbial
c2087e61f5 Using shapeFor to determine connections shape for marker_svg. (#3573) 2020-01-10 13:32:44 -08:00
Monica Kozbial
9b8fa7a177 Using shapeFor for notch and tab paths. (#3572) 2020-01-10 13:31:49 -08:00
Sam El-Husseini
fe555d9021 Rename input connection to connectionModel (#3571)
* Remove input measurable's connection property and rename references to connectionModel.
2020-01-09 18:09:15 -08:00
Sam El-Husseini
20e55b67d7 Fix bug with dropdown menu propagating the opening click event to a menu item (#3570)
* Prevent dropdown field menu from propagating a click event onto a menu item when the dropdown appears above the field
2020-01-09 18:08:29 -08:00
Sam El-Husseini
e162f3b45f [zelos] Don't add next notch in a statement input if the connection block doesn't have a next connection (#3562)
* Don't add a next notch for statement inputs that have a connected block without a next connection.
2020-01-09 08:37:20 -08:00
Sam El-Husseini
e530f209cd Fix bug in zelos tight nesting code. (#3565) 2020-01-08 08:47:10 -08:00
Monica Kozbial
26db9167db Move of render contant START_HAT into ConstantProvider. (#3563)
* Move of render contant START_HAT into ConstantProvider.
2020-01-07 16:18:05 -08:00
Sam El-Husseini
c3867443f5 Fix value to stack width measurement (#3559)
* Include width of connected block in value to stack width measurement.
2020-01-07 16:05:34 -08:00
Sam El-Husseini
7ac83a318b Remove Firefox fix for avoiding dropdown scrollbars as it no longer repros (#3560) 2020-01-07 16:05:08 -08:00
Beka Westberg
f10c48648e Changed mutator getWorkspace to package. (#3561) 2020-01-07 14:47:28 -08:00
Sam El-Husseini
8151b94c2c Add output shape on a block. Add squared shape. (#3558)
* Add output shape on the block. Add squared shape.
2020-01-07 14:10:51 -08:00
Beka Westberg
6d1bb201f7 feat: Improved procedure arg interaction. (#3527)
* feat: Improved procedure arg interaction.

* Added docs.

* Fixed typos and typings.

* Fixed typings?

* Changed visibility to private.
2020-01-07 13:55:46 -08:00