Commit Graph

58 Commits

Author SHA1 Message Date
Sam El-Husseini
986e965be8 Private/protected visibility cleanup (#3263)
* Fix a number of private visibility issues
2019-10-16 11:48:09 -05:00
Neil Fraser
01b6992efd Normalize to one spelling of color/colour. 2019-10-16 09:46:47 -07:00
Neil Fraser
2eaabd180d Minor cleanup in keyboard nav (#3264)
* Clean cursor code

Some obvious inefficiencies that jumped out while randomly browsing the compiled code.

* Typos

* Multiplying by minus one.
2019-10-16 08:19:37 -05:00
Thomas Ballinger
b913295028 restart cursor animation on cursor move (#3226) 2019-10-15 09:01:03 -07:00
alschmiedt
cf04a9529b Fix compilier warnings for keyboard nav (#3196)
* Fix compilier warnings for keyboard nav
2019-10-08 11:34:39 -07:00
alschmiedt
a1b18368f2 Remove dead code from ast node (#3183) 2019-10-07 14:20:37 -07:00
Rachel Fenichel
608ce7b93c Merge pull request #3133 from BeksOmega/fixes/ConnectionTracking
Connection Tracking Pt 3: Changed connections to use 'tracked_' property
2019-10-07 11:05:10 -07:00
Sam El-Husseini
74ecb94078 Remove last instance of Object.assign (#3161) 2019-10-04 13:06:58 -07:00
Neil Fraser
b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Beka Westberg
5aaab251a3 Changed all other known 'hiding' references to 'tracking'. 2019-10-01 19:02:02 -07:00
alschmiedt
468b673b73 Fix bugs (#3108)
* Fix various bugs around keyboard nav
2019-09-27 14:34:28 -07:00
alschmiedt
244bbe554b More navigation cleanup (#3100) 2019-09-26 11:13:47 -07:00
Neil Fraser
ddb04a3bc2 Partial code review of nav (#3091)
* Partial code review of nav

Had a few minutes free.

* Move getTopStackBlock to block

This is a generally useful function.
2019-09-26 10:19:40 -07:00
Rachel Fenichel
269f0dc381 Enable eslint rule spaced-comment
Fix up all remaining violations and turn the rule on.
2019-09-25 16:04:05 -07:00
alschmiedt
2c757aeb4d Cleanup navigation file (#3074)
* Cleanup navigation file
2019-09-25 13:57:42 -07:00
alschmiedt
f3b4fc0732 Fix interaction between mouse and keyboard (#3070) 2019-09-23 11:07:59 -07:00
alschmiedt
c16ea62b58 A bunch of small bug fixes (#3067) 2019-09-23 08:59:50 -07:00
alschmiedt
23b31c7ea8 Cursor rtl (#3062)
* Fix rtl for cursor svg & small bug fix
2019-09-20 14:34:18 -07:00
alschmiedt
8e22e45bca Fix inserting into middle of stack from flyout (#3058) 2019-09-20 09:00:44 -07:00
Sam El-Husseini
cb564053b3 Merge toolbox navigation (#3054)
* Merge both types of keyboard navigation (with and without accessibility mode).
2019-09-19 16:36:39 -07:00
alschmiedt
6516363469 Change setLocation to setCurNode (#3051)
* Change setLocation to setCurNode
2019-09-19 15:15:14 -07:00
alschmiedt
8003426316 Cleanup compile warnings (#3050)
* Cleanup jsdoc issues

* Cleanup compile warnings

* Fix jsdocs

* Removed unnecessary cast
2019-09-19 14:34:25 -07:00
kozbial
c533a0d943 Setting cursor and marker directly in Workspace and adding check to setCursor/setDrawer. 2019-09-19 10:38:23 -07:00
Sam El-Husseini
22cf08d16c Don't insert disabled blocks from the flyout. (#3046)
* Don't insert disabled blocks from the flyout.
2019-09-18 16:42:25 -07:00
alschmiedt
8b3d48b148 Update demo (#3033)
* Update the cursor demo to use the basic cursor

* Change <br> to <br />
2019-09-18 12:01:50 -07:00
alschmiedt
9004346f7d Remove moving on the workspace (#3029)
* Remove moving on the workspace
2019-09-17 10:58:34 -07:00
alschmiedt
2c98ecaed6 Update APIs and Add New Cursor Look (#3009)
* Updates methods to be private in navigation.js

* Update cursor with new look
2019-09-16 12:33:43 -07:00
Neil Fraser
5650fe51a2 Typos. 2019-09-12 18:24:48 -07:00
alschmiedt
ec07a36e44 Update cursor api (#3002)
* Move over to new implementation for cursor
2019-09-11 18:16:05 -07:00
Sam El-Husseini
fb74181589 Add Object values helper method to fix IE (#3005) 2019-09-11 17:44:41 -07:00
Sam El-Husseini
8ab51c8639 Remove closure base file dependency (#2976)
* Trim down closure's base dependency even further by removing the dependency on closure's base file.
2019-09-11 17:30:51 -07:00
alschmiedt
4a80889ef1 Enter accessibility (#2982)
* Fix shift clicking on a block

* Add tests for toggle keyboar nav
2019-09-09 16:41:06 -07:00
alschmiedt
e8f328aa28 Fix enable accessibility (#2968)
* Enables accessibility mode should make the cursor visible
2019-09-05 14:05:52 -07:00
alschmiedt
6e8d200857 Refactors modify and add tests (#2955)
* Refactors modify and add tests
2019-09-04 10:58:47 -07:00
alschmiedt
e620b1fde6 Action list (#2959)
* Support keyboard navigation in read only mode
2019-09-03 16:11:06 -07:00
alschmiedt
4b4b14dbbc Update insert to use new moveAndConnect method (#2940)
* Update insert to use new moveAndConnect method

* Changes jsdoc
2019-08-30 14:37:30 -07:00
alschmiedt
72d73f779f Fix cursor rendering (#2932)
* Fixes rendering bugs for cursor and marker
2019-08-29 16:10:11 -07:00
alschmiedt
cc16bd46b4 Disconnect child block before trying to connect (#2928)
* Disconnect child block before trying to connect

* Check original connections for errors before trying to connect
2019-08-29 14:02:15 -07:00
alschmiedt
a27e059f2c Fixes shift clicking on block (#2927)
* Fixes shift clicking on block

* General cleanup

* Use new renderer api
2019-08-29 10:18:34 -07:00
alschmiedt
d8b431ae61 Fixes not being able to move block with parent (#2920)
* Fixes not being able to move block with parent
2019-08-27 10:12:49 -07:00
alschmiedt
a14275c04b Update connect to work with multiple connecting blocks (#2905)
* Update connect to work with multiple connecting blocks

* Make logic for connect more readable
2019-08-26 10:14:18 -07:00
alschmiedt
7bba4fa59c Moves the cursor to correct location when block is deleted (#2887)
* Moves the cursor to correct location when block is deleted

* Moves cursor on block mutation
2019-08-21 16:33:16 -07:00
Neil Fraser
096959fde9 Cleanup of last fortnight’s commits. (#2865)
No functional changes.
2019-08-19 14:07:48 -07:00
alschmiedt
a72950cc83 Fix cursor svg to work with new rendering (#2856) 2019-08-16 18:52:29 -07:00
alschmiedt
9b3e05e3d9 Field accessibility (#2823)
* Gives fields a chance to handle keyboard events
2019-08-15 15:44:54 -07:00
Sam El-Husseini
4a10ff833d Remove all calls to goog.events.KeyCodes (#2824)
* Remove all calls to goog.events.keyCodes
2019-08-14 14:14:49 -07:00
Sam El-Husseini
f118d6de88 No closure toolbox (#2819)
* Update the toolbox to not rely on closure and instead use the built in Blockly.tree component
2019-08-14 13:48:21 -07:00
alschmiedt
00be6a6381 Make the navigation namespace lowercase (#2812) 2019-08-13 14:00:49 -07:00
alschmiedt
74fa3bb71a Initial commit for changing key mappings (#2787)
* Added ability to easily change key mappings
2019-08-13 13:37:01 -07:00
Neil Fraser
939bbd072b Lint 2019-08-02 11:00:40 -07:00