Commit Graph

1188 Commits

Author SHA1 Message Date
Sam El-Husseini
6326830e85 Don't handle a touch gesture event if the gesture has been cancelled. 2018-03-05 09:50:38 -08:00
Sam El-Husseini
fda7122b86 Fix lint 2018-03-02 16:00:30 -08:00
Sam El-Husseini
8d9dad8898 Remove unnecessary code, better styling. 2018-03-02 15:33:44 -08:00
Sam El-Husseini
b32dbcdb94 Pointer Event fixes ensuring they replace all mouse events, and fix comment focusing issue. 2018-03-02 15:01:58 -08:00
Rachel Fenichel
7ea0e1b8c3 Merge pull request #1680 from google/rachel-fenichel-patch-1
Mark bindEvent_ and bindEventWithChecks_ package instead of private
2018-03-02 13:51:21 -08:00
Rachel Fenichel
a9a696117b Merge pull request #1683 from google/rachel-fenichel-patch-3
Make getEventWorkspace_ protected.
2018-03-02 13:51:00 -08:00
Rachel Fenichel
e22923df75 Make getEventWorkspace_ protected.
Fixes 12 warnings
2018-03-01 18:32:15 -08:00
Rachel Fenichel
a5db01559f Mark unbindEvent_ package instead of private
Fixes ~20 compiler warnings.
2018-03-01 18:15:37 -08:00
Rachel Fenichel
7356c664a0 Merge pull request #1614 from rachel-fenichel/bugfix/double_events
Don't register mouse events if pointer events are supported
2018-03-01 18:04:51 -08:00
Rachel Fenichel
5920e6aa39 Mark bindEvent_ and bindEventWithChecks_ package instead of private
Fixes 50 compiler warnings.
2018-03-01 17:56:49 -08:00
Rachel Fenichel
6565b2103b Merge pull request #1672 from rachel-fenichel/split_event_files
Split event files
2018-03-01 13:15:53 -08:00
Rachel Fenichel
870813747a Fix misspelled annotation. 2018-03-01 13:01:44 -08:00
Rachel Fenichel
615c403b44 Use @nocompress annotation to fix advanced compilation. 2018-03-01 12:35:55 -08:00
Rachel Fenichel
4c9b602523 Move event classes into separate files, and update requires accordingly 2018-02-27 17:47:33 -08:00
Rachel Fenichel
2f55c0c2be move events.js into an events folder inside core 2018-02-27 17:22:01 -08:00
Neil Fraser
10dbf2cc6d Random typos.
@rachel-fenichel LGTMs in person.
2018-02-21 17:47:01 -08:00
Andrew n marshall
9cd6b1ec24 Print a warning if JSON color value is invalid. (#1639)
Ignores the invalid color, defaulting to black.
2018-02-21 13:55:32 -08:00
Rachel Fenichel
e3700c02e4 Merge pull request #1651 from AnmAtAnm/rm-todos-in-docs
Moving TODO from doc comment to single line comment.
2018-02-21 11:06:31 -08:00
Rachel Fenichel
13cb64392f Fix some JsDoc annotations (#1650) 2018-02-21 11:01:01 -08:00
Andrew n marshall
91e2d03eea Moving TODO from doc comment to single line comment. 2018-02-21 10:58:52 -08:00
Andrew n marshall
f45c6faf05 Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText() (#1638)
Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText()

The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
2018-02-16 16:51:18 -08:00
Rachel Fenichel
8c8412af74 Just check whether the window exists, instead of using goog.events.BroswerFeature 2018-02-16 15:01:13 -08:00
Rachel Fenichel
f3a4664dea Delete extra variables at the end of a procedure argument edit 2018-02-15 17:18:23 -08:00
Rachel Fenichel
e5a2ef30f2 Switch to goog.events.BrowserFeature.POINTER_EVENTS 2018-02-15 11:26:06 -08:00
Neil Fraser
73417b8317 Reduce size of XML by omitting empty variable tag. 2018-02-14 11:22:55 -08:00
Rachel Fenichel
2a00055e57 Don't register mouse events if pointer events are supported 2018-02-14 10:42:27 -08:00
Mark Gibson
54f0e06e21 Customising field types using a register of fields #1584 (#1594)
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Andrew n marshall
e1e3f273d2 Remove forceRerender() from FieldDropDown.
Errantly forced whole block to rerender, including fields that
had not yet been initialized.

Fixes #1609
2018-02-13 15:01:33 -08:00
Rachel Fenichel
5e0928e4f3 Break circular dependency 2018-02-13 10:44:07 -08:00
Rachel Fenichel
3463799d83 Merge pull request #1599 from rachel-fenichel/bugfix/sb-1373
Don't allow block deletion in the flyout.  Make copy-paste always copy to the main workspace
2018-02-12 14:43:40 -08:00
Andrew n marshall
dc7783ee01 Warn conflicts with Blockly.Generator.prototype (#1603)
Console warning if block prototypeName conflicts with Blockly.Generator.prototype.
2018-02-12 13:44:54 -08:00
Rachel Fenichel
f471a23b2b Add comment 2018-02-12 13:25:07 -08:00
Rachel Fenichel
57852f0249 Don't allow block deletion in the flyout. Make copy-paste always copy to the main workspace. 2018-02-08 17:23:22 -08:00
Rachel Fenichel
6a018515af Make WorkspaceSvg.refreshToolboxSelection_ package instead of private 2018-02-08 16:45:19 -08:00
Rachel Fenichel
e58c8a32d4 Merge pull request #1590 from rachel-fenichel/feature/bubble_dragger
Create a Dragger for moving bubbles around
2018-02-07 14:19:23 -08:00
Mark Gibson
2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson
6ab7cd25f5 Missing semi-colon! 2018-02-07 12:44:01 +00:00
Mark Gibson
d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel
9d2cb829a9 Move code into the bubble dragger where possible 2018-02-06 18:56:26 -08:00
Rachel Fenichel
7acd4133aa Remove unused code in the bubble dragger. 2018-02-06 18:07:21 -08:00
Rachel Fenichel
68914be67d Wire up bubble dragging, with coordinate problems 2018-02-05 16:57:44 -08:00
Rachel Fenichel
3b168f5370 Fix #1538 2018-01-26 15:20:19 -08:00
Rachel Fenichel
870219e750 Get rid of the last indentation lint (that is checked by eslint) and turn indentation back to erroring instead of warning. 2018-01-25 17:33:43 -08:00
Rachel Fenichel
f19d7a811c Merge pull request #1562 from rachel-fenichel/bugfix/matching_names
Fix #1559
2018-01-25 17:08:46 -08:00
Rachel Fenichel
68ff863ea9 Fix indentation 2018-01-25 13:00:08 -08:00
Rachel Fenichel
cb75946a3c Set indent problems to warnings, and fix all errors. 2018-01-25 12:43:11 -08:00
Rachel Fenichel
794520e225 Add documentation 2018-01-24 17:17:31 -08:00
Rachel Fenichel
96e2d7d102 Fix #1559 2018-01-24 17:05:58 -08:00
Rachel Fenichel
c6881677ad Merge pull request #1561 from rachel-fenichel/cleanup/lint
Indentation lint that blocks moving to eslint 4.0
2018-01-24 16:48:18 -08:00
Rachel Fenichel
2b7b4bf3af More lint 2018-01-24 16:40:07 -08:00