Commit Graph

83 Commits

Author SHA1 Message Date
Rachel Fenichel
615c403b44 Use @nocompress annotation to fix advanced compilation. 2018-03-01 12:35:55 -08:00
Mark Gibson
54f0e06e21 Customising field types using a register of fields #1584 (#1594)
Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.
2018-02-14 10:14:59 -08:00
Mark Gibson
2308ae8c22 Remove underscore from fromJson_ 2018-02-07 18:18:35 +00:00
Mark Gibson
d40ef474ae See issue #1486 - adds fromJson_ fn to every Blockly.Field, removing Block.newField*FromJson_ helpers 2018-02-07 12:22:26 +00:00
Rachel Fenichel
fb897d7786 Even more lint. 90 errors remaining. 2018-01-23 18:33:30 -08:00
Rachel Fenichel
06ae9ade8e Don't update the field until all checks pass 2018-01-19 15:49:39 -08:00
Rachel Fenichel
7314bdfb3a Fix #1499 and add some validation 2018-01-17 16:54:12 -08:00
Rachel Fenichel
b593d44379 Make the potential variable map null when not needed 2018-01-12 14:51:02 -08:00
Rachel Fenichel
80b397f532 Respond to more review comments 2018-01-10 17:27:43 -08:00
Rachel Fenichel
a43b0e7010 Respond to commit comments and make compressed blockly work again 2018-01-10 17:02:02 -08:00
Rachel Fenichel
5d6d7519cd Remove some TODOs; add a variable-referencing block to the simple playground flyout 2018-01-08 14:14:26 -08:00
Rachel Fenichel
b342fb2121 Fix problem with clearing flyout after a variable was deleted. 2018-01-02 16:42:28 -08:00
Rachel Fenichel
6218750207 Fix events for variable fields on new blocks; fix tests 2017-12-19 11:28:23 -08:00
Rachel Fenichel
e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel
f0b7190603 Clean up TODOs and move potential variable map to the flyout workspace 2017-12-13 11:50:08 -08:00
Rachel Fenichel
7e411b5428 Fix checkmarks when the variable dropdown is open. 2017-12-13 11:50:08 -08:00
Rachel Fenichel
61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel
1ce46ab88b Move getOrCreateVariable to variables.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
f37386d2bf Fix default variable name 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3ae7ac1cd4 Make unique variable names in the flyout 2017-12-13 11:50:07 -08:00
Rachel Fenichel
19939dc16a All but XML tests now pass 2017-12-13 11:50:07 -08:00
Rachel Fenichel
3728cfed45 Update tests in workspace_test. Get rid of renameVariable 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c55b6afc6f Fix tests in field_variable_test.js 2017-12-13 11:50:07 -08:00
Rachel Fenichel
47457d1683 Fix renaming 2017-12-13 11:50:07 -08:00
Rachel Fenichel
c157412fc5 Can now create a variable with the button in the flyout; drag a block with a variable out of the flyout; handle default variable names; and import and export variables 2017-12-13 11:50:07 -08:00
RoboErikG
a83a625e3b Rebuild core and fix indents in field_variable.js (#1500)
After the addition of dynamic variables blockly_uncompressed needed
to be rebuilt for the playground. Also fixes some leftover missing
indents.
2017-12-08 10:46:20 -08:00
Tianwei Du
492462e1d4 Develop (#1481)
* variables_dynamic

* make test , and i18n

* Issue #1470

* Blockly.Constants.VariablesDynamic.CUSTOM_CONTEXT_MENU_VARIABLE_MUTATION
to make sure setCheck before event trigger

* Update built files from develop.

* fix copyright ,quotes , comments ,  and optimize some flow.

* quotes,change UI , change category custom name

* single setter , remove mutator , colour typo , typed variables create button message

* undo the indent edits.
2017-12-08 08:53:24 -08:00
Neil Fraser
e100c66659 Linting. 2017-10-24 14:06:29 -07:00
Neil Fraser
4262b09002 Resolve 106 warnings. 2017-10-24 14:06:29 -07:00
picklesrus
5518873389 Revert "Remove all all instances calling setValue on variable fields with the name instead of the id" (#1296)
* Revert "Create WorkspaceViewport class (#1291)"

This reverts commit 6c00d77c9e.

* Revert "Remove all all instances calling setValue with name. (#1254)"

This reverts commit 8e8b6b27af.
2017-08-28 16:55:44 -07:00
marisaleung
8e8b6b27af Remove all all instances calling setValue with name. (#1254) 2017-08-24 14:34:01 -07:00
marisaleung
733d869f8e Add VariableType checks. 2017-07-20 16:47:37 -07:00
marisaleung
170b16706f Modularize Rename Variable prompt and allow custom context menus for flyout. 2017-07-06 15:41:18 -07:00
marisaleung
15d47840b1 Fire field variable change event with variable value, not name. 2017-06-29 11:24:25 -07:00
marisaleung
3c8e0ebbeb Dropdown Create does not create a missing variable twice. 2017-06-27 16:51:19 -07:00
marisaleung
d852a2b116 In DropdownCreate check for Msg.DELETE_VARIABLE. 2017-06-09 16:22:25 -07:00
marisaleung
aff9c4867c Correctly named block events called. 2017-06-08 15:44:43 -07:00
marisaleung
0040ff636c Field Variable setValue() looks up variable. 2017-06-06 15:29:28 -07:00
marisaleung
5415c899d7 Merge pull request #1124 from marisaleung/develop_appease_lint
Appease eslint: semicolons and such.
2017-05-26 14:30:40 -07:00
CoryDCode
e2ee3aa9c9 Setting up accessible Blockly for Closure compilation. (#1134)
Moving closure compilation into the build file.

Fixing up goog.requires for accessible blockly. Adding accessible to the build script.
2017-05-26 10:43:02 -07:00
marisaleung
a6f85cec53 Appease eslint: semicolons and such. 2017-05-25 13:44:06 -07:00
marisaleung
7603f9aa69 Require VariableModel in field_variable.js. 2017-05-23 13:36:24 -07:00
marisaleung
6492f2988a Assign variable UUID to field_variable dropdown. 2017-05-15 10:43:53 -07:00
marisaleung
2bb258165a Names are correctly fetched from VariableModels! 2017-05-09 08:50:11 -07:00
marisaleung
d903b5e86b VariableMap and functions added. 2017-05-03 10:51:24 -07:00
CoryDCode
537bf17b7d Adding the remove variable modal and functionality to accessible Blockly. (#1011) 2017-03-30 11:31:31 -07:00
Rachel Fenichel
4152542c2f Fix some lint errors 2017-02-03 14:01:18 -08:00
Andrew n marshall
10108cc697 jsdoc corrections (#874) 2017-01-26 17:33:55 -08:00
Rachel Fenichel
08efd1381c Merge pull request #640 from rachel-fenichel/feature/disallow_shadow_variables
disallow variables on shadow blocks
2016-11-03 16:59:07 -07:00
Neil Fraser
917b8ff542 Lint and style tweaks. 2016-11-02 17:11:41 -07:00