Sam El-Husseini
6425287daa
Support getting sizes of elements that are not visible ( #2786 )
...
* Support getting sizes of elements that are not visible
2019-08-08 21:09:15 -07:00
Monica Kozbial
f2562c80d8
Merge pull request #2784 from moniika/moniika-rtl-image-flip
...
Adding logic to flip FieldImages in RTL with flipRtl flag set.
2019-08-07 13:15:16 -07:00
kozbial
a47177af28
fixing spacing
2019-08-07 12:24:09 -07:00
kozbial
11813c706c
Remove flipRtl path for icon.
2019-08-07 12:20:15 -07:00
Sam El-Husseini
36135ac62b
Fix RTL text field positioning bug by ensuring a reflow ( #2779 )
2019-08-07 10:54:36 -07:00
Sam El-Husseini
5ada490eca
Cherry pick npm distribution change to develop ( #2785 )
2019-08-07 10:53:53 -07:00
Beka Westberg
654467e9ac
Added disposed = false properties to fields, connections, and blocks. Changed applicable unit tests from isNotOk -> isFalse.
2019-08-07 07:17:41 -07:00
Beka Westberg
6f03634730
Moved disposed into finally block.
2019-08-07 07:11:17 -07:00
Beka Westberg
057cee51f8
Added disposed property to blocks (for use in unit tests).
2019-08-07 07:07:30 -07:00
Beka Westberg
a4b4f09071
Fixed connection dispose jsdoc.
2019-08-07 07:07:30 -07:00
Beka Westberg
8921fa96a9
Removed redundant connection disposal code from block.
2019-08-07 07:07:30 -07:00
Beka Westberg
49405a88bd
Changed connections to handle disposing of connected blocks.
2019-08-07 07:07:29 -07:00
Sam El-Husseini
f34f2beac7
Remove all calls to goog.style ( #2781 )
...
* Remove dependency on goog.style
2019-08-06 14:54:13 -07:00
kozbial
d4b12343d6
Adding logic to flip FieldImages in RTL with flipRtl flag set.
2019-08-06 14:43:18 -07:00
Rachel Fenichel
5deedc8f53
Merge pull request #2783 from rachel-fenichel/field_corrected_size
...
Remove getCorrectedSize for fields
2019-08-06 13:45:44 -07:00
Rachel Fenichel
40ba284c3f
Change constant
2019-08-06 13:40:06 -07:00
RoboErikG
dac4ae2e78
Don't try to zoom flyouts and mutators ( #2772 )
...
* Don't try to zoom flyouts and mutators
Fixes #2752
Flyouts and mutator workspaces don't have enough info to handle
zooming correctly, so they were throwing errors if you pinched them.
This adds a check to quit a zoom early if in either of those. We
might want to revisit later if we should support zooming on them.
* Add TODO
2019-08-06 13:05:01 -07:00
Rachel Fenichel
ed245a3c9e
Remove dealWithOffsetFields
2019-08-06 11:44:03 -07:00
Rachel Fenichel
c6463acc70
Cleanup and comments
2019-08-06 11:03:53 -07:00
Sam El-Husseini
9e4e909baa
Inject Blockly version into binaries ( #2750 )
...
* Inject the Blockly version in package.json into compressed Blockly builds.
2019-08-06 10:55:24 -07:00
Rachel Fenichel
3802a0c960
Remove getCorrectedSize for fields
2019-08-05 16:01:50 -07:00
kozbial
2ece7a7c53
Refactoring to pass boolean isRtl rather than whole RenderInfo object for debug render helper methods.
2019-08-05 14:08:26 -07:00
kozbial
5208ddfc03
Updating debug rendering for RTL blocks.
2019-08-05 14:08:26 -07:00
Sam El-Husseini
9203517f3d
Center text field input when editing ( #2776 )
...
* Center text field input when editing
2019-08-05 11:23:47 -07:00
Monica Kozbial
3c0bfa17c3
Merge branch 'develop' into moniika-render-collapsed
2019-08-02 14:38:47 -07:00
kozbial
eb3cb76300
Addressing PR comment.
2019-08-02 14:16:52 -07:00
Neil Fraser
939bbd072b
Lint
2019-08-02 11:00:40 -07:00
kozbial
9ba91980e5
Addressing PR comments and refactoring path constants.
2019-08-01 13:01:57 -07:00
kozbial
b98b433dff
Reverting blockly.js edit.
2019-08-01 11:43:23 -07:00
kozbial
3a983c53e1
Reverting extra files touched by eslint.
2019-08-01 11:42:00 -07:00
Neil Fraser
e77a9b7e81
Change parseFloat() to Number()
...
Number() is a bit less forgiving than parseFloat() and is more likely to generate NaN rather than some random number. An audit of each case shows nowhere that parseFloat()’s features are needed.
2019-08-01 11:36:58 -07:00
Neil Fraser
11f6c5a631
Fix angle picker when 'Infinity' is typed in.
...
Previously 'NaN' would be generated, which is not a legal value.
2019-08-01 11:36:58 -07:00
kozbial
c6b0d961a1
Running eslint on modified files.
2019-08-01 11:33:27 -07:00
kozbial
b1d86a57aa
Updating logic to handle rendering collapsed blocks.
2019-08-01 11:29:55 -07:00
Roy van Schaijk
bcadd836b2
Make the TabList exclude hidden fields ( #2764 )
...
* Make the TabList exclude hidden fields
* Stop using private variable
2019-08-01 11:14:52 -07:00
Monica Kozbial
9cc0cb6881
Merge pull request #2760 from moniika/moniika-update-centerline
...
Fix bottom row element centerlines
2019-08-01 10:47:46 -07:00
alschmiedt
1ba6bb887d
Fixes undo ( #2766 )
2019-08-01 10:05:56 -07:00
kozbial
e2f12f8262
Fixing edge case for centerline computation for bottom row elements.
2019-07-31 20:12:51 -07:00
Rachel Fenichel
5294d0ab71
Merge pull request #2753 from rachel-fenichel/remove_console_spam
...
Remove logs from rendering
2019-07-31 15:55:03 -07:00
Rachel Fenichel
41c686e733
Use constants
2019-07-31 13:17:20 -07:00
Rachel Fenichel
37250f4ce4
Fix connection highlight rendering
2019-07-31 12:42:34 -07:00
Rachel Fenichel
bcdd691796
Make updating the connection locations called the same way for both renderers
2019-07-31 11:45:32 -07:00
Rachel Fenichel
113c24509b
Remove logs from rendering
2019-07-31 11:14:24 -07:00
Rachel Fenichel
16f0992764
Enable operator-linebreak rule
2019-07-31 09:45:27 -07:00
Rachel Fenichel
b4109d7c43
Add no-multi-spaces rule
2019-07-31 09:33:54 -07:00
alschmiedt
9466c6b7df
Move marker creation to the workspace ( #2742 )
...
* Move marker creation to the workspace
2019-07-31 09:04:53 -07:00
alschmiedt
62f4871e45
Fixes copy paste to work with the marker ( #2740 )
...
* Fixes copy paste to work with the marker
2019-07-31 07:49:02 -07:00
Neil Fraser
45e5fb4157
More JSDoc and lint corrections
2019-07-30 17:00:40 -07:00
Neil Fraser
6aedfab4d1
Misc JSDoc fixes. ( #2747 )
2019-07-30 16:28:48 -07:00
Rachel Fenichel
47574c670d
Merge pull request #2745 from rachel-fenichel/render/constants
...
Position notches
2019-07-30 14:05:39 -07:00
