Commit Graph

53 Commits

Author SHA1 Message Date
Aaron Dodson ce8e7921a2 Move alert/confirm/prompt to a new file, dialog.js (#5457)
* Migrate prompt/alert/confirm to dedicated module

* Update core/blockly.js to pass through calls to prompt/alert/confirm to core/dialog.js

* Update calls to Blockly.prompt/alert/confirm to dialog.prompt/alert/confirm

* Fix typo and errant redeclaration of Blockly.prompt

* Clarify JSDoc on customizing Blockly.dialog.alert/confirm/prompt
2021-09-14 08:19:53 -07:00
Christopher Allen a6471c4276 Rename Blockly.utils.IdGenerator to idGenerator and move Blockly.utils.genUid to there (#5441)
* Rename Blockly.utils.IdGenerator -> idGenerator
* Move genUid from Blockly.utils to Blockly.utils.idGenerator
2021-09-09 17:08:44 +01:00
Aaron Dodson 78646eae51 clang-format core/variable_map.js 2021-07-29 12:47:51 -07:00
Aaron Dodson 9847b8c027 Migrate core/variable_map.js to named requires 2021-07-29 12:39:58 -07:00
Aaron Dodson 959d976723 Migrate core/variable_map.js to goog.module 2021-07-29 12:34:37 -07:00
Aaron Dodson 1d9c9359f9 Migrate core/variable_map.js to ES6 const/let 2021-07-29 12:30:44 -07:00
Neil Fraser e661c92a36 More JSDoc improvements 2021-05-27 21:30:26 -07:00
Neil Fraser d919b0af21 Update JSDoc from Array.<> to Array<>
Same with Object.
2021-05-27 21:30:26 -07:00
Sam El-Husseini 63d26dc186 Add extra requires check (#4677)
* Add extra requires check
2021-03-05 09:50:51 -08:00
Sam El-Husseini ab8a11784d Fix event related missing requires (#4656)
* Fix event related missing requires
2021-02-25 14:28:11 -08:00
Rachel Fenichel 107181d6f5 Missing requires, r through v 2021-02-17 14:52:06 -08:00
Sam El-Husseini fd916fdb9b Bounding Box interface (#3906)
* Add an interface describing a bounding box registered on the workspace

* Clear the bounding box array

* PR comments

* Update chromedriver
2020-05-19 18:06:11 -07:00
Neil Fraser 4e2f8e6e02 Use SPDX licences.
This is a followup to #3127.
At the time, SPDX licenses were pending approval by Google.
2020-02-11 13:27:20 -08:00
Sam El-Husseini 180926ee77 Fix duplicate variable model type (#3594)
* Resolve duplicate empty var type when returning list of variableModel's types.
2020-01-14 13:10:34 -08:00
Beka Westberg 6d1bb201f7 feat: Improved procedure arg interaction. (#3527)
* feat: Improved procedure arg interaction.

* Added docs.

* Fixed typos and typings.

* Fixed typings?

* Changed visibility to private.
2020-01-07 13:55:46 -08:00
Neil Fraser 123f436e04 Add parens around inline assignments (#3381) 2019-10-31 15:17:35 -07:00
Sam El-Husseini 90ad0789f6 Fix 11 warnings related to variables and variable_model. (#3278)
* Fix 10 warnings related to variables and variable_model.
2019-10-22 14:26:59 -04:00
Sam El-Husseini 664cc3d6cd Fix warnings related to number of arguments passed. (#3270) 2019-10-17 11:47:30 -05:00
Neil Fraser b46a4fe286 Bring our license format up to date (#3127)
* Google changed from an Inc to an LLC.

This happened back in 2017 but we didn’t notice.  Officially we should update files from Inc to LLC when they are changed as part of regular edits, but this is a nightmare to remember for the next decade.

* Remove project description/titles from licenses

This is no longer part of Google’s header requirements.  Our existing descriptions were useless (“Visual Blocks Editor”) or grossly obselete (“Visual Blocks Language”).

* License no longer requires URL.

* Fix license regexps.
2019-10-02 14:46:56 -07:00
Neil Fraser 76af463ec4 Removing require for Blockly.FlyoutButton
Should have been in the previous PR, since that’s the point.

Also, a recompile given all the recent dependency changes.
2019-09-24 12:15:03 -07:00
Neil Fraser 2d3b514425 Ensure last variable category is last variable added.
Resolves #2050.
2019-07-15 14:37:27 -07:00
Neil Fraser 2ac3447383 Create null objects properly.
new Object(null) doesn’t do anything, that’s just broken.
And the for loop with keys is silly.
2019-07-15 14:37:27 -07:00
Neil Fraser 829dcc207c Make type and variabletype attributes optional
If a variable doesn’t have a type, then don’t add these empty attributes in the XML.
2019-07-15 14:37:27 -07:00
alschmiedt 35341959d3 Fixes eslint error 2019-07-09 11:28:36 -07:00
alschmiedt f30d79fbc8 Fixes bug with using dynamic variable in toolbox 2019-07-09 11:02:02 -07:00
Neil Fraser 9f528922a7 Fix some dependencies 2019-05-24 15:45:05 -07:00
Neil Fraser aa09ad9175 Line wrap at 80. 2018-10-16 11:34:10 -07:00
Rachel Fenichel 6092e4c517 Calls to getAllBlocks should pass a value for _ordered_ 2018-09-13 16:06:19 -07:00
Neil Fraser dce60fd152 Replace ReferenceError with Error.
Change to 4-space indentation rather than aligning with parent structure.
2018-07-11 12:20:02 -07:00
Neil Fraser 284b79407e Require Blockly.utils where needed. 2018-07-11 12:20:02 -07:00
Neil Fraser 4cb4b42f8d Use named properties on Msg. 2018-04-27 11:50:51 -07:00
Rachel Fenichel 4c9b602523 Move event classes into separate files, and update requires accordingly 2018-02-27 17:47:33 -08:00
Rachel Fenichel 1e3450a051 Indentation lint that blocks moving to eslint 4.0 2018-01-23 17:27:35 -08:00
Rachel Fenichel fa91c6b36f Make some functions package 2018-01-16 12:41:52 -08:00
Rachel Fenichel a30ad6ff3a More code cleanup for review 2018-01-12 13:28:17 -08:00
Rachel Fenichel bd4e4daebb Update comments and use try/catch with setGroup. 2018-01-09 13:31:13 -08:00
Rachel Fenichel db9a9f5182 Move code from the variable to the variable map. Fixes #1512. 2017-12-15 15:31:41 -08:00
Rachel Fenichel 66975c8f94 Rebase 2017-12-15 13:44:27 -08:00
Rachel Fenichel e77b498504 Respond to review comments in variable_map 2017-12-13 11:50:08 -08:00
Rachel Fenichel b60e70497a Avoid spurious rename event 2017-12-13 11:50:08 -08:00
Rachel Fenichel 279cf83b72 Fix events for variable renaming 2017-12-13 11:50:08 -08:00
Rachel Fenichel 61db23c78a Get rid of workspace.deleteVariable 2017-12-13 11:50:08 -08:00
Rachel Fenichel 779be46a92 Allow variables of different types to share the same name. 2017-12-13 11:50:07 -08:00
picklesrus de8d13eaa1 Fix lint errors so we can eventually run eslint on travis. 2017-11-02 14:05:29 -07:00
Neil Fraser e100c66659 Linting. 2017-10-24 14:06:29 -07:00
Neil Fraser 4262b09002 Resolve 106 warnings. 2017-10-24 14:06:29 -07:00
marisaleung 5f21a43caf Fix type tags and todo placement. 2017-08-03 12:35:14 -07:00
marisaleung 3c8e0ebbeb Dropdown Create does not create a missing variable twice. 2017-06-27 16:51:19 -07:00
marisaleung d937920afc Remove out of date todo comments. 2017-06-20 13:15:28 -07:00
marisaleung 833c2d0c40 Fire VAR events and test. 2017-06-09 14:42:14 -07:00