444 Commits

Author	SHA1	Message	Date
Aaron Dodson	6a4a359f7b	Migrate hideChaff() from Blockly to WorkspaceSvg (#5460) ... * Add hideChaff() to core/workspace_svg.js * Mark Blockly.hideChaff as deprecated * Update uses of Blockly.hideChaff() to WorkspaceSvg.hideChaff() in core * Update uses of Blockly.hideChaff() to WorkspaceSvg.hideChaff() in demos * Style and formatting fixes * Switch from accessor to stub wrapper for Blockly.hideChaff Co-authored-by: Christopher Allen <cpcallen+github@gmail.com> Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>	2021-09-15 13:41:20 -07:00
Christopher Allen	4c40378b9a	Use goog.requireType when importing interfaces (etc.) (#5343) ... * Use goog.requireType when importing I* interfaces Interfaces have no code, so should never be referred to outside of (JSDoc) comments, and so the modules that define only interfaces never need to be goog.require'd - goog.requireType is always sufficient. This commit fixes imports of all modules whose name matches /(.*\.)?I[A-Z]*/ - i.e., the hungarian-notation named ones in core/interfaces/. * Use goog.requireType when only using import for type specifications Where a module is imported only to used in JSDoc comments it can (and should) be goog.requireType'd instead of goog.require'd. * Remove spurious eslint-disable no-unused-vars There were a few cases where modules were being imported with goog.require (because they are referred to in code, not just JSDoc comments) but were prefaced by a spurious eslint suppress. Remove these, restoring the invariant that an import gets an eslint if and only if it is a requireType. * Remove obsolete Closure Compiler error group stricterMissingRequire has been superceded by missingRequire, and now causes a Java null pointer exception if supplied.	2021-08-11 18:50:45 +01:00
Aaron Dodson	6bae1ce9f9	Migrate core/workspace_svg.js to goog.module syntax (#5334) ... * Migrate core/workspace_svg.js to ES6 const/let * Migrate core/workspace_svg.js to goog.module * Migrate core/workspace_svg.js to named requires * clang-format core/workspace_svg.js	2021-08-10 08:09:46 -07:00
kozbial	b636c79ac0	Add description and reorder requires	2021-08-06 18:05:53 -07:00
kozbial	b834d9026b	Add requireType calls for Blockly.WorkspaceComment and Blockly.WorkspaceCommentSvg	2021-08-06 18:05:53 -07:00
kozbial	ef0fcdbcdd	Split Blockly.BlocklyOptions into a separate file	2021-08-05 10:50:44 -07:00
Rachel Fenichel	2e30bbe7ce	Update uses of mainWorkspace in core	2021-07-30 11:30:34 -07:00
Rachel Fenichel	b3f837a8d2	Replace references to constants with internalConstants	2021-07-21 15:33:55 -07:00
Rachel Fenichel	ad5836b26d	Convert more names to use internalConstants	2021-07-21 15:33:55 -07:00
Aaron Dodson	3f55ca59ad	Merge pull request #4969 from gonfunko/scrollin-safari ... Work around WebKit bug that prevents scrolling/zooming the workspace.	2021-07-08 08:25:29 -07:00
Aaron Dodson	49a4fa7898	Merge pull request #4938 from gonfunko/flyout-zoom ... Reflow flyouts when zoom level changes to keep block zoom level in sync.	2021-07-07 10:29:44 -07:00
Maribeth Bottorff	d102cbfab4	Fix Jsdoc by removing trailing comma (#4974)	2021-06-30 16:45:02 -07:00
Aaron Dodson	c163a76807	Removed unused event argument.	2021-06-30 17:52:17 +00:00
Aaron Dodson	5aa8bab22f	Work around WebKit bug that prevents scrolling/zooming the workspace.	2021-06-30 17:40:00 +00:00
Aaron Dodson	627647c7f2	Reflow workspace- and toolbox-owned flyouts when workspace zoom changes.	2021-06-28 11:08:03 -07:00
Monica Kozbial	ff34e067f8	Update positionable jsdoc (#4908)	2021-06-14 13:14:01 -07:00
alschmiedt	9eaca6a1e1	Adds necessary methods for scroll-options plugin (#4893)	2021-06-10 15:50:42 -07:00
Monica Kozbial	d2579a7369	Add removeComponent to ComponentManager (#4884)	2021-06-09 22:29:33 -07:00
Monica Kozbial	11390341b1	Adding IDragTarget support. (#4852)	2021-06-09 13:59:22 -07:00
Neil Fraser	cff7b359f4	Make comments more consistent.	2021-06-09 11:41:42 -07:00
Neil Fraser	76b5517008	Use null-prototype objects for maps ... A {} has a bunch of names already defined on it (like ‘toString’). When using an object as a map with arbitrary keys, it should not inherit from Object.prototype.	2021-06-09 11:41:42 -07:00
Neil Fraser	e661c92a36	More JSDoc improvements	2021-05-27 21:30:26 -07:00
Neil Fraser	d919b0af21	Update JSDoc from Array.<> to Array<> ... Same with Object.	2021-05-27 21:30:26 -07:00
Monica Kozbial	5344ad6c21	Add support for IAutoHideable (#4855)	2021-05-27 17:01:11 -07:00
Monica Kozbial	1cadbb94bd	Rename PluginManager and related elements (#4857) ... * Rename PluginManager and related elements to use component instead of plugin * Rename types to capabilities	2021-05-27 16:14:33 -07:00
Neil Fraser	dd0314bc0b	Normalize comments	2021-05-19 09:57:14 -07:00
Sam El-Husseini	f2f878db8c	Fix multiple strict require warnings (#4793)	2021-04-21 16:46:04 -07:00
alschmiedt	869e4eb366	Update flyout metrics to work with the new metrics manager (#4684)	2021-03-09 17:09:49 -08:00
Monica Kozbial	bea85cda1c	Positionables bugfix (#4685) ... * Apply fixes to positionable logic * Update variable name and add @private annotation	2021-03-08 11:20:30 -08:00
Rachel Fenichel	855185c6cf	Merge pull request #4682 from rachel-fenichel/toolbox_constants ... Use Blockly.utils.toolbox.Position enum everywhere	2021-03-08 10:52:58 -08:00
Monica Kozbial	f837f1e44e	Add zoom support for single-direction-scroll (#4653) ... * Add zoom support for single-direction scroll	2021-03-05 14:37:41 -08:00
Rachel Fenichel	f7e0d5f4ea	Use existing toolbox position enum	2021-03-05 14:16:43 -08:00
alschmiedt	26104d280d	Update metrics to support mutators (#4679)	2021-03-05 11:44:29 -08:00
Monica Kozbial	0246e2a132	Fix flyout metrics and workspace scroll (#4674) ... * Fix flyout metrics and max scroll logic in scroll * Fix horizontal scroll wheel logic	2021-03-05 11:34:29 -08:00
Sam El-Husseini	63d26dc186	Add extra requires check (#4677) ... * Add extra requires check	2021-03-05 09:50:51 -08:00
Monica Kozbial	ef8a5a1fe1	Add PluginManager (#4672) ... * Add PluginManager.	2021-03-04 16:51:06 -08:00
Monica Kozbial	4844a1038c	Adding single-direction scroll options to inject options (#4651) ... * Adding single directions scroll config to inject options	2021-03-03 12:29:10 -08:00
Monica Kozbial	f2cec81584	Adding Positionable interface (#4669) ... * Adding IPositionable interface.	2021-03-02 16:17:17 -08:00
Monica Kozbial	57749e6eb8	Updating bump logic to support single-direction scrollbars (#4652) ... * Updating bump logic to support single-direction scrollbars	2021-03-01 12:20:12 -08:00
Sam El-Husseini	5780399750	Use registry for creating the no-category flyout (#4659) ... * Use registry for creating the horizontal / vertical flyout	2021-03-01 10:00:47 -08:00
Sam El-Husseini	f97730e83c	Sort requires (#4658) ... * Cleanup gulp method to sort requires	2021-02-25 17:17:42 -08:00
Sam El-Husseini	ab8a11784d	Fix event related missing requires (#4656) ... * Fix event related missing requires	2021-02-25 14:28:11 -08:00
Rachel Fenichel	0b09d179ae	Merge pull request #4642 from rachel-fenichel/event_data_type ... Move bind/unbind events functions to new file, with example usage.	2021-02-25 12:00:22 -08:00
Monica Kozbial	dd7e365882	Scrolling readability refactor (#4643) ... * Refactors scrolling logic in scrollbars and adds comments to be more readable * Updates JSDoc description for ScrollbarPair.set and Scrollbar.set	2021-02-24 15:09:43 -08:00
Monica Kozbial	f942736a1e	Erratic scroll fix (#4650) ... * Resize fix * Update fix	2021-02-23 14:35:21 -08:00
Rachel Fenichel	ad37d9e5c6	More renaming	2021-02-23 10:21:46 -08:00
Rachel Fenichel	f20b06faa8	Rename checkAndBind and update comments.	2021-02-23 10:20:13 -08:00
Rachel Fenichel	54c4e8de39	Rename Blockly.eventHandling->Blockly.browserEvents and replace all Blockly.EventData annotations	2021-02-22 13:23:19 -08:00
Rachel Fenichel	2a3f5040e6	Move bind/unbind events functions to new file, with example usage.	2021-02-19 14:34:45 -08:00
Rachel Fenichel	2360a12493	Fix remaining trivial missing requireTypes	2021-02-19 13:17:14 -08:00